Diff
Modified: trunk/Source/WebKit/ChangeLog (239549 => 239550)
--- trunk/Source/WebKit/ChangeLog 2018-12-25 02:00:11 UTC (rev 239549)
+++ trunk/Source/WebKit/ChangeLog 2018-12-25 02:14:37 UTC (rev 239550)
@@ -1,5 +1,28 @@
2018-12-24 Fujii Hironori <[email protected]>
+ [WebKit][Win] Remove using namespace in the global scope
+ https://bugs.webkit.org/show_bug.cgi?id=192968
+
+ Reviewed by Alex Christensen.
+
+ Moved using namespace statements in the global scope to inside
+ namespaces.
+ <https://webkit.org/code-style-guidelines/#using-position>
+
+ * NetworkProcess/Cookies/curl/WebCookieManagerCurl.cpp:
+ * NetworkProcess/curl/NetworkDataTaskCurl.cpp:
+ * NetworkProcess/curl/NetworkProcessCurl.cpp:
+ * NetworkProcess/curl/NetworkSessionCurl.cpp:
+ * NetworkProcess/curl/RemoteNetworkingContextCurl.cpp:
+ * Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp:
+ * Shared/WebWheelEvent.cpp:
+ * Shared/curl/WebCoreArgumentCodersCurl.cpp:
+ * Shared/win/NativeWebKeyboardEventWin.cpp:
+ * Shared/win/WebEventFactory.cpp:
+ * UIProcess/Automation/WebAutomationSession.cpp:
+
+2018-12-24 Fujii Hironori <[email protected]>
+
Remove "using namespace std;"
https://bugs.webkit.org/show_bug.cgi?id=192973
Modified: trunk/Source/WebKit/NetworkProcess/Cookies/curl/WebCookieManagerCurl.cpp (239549 => 239550)
--- trunk/Source/WebKit/NetworkProcess/Cookies/curl/WebCookieManagerCurl.cpp 2018-12-25 02:00:11 UTC (rev 239549)
+++ trunk/Source/WebKit/NetworkProcess/Cookies/curl/WebCookieManagerCurl.cpp 2018-12-25 02:14:37 UTC (rev 239550)
@@ -31,10 +31,10 @@
#include <WebCore/NetworkStorageSession.h>
#include <wtf/text/CString.h>
+namespace WebKit {
+
using namespace WebCore;
-namespace WebKit {
-
void WebCookieManager::platformSetHTTPCookieAcceptPolicy(HTTPCookieAcceptPolicy)
{
}
Modified: trunk/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp (239549 => 239550)
--- trunk/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp 2018-12-25 02:00:11 UTC (rev 239549)
+++ trunk/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp 2018-12-25 02:14:37 UTC (rev 239550)
@@ -37,10 +37,10 @@
#include <WebCore/ResourceError.h>
#include <WebCore/SameSiteInfo.h>
+namespace WebKit {
+
using namespace WebCore;
-namespace WebKit {
-
NetworkDataTaskCurl::NetworkDataTaskCurl(NetworkSession& session, NetworkDataTaskClient& client, const ResourceRequest& requestWithCredentials, StoredCredentialsPolicy storedCredentialsPolicy, ContentSniffingPolicy shouldContentSniff, ContentEncodingSniffingPolicy, bool shouldClearReferrerOnHTTPSToHTTPRedirect, bool dataTaskIsForMainFrameNavigation)
: NetworkDataTask(session, client, requestWithCredentials, storedCredentialsPolicy, shouldClearReferrerOnHTTPSToHTTPRedirect, dataTaskIsForMainFrameNavigation)
{
Modified: trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp (239549 => 239550)
--- trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp 2018-12-25 02:00:11 UTC (rev 239549)
+++ trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp 2018-12-25 02:14:37 UTC (rev 239550)
@@ -32,10 +32,10 @@
#include <WebCore/NetworkStorageSession.h>
#include <WebCore/NotImplemented.h>
+namespace WebKit {
+
using namespace WebCore;
-namespace WebKit {
-
void NetworkProcess::platformInitializeNetworkProcess(const NetworkProcessCreationParameters& parameters)
{
if (!parameters.cookiePersistentStorageFile.isEmpty())
Modified: trunk/Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp (239549 => 239550)
--- trunk/Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp 2018-12-25 02:00:11 UTC (rev 239549)
+++ trunk/Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp 2018-12-25 02:14:37 UTC (rev 239550)
@@ -30,10 +30,10 @@
#include <WebCore/CurlContext.h>
#include <WebCore/NetworkStorageSession.h>
+namespace WebKit {
+
using namespace WebCore;
-namespace WebKit {
-
NetworkSessionCurl::NetworkSessionCurl(NetworkSessionCreationParameters&& parameters)
: NetworkSession(parameters.sessionID)
{
Modified: trunk/Source/WebKit/NetworkProcess/curl/RemoteNetworkingContextCurl.cpp (239549 => 239550)
--- trunk/Source/WebKit/NetworkProcess/curl/RemoteNetworkingContextCurl.cpp 2018-12-25 02:00:11 UTC (rev 239549)
+++ trunk/Source/WebKit/NetworkProcess/curl/RemoteNetworkingContextCurl.cpp 2018-12-25 02:14:37 UTC (rev 239550)
@@ -31,10 +31,10 @@
#include "WebsiteDataStoreParameters.h"
#include <WebCore/NetworkStorageSession.h>
+namespace WebKit {
+
using namespace WebCore;
-namespace WebKit {
-
void RemoteNetworkingContext::ensureWebsiteDataStoreSession(WebsiteDataStoreParameters&& parameters)
{
auto sessionID = parameters.networkSessionParameters.sessionID;
Modified: trunk/Source/WebKit/Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp (239549 => 239550)
--- trunk/Source/WebKit/Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp 2018-12-25 02:00:11 UTC (rev 239549)
+++ trunk/Source/WebKit/Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp 2018-12-25 02:14:37 UTC (rev 239550)
@@ -29,10 +29,10 @@
#include "NetscapePluginModule.h"
+namespace WebKit {
+
using namespace WebCore;
-namespace WebKit {
-
bool NetscapePluginModule::getPluginInfo(const String&, PluginModuleInfo&)
{
return false;
Modified: trunk/Source/WebKit/Shared/WebWheelEvent.cpp (239549 => 239550)
--- trunk/Source/WebKit/Shared/WebWheelEvent.cpp 2018-12-25 02:00:11 UTC (rev 239549)
+++ trunk/Source/WebKit/Shared/WebWheelEvent.cpp 2018-12-25 02:14:37 UTC (rev 239550)
@@ -28,7 +28,8 @@
#include "WebCoreArgumentCoders.h"
-namespace WebKit {
+namespace WebKit {
+
using namespace WebCore;
WebWheelEvent::WebWheelEvent(Type type, const IntPoint& position, const IntPoint& globalPosition, const FloatSize& delta, const FloatSize& wheelTicks, Granularity granularity, Modifiers modifiers, WallTime timestamp)
Modified: trunk/Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.cpp (239549 => 239550)
--- trunk/Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.cpp 2018-12-25 02:00:11 UTC (rev 239549)
+++ trunk/Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.cpp 2018-12-25 02:14:37 UTC (rev 239550)
@@ -35,10 +35,10 @@
#include <WebCore/ResourceResponse.h>
#include <wtf/text/CString.h>
+namespace IPC {
+
using namespace WebCore;
-namespace IPC {
-
void ArgumentCoder<ResourceRequest>::encodePlatformData(Encoder& encoder, const ResourceRequest& resourceRequest)
{
resourceRequest.encodeWithPlatformData(encoder);
Modified: trunk/Source/WebKit/Shared/win/NativeWebKeyboardEventWin.cpp (239549 => 239550)
--- trunk/Source/WebKit/Shared/win/NativeWebKeyboardEventWin.cpp 2018-12-25 02:00:11 UTC (rev 239549)
+++ trunk/Source/WebKit/Shared/win/NativeWebKeyboardEventWin.cpp 2018-12-25 02:14:37 UTC (rev 239550)
@@ -29,10 +29,10 @@
#include "WebEventFactory.h"
+namespace WebKit {
+
using namespace WebCore;
-namespace WebKit {
-
NativeWebKeyboardEvent::NativeWebKeyboardEvent(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
: WebKeyboardEvent(WebEventFactory::createWebKeyboardEvent(hwnd, message, wParam, lParam))
, m_nativeEvent(createNativeEvent(hwnd, message, wParam, lParam))
Modified: trunk/Source/WebKit/Shared/win/WebEventFactory.cpp (239549 => 239550)
--- trunk/Source/WebKit/Shared/win/WebEventFactory.cpp 2018-12-25 02:00:11 UTC (rev 239549)
+++ trunk/Source/WebKit/Shared/win/WebEventFactory.cpp 2018-12-25 02:14:37 UTC (rev 239550)
@@ -34,10 +34,10 @@
#include <windowsx.h>
#include <wtf/ASCIICType.h>
+namespace WebKit {
+
using namespace WebCore;
-namespace WebKit {
-
static inline LPARAM relativeCursorPosition(HWND hwnd)
{
POINT point = { -1, -1 };
Modified: trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp (239549 => 239550)
--- trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2018-12-25 02:00:11 UTC (rev 239549)
+++ trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2018-12-25 02:14:37 UTC (rev 239550)
@@ -51,10 +51,10 @@
#include <wtf/UUID.h>
#include <wtf/text/StringConcatenate.h>
+namespace WebKit {
+
using namespace Inspector;
-namespace WebKit {
-
String AutomationCommandError::toProtocolString()
{
String protocolErrorName = Inspector::Protocol::AutomationHelpers::getEnumConstantValue(type);
