Title: [239562] trunk
- Revision
- 239562
- Author
- [email protected]
- Date
- 2018-12-30 13:23:11 -0800 (Sun, 30 Dec 2018)
Log Message
gperf is only used in WebCore
https://bugs.webkit.org/show_bug.cgi?id=193061
Reviewed by Don Olmstead.
gperf is only used in WebCore. So if the port does not have WebCore,
it is not necessary. For example, JSCOnly port does not require it.
This patch removes gperf dependency in these ports by checking
ENABLE_WEBCORE.
* Source/cmake/WebKitCommon.cmake:
Modified Paths
Diff
Modified: trunk/ChangeLog (239561 => 239562)
--- trunk/ChangeLog 2018-12-30 21:19:09 UTC (rev 239561)
+++ trunk/ChangeLog 2018-12-30 21:23:11 UTC (rev 239562)
@@ -1,3 +1,17 @@
+2018-12-30 Yusuke Suzuki <[email protected]>
+
+ gperf is only used in WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=193061
+
+ Reviewed by Don Olmstead.
+
+ gperf is only used in WebCore. So if the port does not have WebCore,
+ it is not necessary. For example, JSCOnly port does not require it.
+ This patch removes gperf dependency in these ports by checking
+ ENABLE_WEBCORE.
+
+ * Source/cmake/WebKitCommon.cmake:
+
2018-12-28 Yusuke Suzuki <[email protected]>
Add ENABLE_UNIFIED_BUILDS option to cmake ports
Modified: trunk/Source/cmake/WebKitCommon.cmake (239561 => 239562)
--- trunk/Source/cmake/WebKitCommon.cmake 2018-12-30 21:19:09 UTC (rev 239561)
+++ trunk/Source/cmake/WebKitCommon.cmake 2018-12-30 21:23:11 UTC (rev 239562)
@@ -13,9 +13,6 @@
list(APPEND CMAKE_PROGRAM_PATH $ENV{SystemDrive}/cygwin/bin)
endif ()
- # TODO Enforce version requirement for gperf
- find_package(Gperf 3.0.1 REQUIRED)
-
# TODO Enforce version requirement for perl
find_package(Perl 5.10.0 REQUIRED)
find_package(PerlModules COMPONENTS JSON::PP REQUIRED)
@@ -58,6 +55,13 @@
include(OptionsCommon)
include(Options${PORT})
+ # Check gperf after including OptionsXXX.cmake since gperf is required only when ENABLE_WEBCORE is true,
+ # and ENABLE_WEBCORE is configured in OptionsXXX.cmake.
+ if (ENABLE_WEBCORE)
+ # TODO Enforce version requirement for gperf
+ find_package(Gperf 3.0.1 REQUIRED)
+ endif ()
+
# -----------------------------------------------------------------------------
# Job pool to avoid running too many memory hungry linker processes
# -----------------------------------------------------------------------------
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
