Title: [239570] trunk/Tools
- Revision
- 239570
- Author
- [email protected]
- Date
- 2019-01-02 10:50:16 -0800 (Wed, 02 Jan 2019)
Log Message
[lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
https://bugs.webkit.org/show_bug.cgi?id=193023
Reviewed by Simon Fraser.
The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
enumerator values. We should just remove this code.
* lldb/lldb_webkit.py:
(WTFOptionSetProvider.has_children):
(WTFOptionSetProvider.num_children):
(WTFOptionSetProvider.get_child_index):
(WTFOptionSetProvider.get_child_at_index):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (239569 => 239570)
--- trunk/Tools/ChangeLog 2019-01-02 17:59:08 UTC (rev 239569)
+++ trunk/Tools/ChangeLog 2019-01-02 18:50:16 UTC (rev 239570)
@@ -1,3 +1,20 @@
+2019-01-02 Daniel Bates <[email protected]>
+
+ [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
+ https://bugs.webkit.org/show_bug.cgi?id=193023
+
+ Reviewed by Simon Fraser.
+
+ The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
+ not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
+ enumerator values. We should just remove this code.
+
+ * lldb/lldb_webkit.py:
+ (WTFOptionSetProvider.has_children):
+ (WTFOptionSetProvider.num_children):
+ (WTFOptionSetProvider.get_child_index):
+ (WTFOptionSetProvider.get_child_at_index):
+
2018-12-29 Yusuke Suzuki <[email protected]>
.ycm_extra_conf.py should handle XXXInlines.h
Modified: trunk/Tools/lldb/lldb_webkit.py (239569 => 239570)
--- trunk/Tools/lldb/lldb_webkit.py 2019-01-02 17:59:08 UTC (rev 239569)
+++ trunk/Tools/lldb/lldb_webkit.py 2019-01-02 18:50:16 UTC (rev 239570)
@@ -705,13 +705,10 @@
def has_children(self):
return bool(self._elements)
- # Metadata is stored at indices greater than or equal to the number of elements in the set.
def num_children(self):
- return len(self._elements) + 1
+ return len(self._elements)
def get_child_index(self, name):
- if name == 'm_storage':
- return self.num_children()
try:
return int(name.lstrip('[').rstrip(']'))
except:
@@ -720,8 +717,6 @@
def get_child_at_index(self, index):
if index < 0 or not self.valobj.IsValid():
return None
- if index == self.num_children():
- return self.storage
if index < len(self._elements):
(name, value) = self._elements[index]
return self.valobj.CreateValueFromExpression(name, str(value))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
