Title: [239579] trunk
- Revision
- 239579
- Author
- commit-qu...@webkit.org
- Date
- 2019-01-02 15:41:56 -0800 (Wed, 02 Jan 2019)
Log Message
Fix resourcetimingbufferfull bubbles attribute
https://bugs.webkit.org/show_bug.cgi?id=193087
Patch by Charles Vazac <cva...@gmail.com> on 2019-01-02
Reviewed by Chris Dumez.
Source/WebCore:
This change is covered by web-platform-tests [1].
[1] https://github.com/web-platform-tests/wpt/blob/master/resource-timing/buffer-full-when-populate-entries.html#L20
* page/Performance.cpp:
(WebCore::Performance::resourceTimingBufferFullTimerFired):
LayoutTests:
* http/wpt/resource-timing/rt-performance-extensions.js:
(promise_test):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (239578 => 239579)
--- trunk/LayoutTests/ChangeLog 2019-01-02 21:32:07 UTC (rev 239578)
+++ trunk/LayoutTests/ChangeLog 2019-01-02 23:41:56 UTC (rev 239579)
@@ -1,3 +1,13 @@
+2019-01-02 Charles Vazac <cva...@gmail.com>
+
+ Fix resourcetimingbufferfull bubbles attribute
+ https://bugs.webkit.org/show_bug.cgi?id=193087
+
+ Reviewed by Chris Dumez.
+
+ * http/wpt/resource-timing/rt-performance-extensions.js:
+ (promise_test):
+
2019-01-02 Simon Fraser <simon.fra...@apple.com>
Support css-color-4 rgb functions
Modified: trunk/LayoutTests/http/wpt/resource-timing/rt-performance-extensions.js (239578 => 239579)
--- trunk/LayoutTests/http/wpt/resource-timing/rt-performance-extensions.js 2019-01-02 21:32:07 UTC (rev 239578)
+++ trunk/LayoutTests/http/wpt/resource-timing/rt-performance-extensions.js 2019-01-02 23:41:56 UTC (rev 239579)
@@ -102,7 +102,7 @@
assert_equals(entries.length, 2, "context should have observed 1 resource");
assert_equals(performance.getEntriesByType("resource").length, 1, "context global buffer should be full at 1 resource");
assert_equals(bufferFullEvent.target, performance, "event should dispatch at the performance object");
- assert_true(bufferFullEvent.bubbles, "event should bubble");
+ assert_false(bufferFullEvent.bubbles, "event should not bubble");
});
}, "resourcetimingbufferfull event properties", {timeout: 3000});
Modified: trunk/Source/WebCore/ChangeLog (239578 => 239579)
--- trunk/Source/WebCore/ChangeLog 2019-01-02 21:32:07 UTC (rev 239578)
+++ trunk/Source/WebCore/ChangeLog 2019-01-02 23:41:56 UTC (rev 239579)
@@ -1,3 +1,17 @@
+2019-01-02 Charles Vazac <cva...@gmail.com>
+
+ Fix resourcetimingbufferfull bubbles attribute
+ https://bugs.webkit.org/show_bug.cgi?id=193087
+
+ Reviewed by Chris Dumez.
+
+ This change is covered by web-platform-tests [1].
+
+ [1] https://github.com/web-platform-tests/wpt/blob/master/resource-timing/buffer-full-when-populate-entries.html#L20
+
+ * page/Performance.cpp:
+ (WebCore::Performance::resourceTimingBufferFullTimerFired):
+
2019-01-02 Simon Fraser <simon.fra...@apple.com>
Rename LayerScrollCoordinationRole to ScrollCoordinationRole and make an enum class
Modified: trunk/Source/WebCore/page/Performance.cpp (239578 => 239579)
--- trunk/Source/WebCore/page/Performance.cpp 2019-01-02 21:32:07 UTC (rev 239578)
+++ trunk/Source/WebCore/page/Performance.cpp 2019-01-02 23:41:56 UTC (rev 239579)
@@ -216,7 +216,7 @@
ASSERT(m_backupResourceTimingBuffer.isEmpty());
m_resourceTimingBufferFullFlag = true;
- dispatchEvent(Event::create(eventNames().resourcetimingbufferfullEvent, Event::CanBubble::Yes, Event::IsCancelable::No));
+ dispatchEvent(Event::create(eventNames().resourcetimingbufferfullEvent, Event::CanBubble::No, Event::IsCancelable::No));
if (m_resourceTimingBufferFullFlag) {
for (auto& entry : backupBuffer)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
