Title: [239586] trunk
- Revision
- 239586
- Author
- [email protected]
- Date
- 2019-01-02 20:33:52 -0800 (Wed, 02 Jan 2019)
Log Message
Homograph with LATIN SMALL LETTER R WITH FISHHOOK
https://bugs.webkit.org/show_bug.cgi?id=192944
Reviewed by Tim Horton.
Source/WTF:
* wtf/cocoa/NSURLExtras.mm:
(WTF::isLookalikeCharacter):
Tools:
* TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (239585 => 239586)
--- trunk/Source/WTF/ChangeLog 2019-01-03 04:05:04 UTC (rev 239585)
+++ trunk/Source/WTF/ChangeLog 2019-01-03 04:33:52 UTC (rev 239586)
@@ -1,3 +1,13 @@
+2019-01-02 Alex Christensen <[email protected]>
+
+ Homograph with LATIN SMALL LETTER R WITH FISHHOOK
+ https://bugs.webkit.org/show_bug.cgi?id=192944
+
+ Reviewed by Tim Horton.
+
+ * wtf/cocoa/NSURLExtras.mm:
+ (WTF::isLookalikeCharacter):
+
2019-01-02 Commit Queue <[email protected]>
Unreviewed, rolling out r239524.
Modified: trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm (239585 => 239586)
--- trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm 2019-01-03 04:05:04 UTC (rev 239585)
+++ trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm 2019-01-03 04:33:52 UTC (rev 239586)
@@ -92,8 +92,6 @@
}
}
-
-
static BOOL isLookalikeCharacter(Optional<UChar32> previousCodePoint, UChar32 charCode)
{
// This function treats the following as unsafe, lookalike characters:
@@ -115,9 +113,11 @@
case 0x00BD: /* VULGAR FRACTION ONE HALF */
case 0x00BE: /* VULGAR FRACTION THREE QUARTERS */
case 0x00ED: /* LATIN SMALL LETTER I WITH ACUTE */
+ /* 0x0131 LATIN SMALL LETTER DOTLESS I is intentionally not considered a lookalike character because it is visually distinguishable from i and it has legitimate use in the Turkish language. */
case 0x01C3: /* LATIN LETTER RETROFLEX CLICK */
case 0x0251: /* LATIN SMALL LETTER ALPHA */
case 0x0261: /* LATIN SMALL LETTER SCRIPT G */
+ case 0x027E: /* LATIN SMALL LETTER R WITH FISHHOOK */
case 0x02D0: /* MODIFIER LETTER TRIANGULAR COLON */
case 0x0335: /* COMBINING SHORT STROKE OVERLAY */
case 0x0337: /* COMBINING SHORT SOLIDUS OVERLAY */
Modified: trunk/Tools/ChangeLog (239585 => 239586)
--- trunk/Tools/ChangeLog 2019-01-03 04:05:04 UTC (rev 239585)
+++ trunk/Tools/ChangeLog 2019-01-03 04:33:52 UTC (rev 239586)
@@ -1,3 +1,13 @@
+2019-01-02 Alex Christensen <[email protected]>
+
+ Homograph with LATIN SMALL LETTER R WITH FISHHOOK
+ https://bugs.webkit.org/show_bug.cgi?id=192944
+
+ Reviewed by Tim Horton.
+
+ * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
+ (TestWebKitAPI::TEST):
+
2019-01-02 Wenson Hsieh <[email protected]>
Add support for using the current text selection as the find string on iOS
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm (239585 => 239586)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm 2019-01-03 04:05:04 UTC (rev 239585)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm 2019-01-03 04:33:52 UTC (rev 239586)
@@ -101,6 +101,7 @@
"xn--qdb1b", // U+05D5 U+05C2
"xn--sdb7a", // U+05D5 U+05C4
"xn--2-zic", // U+0032 U+05E1
+ "xn--uoa", // U+027E
};
for (const String& host : punycodedSpoofHosts) {
auto url = "" host, "/").utf8();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
