Title: [239602] trunk/Source/WebCore
- Revision
- 239602
- Author
- [email protected]
- Date
- 2019-01-03 16:22:22 -0800 (Thu, 03 Jan 2019)
Log Message
Leak of WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback (48 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
<https://webkit.org/b/193122>
<rdar://problem/47022987>
Reviewed by Youenn Fablet.
* Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp:
(WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback::AddRef const):
(WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback::Release const):
- Remove `final` keyword so that
`new rtc::RefCountedObject<RTCCertificateGeneratorCallback>()`
can be called.
(WebCore::LibWebRTCCertificateGenerator::generateCertificate):
- To fix the leak call
`new rtc::RefCountedObject<RTCCertificateGeneratorCallback>()`
to create the object.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (239601 => 239602)
--- trunk/Source/WebCore/ChangeLog 2019-01-03 23:47:59 UTC (rev 239601)
+++ trunk/Source/WebCore/ChangeLog 2019-01-04 00:22:22 UTC (rev 239602)
@@ -1,3 +1,22 @@
+2019-01-03 David Kilzer <[email protected]>
+
+ Leak of WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback (48 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
+ <https://webkit.org/b/193122>
+ <rdar://problem/47022987>
+
+ Reviewed by Youenn Fablet.
+
+ * Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp:
+ (WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback::AddRef const):
+ (WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback::Release const):
+ - Remove `final` keyword so that
+ `new rtc::RefCountedObject<RTCCertificateGeneratorCallback>()`
+ can be called.
+ (WebCore::LibWebRTCCertificateGenerator::generateCertificate):
+ - To fix the leak call
+ `new rtc::RefCountedObject<RTCCertificateGeneratorCallback>()`
+ to create the object.
+
2019-01-03 Simon Fraser <[email protected]>
REGRESSION (r238090): After showing the Find banner or tab bar, hit tests are vertically offset (or painting is not offset)
Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp (239601 => 239602)
--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp 2019-01-03 23:47:59 UTC (rev 239601)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp 2019-01-04 00:22:22 UTC (rev 239602)
@@ -53,8 +53,8 @@
{
}
- void AddRef() const final { ref(); }
- rtc::RefCountReleaseStatus Release() const final
+ void AddRef() const { ref(); }
+ rtc::RefCountReleaseStatus Release() const
{
auto result = refCount() - 1;
deref();
@@ -106,7 +106,7 @@
void generateCertificate(Ref<SecurityOrigin>&& origin, LibWebRTCProvider& provider, const PeerConnectionBackend::CertificateInformation& info, DOMPromiseDeferred<IDLInterface<RTCCertificate>>&& promise)
{
- rtc::scoped_refptr<RTCCertificateGeneratorCallback> callback(new RTCCertificateGeneratorCallback(WTFMove(origin), WTFMove(promise)));
+ rtc::scoped_refptr<RTCCertificateGeneratorCallback> callback(new rtc::RefCountedObject<RTCCertificateGeneratorCallback>(WTFMove(origin), WTFMove(promise)));
absl::optional<uint64_t> expiresMs;
if (info.expires)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
