Title: [239605] trunk
- Revision
- 239605
- Author
- [email protected]
- Date
- 2019-01-03 18:54:41 -0800 (Thu, 03 Jan 2019)
Log Message
test262-runner misbehaves when test file YAML has a trailing space
https://bugs.webkit.org/show_bug.cgi?id=193053
Reviewed by Yusuke Suzuki.
JSTests:
* test262/expectations.yaml:
Mark two dozen tests as passing (and correct the output of another).
Tools:
* Scripts/test262/Runner.pm:
(parseData):
Accept trailing space when parsing a test file's YAML block.
Modified Paths
Diff
Modified: trunk/JSTests/ChangeLog (239604 => 239605)
--- trunk/JSTests/ChangeLog 2019-01-04 02:34:19 UTC (rev 239604)
+++ trunk/JSTests/ChangeLog 2019-01-04 02:54:41 UTC (rev 239605)
@@ -1,3 +1,13 @@
+2019-01-03 Ross Kirsling <[email protected]>
+
+ test262-runner misbehaves when test file YAML has a trailing space
+ https://bugs.webkit.org/show_bug.cgi?id=193053
+
+ Reviewed by Yusuke Suzuki.
+
+ * test262/expectations.yaml:
+ Mark two dozen tests as passing (and correct the output of another).
+
2018-12-30 Yusuke Suzuki <[email protected]>
Unreviewed, JSTests gardening with memoryLimited
Modified: trunk/JSTests/test262/expectations.yaml (239604 => 239605)
--- trunk/JSTests/test262/expectations.yaml 2019-01-04 02:34:19 UTC (rev 239604)
+++ trunk/JSTests/test262/expectations.yaml 2019-01-04 02:54:41 UTC (rev 239605)
@@ -1049,9 +1049,6 @@
test/built-ins/Object/defineProperties/15.2.3.7-5-b-248.js:
default: 'TypeError: Property description must be an object.'
strict mode: 'TypeError: Property description must be an object.'
-test/built-ins/Object/defineProperty/15.2.3.6-4-289-1.js:
- default: "ReferenceError: Can't find variable: verifyEqualTo"
- strict mode: "ReferenceError: Can't find variable: verifyEqualTo"
test/built-ins/Object/internals/DefineOwnProperty/consistent-value-function-arguments.js:
default: 'Test262Error: Expected SameValue(«null», «[object Arguments]») to be true'
test/built-ins/Object/internals/DefineOwnProperty/consistent-value-function-caller.js:
@@ -6782,18 +6779,6 @@
strict mode: "SyntaxError: Cannot use 'yield' as a function name in strict mode."
test/language/expressions/object/method-definition/yield-as-identifier-in-nested-function.js:
strict mode: "SyntaxError: Unexpected keyword 'yield'. Cannot use yield _expression_ out of generator."
-test/language/expressions/object/method-definition/yield-as-logical-or-_expression_.js:
- default: "SyntaxError: Unexpected token '?'"
- strict mode: "SyntaxError: Unexpected token '?'"
-test/language/expressions/object/method-definition/yield-as-parameter.js:
- default: "SyntaxError: Cannot use 'yield' as a parameter name in a generator function."
- strict mode: "SyntaxError: Cannot use 'yield' as a parameter name in strict mode."
-test/language/expressions/object/method-definition/yield-star-after-newline.js:
- default: "SyntaxError: Unexpected token '*'"
- strict mode: "SyntaxError: Unexpected token '*'"
-test/language/expressions/object/method-definition/yield-weak-binding.js:
- default: "SyntaxError: Unexpected number '3'"
- strict mode: "SyntaxError: Unexpected number '3'"
test/language/expressions/object/scope-gen-meth-body-lex-distinct.js:
default: 'Test262Error: Expected a SyntaxError to be thrown but no exception was thrown at all'
test/language/expressions/object/scope-gen-meth-param-elem-var-close.js:
@@ -6953,9 +6938,6 @@
test/language/global-code/script-decl-var-err.js:
default: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all'
strict mode: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all'
-test/language/identifiers/val-yield-strict.js:
- default: 'Test262: This statement should not be evaluated.'
- strict mode: "SyntaxError: Cannot use 'yield' as a variable name in strict mode."
test/language/literals/numeric/numeric-separator-literal-bil-bd-nsl-bd.js:
default: 'SyntaxError: No space between binary literal and identifier'
strict mode: 'SyntaxError: No space between binary literal and identifier'
@@ -7158,8 +7140,7 @@
test/language/module-code/instn-resolve-order-src.js:
module: "SyntaxError: 'break' is only valid inside a switch or loop statement."
test/language/module-code/instn-star-as-props-dflt-skip.js:
- default: "SyntaxError: Unexpected token '{'. import call expects exactly one argument."
- strict mode: "SyntaxError: Unexpected token '{'. import call expects exactly one argument."
+ module: "SyntaxError: Unexpected identifier 'as'. Expected 'from' before exported module name."
test/language/module-code/instn-star-props-nrml.js:
module: "SyntaxError: Unexpected identifier 'as'. Expected 'from' before exported module name."
test/language/module-code/namespace/internals/define-own-property.js:
@@ -7193,24 +7174,6 @@
test/language/statements/class/classelementname-abrupt-completion.js:
default: "SyntaxError: Unexpected token '}'. Expected an opening '(' before a method's parameter list."
strict mode: "SyntaxError: Unexpected token '}'. Expected an opening '(' before a method's parameter list."
-test/language/statements/class/definition/methods-gen-yield-as-function-_expression_-binding-identifier.js:
- default: "SyntaxError: Cannot use 'yield' as a function name in strict mode."
- strict mode: "SyntaxError: Cannot use 'yield' as a function name in strict mode."
-test/language/statements/class/definition/methods-gen-yield-as-identifier-in-nested-function.js:
- default: "SyntaxError: Unexpected keyword 'yield'. Cannot use yield _expression_ out of generator."
- strict mode: "SyntaxError: Unexpected keyword 'yield'. Cannot use yield _expression_ out of generator."
-test/language/statements/class/definition/methods-gen-yield-as-logical-or-_expression_.js:
- default: "SyntaxError: Unexpected token '?'"
- strict mode: "SyntaxError: Unexpected token '?'"
-test/language/statements/class/definition/methods-gen-yield-as-parameter.js:
- default: "SyntaxError: Cannot use 'yield' as a parameter name in strict mode."
- strict mode: "SyntaxError: Cannot use 'yield' as a parameter name in strict mode."
-test/language/statements/class/definition/methods-gen-yield-star-after-newline.js:
- default: "SyntaxError: Unexpected token '*'"
- strict mode: "SyntaxError: Unexpected token '*'"
-test/language/statements/class/definition/methods-gen-yield-weak-binding.js:
- default: "SyntaxError: Unexpected number '3'"
- strict mode: "SyntaxError: Unexpected number '3'"
test/language/statements/class/dstr-private-gen-meth-ary-init-iter-close.js:
default: "SyntaxError: Invalid character: '#'"
strict mode: "SyntaxError: Invalid character: '#'"
@@ -11073,9 +11036,6 @@
default: "SyntaxError: Unexpected escaped characters in keyword token: 'yi\\u0065ld'"
test/language/statements/labeled/value-yield-non-strict.js:
strict mode: "SyntaxError: Cannot use 'yield' as a label in strict mode."
-test/language/statements/labeled/value-yield-strict.js:
- default: 'Test262: This statement should not be evaluated.'
- strict mode: "SyntaxError: Cannot use 'yield' as a label in strict mode."
test/language/statements/let/block-local-closure-set-before-initialization.js:
default: 'Test262Error: Expected a ReferenceError to be thrown but no exception was thrown at all'
test/language/statements/let/syntax/attempt-to-redeclare-let-binding-with-function-declaration.js:
Modified: trunk/Tools/ChangeLog (239604 => 239605)
--- trunk/Tools/ChangeLog 2019-01-04 02:34:19 UTC (rev 239604)
+++ trunk/Tools/ChangeLog 2019-01-04 02:54:41 UTC (rev 239605)
@@ -1,3 +1,14 @@
+2019-01-03 Ross Kirsling <[email protected]>
+
+ test262-runner misbehaves when test file YAML has a trailing space
+ https://bugs.webkit.org/show_bug.cgi?id=193053
+
+ Reviewed by Yusuke Suzuki.
+
+ * Scripts/test262/Runner.pm:
+ (parseData):
+ Accept trailing space when parsing a test file's YAML block.
+
2019-01-03 Michael Catanzaro <[email protected]>
UserMedia test should use WKPageNavigationClient
Modified: trunk/Tools/Scripts/test262/Runner.pm (239604 => 239605)
--- trunk/Tools/Scripts/test262/Runner.pm 2019-01-04 02:34:19 UTC (rev 239604)
+++ trunk/Tools/Scripts/test262/Runner.pm 2019-01-04 02:54:41 UTC (rev 239605)
@@ -871,7 +871,7 @@
my $parsed;
my $found = '';
- if ($contents =~ /\/\*(---[\r\n]+[\S\s]*)[\r\n]+---\*\//m) {
+ if ($contents =~ /\/\*(---[\r\n]+[\S\s]*)[\r\n]+\s*---\*\//m) {
$found = $1;
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
