Title: [239630] trunk/Source/WebInspectorUI
Revision
239630
Author
[email protected]
Date
2019-01-04 12:29:24 -0800 (Fri, 04 Jan 2019)

Log Message

Web Inspector: Include `globalThis` in default _javascript_ completions
https://bugs.webkit.org/show_bug.cgi?id=193147

Patch by Joseph Pecoraro <[email protected]> on 2019-01-04
Reviewed by Devin Rousso.

* UserInterface/Controllers/CodeMirrorCompletionController.js:
Add `globalThis` which is a new global value.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239629 => 239630)


--- trunk/Source/WebInspectorUI/ChangeLog	2019-01-04 20:29:15 UTC (rev 239629)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-01-04 20:29:24 UTC (rev 239630)
@@ -1,3 +1,13 @@
+2019-01-04  Joseph Pecoraro  <[email protected]>
+
+        Web Inspector: Include `globalThis` in default _javascript_ completions
+        https://bugs.webkit.org/show_bug.cgi?id=193147
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Controllers/CodeMirrorCompletionController.js:
+        Add `globalThis` which is a new global value.
+
 2019-01-03  Devin Rousso  <[email protected]>
 
         Web Inspector: conic-gradient color picker doesn't accurately show color when saturation value is not 100%

Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js (239629 => 239630)


--- trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js	2019-01-04 20:29:15 UTC (rev 239629)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js	2019-01-04 20:29:24 UTC (rev 239630)
@@ -661,7 +661,7 @@
             "return", "static", "super", "switch", "this", "throw", "true", "try",
             "typeof", "undefined", "var", "void", "while", "with", "yield"
         ];
-        var valueKeywords = ["false", "Infinity", "NaN", "null", "this", "true", "undefined"];
+        var valueKeywords = ["false", "Infinity", "NaN", "null", "this", "true", "undefined", "globalThis"];
 
         var allowedKeywordsInsideBlocks = allKeywords.keySet();
         var allowedKeywordsWhenDeclaringVariable = valueKeywords.keySet();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to