Title: [239649] trunk/Source/WebInspectorUI
- Revision
- 239649
- Author
- [email protected]
- Date
- 2019-01-04 17:23:52 -0800 (Fri, 04 Jan 2019)
Log Message
Web Inspector: subclasses of WI.ClusterContentView don't save/restore content views after the initial view
https://bugs.webkit.org/show_bug.cgi?id=192451
<rdar://problem/46800958>
Patch by Joseph Pecoraro <[email protected]> on 2019-01-04
Reviewed by Devin Rousso.
* UserInterface/Models/BackForwardEntry.js:
(WI.BackForwardEntry.prototype.prepareToHide):
* UserInterface/Views/ClusterContentView.js:
(WI.ClusterContentView.prototype.get shouldSaveStateOnHide):
* UserInterface/Views/ContentView.js:
(WI.ContentView.prototype.get shouldSaveStateOnHide):
Allow ClusterContentViews to save its state whenever its hidden,
this means it can be properly restored to the last state it had
instead of the initial state it was shown with.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (239648 => 239649)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-01-05 01:12:19 UTC (rev 239648)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-01-05 01:23:52 UTC (rev 239649)
@@ -1,3 +1,21 @@
+2019-01-04 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: subclasses of WI.ClusterContentView don't save/restore content views after the initial view
+ https://bugs.webkit.org/show_bug.cgi?id=192451
+ <rdar://problem/46800958>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Models/BackForwardEntry.js:
+ (WI.BackForwardEntry.prototype.prepareToHide):
+ * UserInterface/Views/ClusterContentView.js:
+ (WI.ClusterContentView.prototype.get shouldSaveStateOnHide):
+ * UserInterface/Views/ContentView.js:
+ (WI.ContentView.prototype.get shouldSaveStateOnHide):
+ Allow ClusterContentViews to save its state whenever its hidden,
+ this means it can be properly restored to the last state it had
+ instead of the initial state it was shown with.
+
2019-01-04 Devin Rousso <[email protected]>
Web Inspector: Audit: disable breakpoints when running Audit
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/BackForwardEntry.js (239648 => 239649)
--- trunk/Source/WebInspectorUI/UserInterface/Models/BackForwardEntry.js 2019-01-05 01:12:19 UTC (rev 239648)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/BackForwardEntry.js 2019-01-05 01:23:52 UTC (rev 239649)
@@ -93,6 +93,11 @@
this.contentView.hidden();
this._saveScrollPositions();
+
+ if (this._contentView.shouldSaveStateWhenHidden) {
+ this._cookie = {};
+ this._contentView.saveToCookie(this._cookie);
+ }
}
isEqual(other)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js (239648 => 239649)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js 2019-01-05 01:12:19 UTC (rev 239648)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js 2019-01-05 01:23:52 UTC (rev 239649)
@@ -61,6 +61,11 @@
return super.supportsSplitContentBrowser;
}
+ get shouldSaveStateWhenHidden()
+ {
+ return true;
+ }
+
shown()
{
super.shown();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js (239648 => 239649)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js 2019-01-05 01:12:19 UTC (rev 239648)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js 2019-01-05 01:23:52 UTC (rev 239649)
@@ -355,6 +355,11 @@
return false;
}
+ get shouldSaveStateWhenHidden()
+ {
+ return false;
+ }
+
get selectionPathComponents()
{
// Implemented by subclasses.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
