Title: [239656] trunk/LayoutTests
- Revision
- 239656
- Author
- [email protected]
- Date
- 2019-01-05 03:30:16 -0800 (Sat, 05 Jan 2019)
Log Message
Unreviewed, rolling out r239607.
https://bugs.webkit.org/show_bug.cgi?id=193169
This change makes the test even more flaky (Requested by fredw
on #webkit).
Reverted changeset:
"Flaky Test: http/wpt/css/css-animations/start-
animation-001.html"
https://bugs.webkit.org/show_bug.cgi?id=190903
https://trac.webkit.org/changeset/239607
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (239655 => 239656)
--- trunk/LayoutTests/ChangeLog 2019-01-05 08:38:41 UTC (rev 239655)
+++ trunk/LayoutTests/ChangeLog 2019-01-05 11:30:16 UTC (rev 239656)
@@ -1,3 +1,18 @@
+2019-01-05 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r239607.
+ https://bugs.webkit.org/show_bug.cgi?id=193169
+
+ This change makes the test even more flaky (Requested by fredw
+ on #webkit).
+
+ Reverted changeset:
+
+ "Flaky Test: http/wpt/css/css-animations/start-
+ animation-001.html"
+ https://bugs.webkit.org/show_bug.cgi?id=190903
+ https://trac.webkit.org/changeset/239607
+
2019-01-04 Daniel Bates <[email protected]>
REGRESSION (r238522): Erratic scrolling on Google flights search result page and vrbo.com
Modified: trunk/LayoutTests/http/wpt/css/css-animations/start-animation-001.html (239655 => 239656)
--- trunk/LayoutTests/http/wpt/css/css-animations/start-animation-001.html 2019-01-05 08:38:41 UTC (rev 239655)
+++ trunk/LayoutTests/http/wpt/css/css-animations/start-animation-001.html 2019-01-05 11:30:16 UTC (rev 239656)
@@ -53,33 +53,18 @@
}
</style>
<script>
- function squareLeft(id) {
- var element = document.getElementById(id);
- if (id === "squareNonAccelerated")
- return element.getBoundingClientRect().left;
- var transform = window.getComputedStyle(element).getPropertyValue("transform");
- var match = /matrix\(1, 0, 0, 1, (.*), 0\)/.exec(transform);
- return match ? parseFloat(match[1]) : 0;
+ function runTest() {
+ if (!window.testRunner)
+ return;
+ // We wait a bit after the squares are moved behind the blue rectangle. For discontinuous
+ // transforms we have 5000px / 100 steps = 5px/step. Hence this happens after 20 steps i.e.
+ // 20/100*10s = 200ms.
+ testRunner.waitUntilDone();
+ setTimeout(() => { testRunner.notifyDone(); }, 300);
}
- function shouldBeHiddenByCoveringRect(id) {
- var coveringRectLeft = document.getElementById("coveringRect").getBoundingClientRect().left;
- return squareLeft(id) > coveringRectLeft;
- }
- // We wait until all the squares are moved behind the blue rectangle.
- if (window.testRunner)
- testRunner.waitUntilDone();
- function step() {
- if (["squareLinear", "squareSteps", "squareNonAccelerated"].every(shouldBeHiddenByCoveringRect)) {
- if (window.testRunner)
- testRunner.notifyDone();
- return;
- }
- window.requestAnimationFrame(step);
- }
- window.requestAnimationFrame(step);
</script>
</head>
- <body>
+ <body _onload_="runTest()">
<p>This test passes if green squares are moved behind the blue rectangle.</p>
<div id="container">
<div id="squareLinear"><tt>transform</tt> (linear)</div>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
