Title: [101952] trunk/Source/WebKit/efl
Revision
101952
Author
[email protected]
Date
2011-12-04 03:32:26 -0800 (Sun, 04 Dec 2011)

Log Message

[EFL] Fix broken UTF-8 characters issue on editor command.
https://bugs.webkit.org/show_bug.cgi?id=73516

Patch by Kangil Han <[email protected]> on 2011-12-04
Reviewed by Ryosuke Niwa.

The issue has been described that Korean character is broken on pasting copied text.
In my analysis, this is from lack of format change between C style UTF-8 character pointer and C++ style String reference.
Therefore, this patch will convert types to resolve the problem.

* ewk/ewk_view.cpp:
(_ewk_view_editor_command):

Modified Paths

Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (101951 => 101952)


--- trunk/Source/WebKit/efl/ChangeLog	2011-12-04 09:39:28 UTC (rev 101951)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-12-04 11:32:26 UTC (rev 101952)
@@ -1,3 +1,17 @@
+2011-12-04  Kangil Han  <[email protected]>
+
+        [EFL] Fix broken UTF-8 characters issue on editor command.
+        https://bugs.webkit.org/show_bug.cgi?id=73516
+
+        Reviewed by Ryosuke Niwa.
+
+        The issue has been described that Korean character is broken on pasting copied text.
+        In my analysis, this is from lack of format change between C style UTF-8 character pointer and C++ style String reference.
+        Therefore, this patch will convert types to resolve the problem.
+
+        * ewk/ewk_view.cpp:
+        (_ewk_view_editor_command):
+
 2011-12-03  ChangSeok Oh  <[email protected]>
 
         [EFL] Revise ewk_view_fixed_layout_size_set

Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (101951 => 101952)


--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2011-12-04 09:39:28 UTC (rev 101951)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2011-12-04 11:32:26 UTC (rev 101952)
@@ -1419,7 +1419,7 @@
 
 static Eina_Bool _ewk_view_editor_command(Ewk_View_Private_Data* priv, const char* command, const char* value = 0)
 {
-    return priv->page->focusController()->focusedOrMainFrame()->editor()->command(WTF::String::fromUTF8(command)).execute(value);
+    return priv->page->focusController()->focusedOrMainFrame()->editor()->command(WTF::String::fromUTF8(command)).execute(WTF::String::fromUTF8(value));
 }
 
 Eina_Bool ewk_view_execute_editor_command(Evas_Object* ewkView, const Ewk_Editor_Command command, const char* value)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to