Diff
Modified: trunk/LayoutTests/ChangeLog (239703 => 239704)
--- trunk/LayoutTests/ChangeLog 2019-01-07 22:41:29 UTC (rev 239703)
+++ trunk/LayoutTests/ChangeLog 2019-01-07 23:15:59 UTC (rev 239704)
@@ -1,3 +1,18 @@
+2019-01-07 Dean Jackson <[email protected]>
+
+ Turn on Pointer Events by default for iOS
+ https://bugs.webkit.org/show_bug.cgi?id=193214
+ <rdar://problem/46974878>
+
+ Reviewed by Wenson Hsieh.
+
+ Skip the pointer events tests everywhere but iOS.
+
+ * TestExpectations:
+ * platform/ios-wk1/TestExpectations:
+ * platform/ios-wk2/TestExpectations:
+ * platform/mac-wk1/TestExpectations:
+
2019-01-07 Devin Rousso <[email protected]>
Web Inspector: extend XHR breakpoints to work with fetch
Modified: trunk/LayoutTests/TestExpectations (239703 => 239704)
--- trunk/LayoutTests/TestExpectations 2019-01-07 22:41:29 UTC (rev 239703)
+++ trunk/LayoutTests/TestExpectations 2019-01-07 23:15:59 UTC (rev 239704)
@@ -446,6 +446,10 @@
# This test was created to test a mac-wk2 bugfix
fast/animation/request-animation-frame-in-two-pages.html [ Skip ]
+# Only supported on iOS
+imported/w3c/web-platform-tests/pointerevents [ Skip ]
+pointerevents [ Skip ]
+
#//////////////////////////////////////////////////////////////////////////////////////////
# End platform-specific tests.
#//////////////////////////////////////////////////////////////////////////////////////////
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (239703 => 239704)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2019-01-07 22:41:29 UTC (rev 239703)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-01-07 23:15:59 UTC (rev 239704)
@@ -1,3 +1,17 @@
+2019-01-07 Dean Jackson <[email protected]>
+
+ Turn on Pointer Events by default for iOS
+ https://bugs.webkit.org/show_bug.cgi?id=193214
+ <rdar://problem/46974878>
+
+ Reviewed by Wenson Hsieh.
+
+ Update expected results.
+
+ * web-platform-tests/pointerevents/extension/pointerevent_touch-action-verification-expected.txt:
+ * web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt:
+ * web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt:
+
2019-01-07 Youenn Fablet <[email protected]>
Resync WPT fetch tests to 834eac4
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/extension/pointerevent_touch-action-verification-expected.txt (239703 => 239704)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/extension/pointerevent_touch-action-verification-expected.txt 2019-01-07 22:41:29 UTC (rev 239703)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/extension/pointerevent_touch-action-verification-expected.txt 2019-01-07 23:15:59 UTC (rev 239704)
@@ -7,45 +7,45 @@
The following pointer types were detected: .
-FAIL default assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL stylesheet-none assert_equals: expected (undefined) undefined but got (string) "none"
-FAIL explicit-auto assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-pan-x assert_equals: expected (undefined) undefined but got (string) "pan-x"
-FAIL explicit-pan-left assert_equals: expected (undefined) undefined but got (string) "pan-left"
-FAIL explicit-pan-right assert_equals: expected (undefined) undefined but got (string) "pan-right"
-FAIL explicit-pan-y assert_equals: expected (undefined) undefined but got (string) "pan-y"
-FAIL explicit-pan-up assert_equals: expected (undefined) undefined but got (string) "pan-up"
-FAIL explicit-pan-down assert_equals: expected (undefined) undefined but got (string) "pan-down"
-FAIL explicit-pinch-zoom assert_equals: expected (undefined) undefined but got (string) "pinch-zoom"
-FAIL explicit-pan-x-pan-y assert_equals: expected (undefined) undefined but got (string) "pan-x pan-y"
-FAIL explicit-pan-y-pan-x assert_equals: expected (undefined) undefined but got (string) "pan-x pan-y"
-FAIL explicit-pan-left-pan-up assert_equals: expected (undefined) undefined but got (string) "pan-left pan-up"
-FAIL explicit-pan-left-pan-down assert_equals: expected (undefined) undefined but got (string) "pan-left pan-down"
-FAIL explicit-pan-right-pan-up assert_equals: expected (undefined) undefined but got (string) "pan-right pan-up"
-FAIL explicit-pan-right-pan-down assert_equals: expected (undefined) undefined but got (string) "pan-right pan-down"
-FAIL explicit-pan-up-pan-left assert_equals: expected (undefined) undefined but got (string) "pan-left pan-up"
-FAIL explicit-pan-up-pan-right assert_equals: expected (undefined) undefined but got (string) "pan-right pan-up"
-FAIL explicit-pan-down-pan-left assert_equals: expected (undefined) undefined but got (string) "pan-left pan-down"
-FAIL explicit-pan-down-pan-right assert_equals: expected (undefined) undefined but got (string) "pan-right pan-down"
-FAIL explicit-pinch-zoom-pan-x-pan-up assert_equals: expected (undefined) undefined but got (string) "pan-x pan-up pinch-zoom"
-FAIL explicit-pinch-zoom-pan-x-pan-y assert_equals: expected (undefined) undefined but got (string) "manipulation"
-FAIL explicit-manipulation assert_equals: expected (undefined) undefined but got (string) "manipulation"
-FAIL explicit-none assert_equals: expected (undefined) undefined but got (string) "none"
-FAIL explicit-invalid-1 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-2 assert_equals: expected (undefined) undefined but got (string) "none"
-FAIL explicit-invalid-3 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-4 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-5 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-6 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-7 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-8 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-9 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-10 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-11 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-12 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-13 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-14 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL not-inherited assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL inherit assert_equals: expected (undefined) undefined but got (string) "none"
-FAIL initial assert_equals: expected (undefined) undefined but got (string) "auto"
+PASS default
+FAIL stylesheet-none assert_equals: expected "auto" but got "none"
+PASS explicit-auto
+FAIL explicit-pan-x assert_equals: expected "auto" but got "pan-x"
+FAIL explicit-pan-left assert_equals: expected "auto" but got "pan-left"
+FAIL explicit-pan-right assert_equals: expected "auto" but got "pan-right"
+FAIL explicit-pan-y assert_equals: expected "auto" but got "pan-y"
+FAIL explicit-pan-up assert_equals: expected "auto" but got "pan-up"
+FAIL explicit-pan-down assert_equals: expected "auto" but got "pan-down"
+FAIL explicit-pinch-zoom assert_equals: expected "auto" but got "pinch-zoom"
+FAIL explicit-pan-x-pan-y assert_equals: expected "auto" but got "pan-x pan-y"
+FAIL explicit-pan-y-pan-x assert_equals: expected "auto" but got "pan-x pan-y"
+FAIL explicit-pan-left-pan-up assert_equals: expected "auto" but got "pan-left pan-up"
+FAIL explicit-pan-left-pan-down assert_equals: expected "auto" but got "pan-left pan-down"
+FAIL explicit-pan-right-pan-up assert_equals: expected "auto" but got "pan-right pan-up"
+FAIL explicit-pan-right-pan-down assert_equals: expected "auto" but got "pan-right pan-down"
+FAIL explicit-pan-up-pan-left assert_equals: expected "auto" but got "pan-left pan-up"
+FAIL explicit-pan-up-pan-right assert_equals: expected "auto" but got "pan-right pan-up"
+FAIL explicit-pan-down-pan-left assert_equals: expected "auto" but got "pan-left pan-down"
+FAIL explicit-pan-down-pan-right assert_equals: expected "auto" but got "pan-right pan-down"
+FAIL explicit-pinch-zoom-pan-x-pan-up assert_equals: expected "auto" but got "pan-x pan-up pinch-zoom"
+FAIL explicit-pinch-zoom-pan-x-pan-y assert_equals: expected "auto" but got "manipulation"
+PASS explicit-manipulation
+FAIL explicit-none assert_equals: expected "auto" but got "none"
+PASS explicit-invalid-1
+FAIL explicit-invalid-2 assert_equals: expected "auto" but got "none"
+PASS explicit-invalid-3
+PASS explicit-invalid-4
+PASS explicit-invalid-5
+PASS explicit-invalid-6
+PASS explicit-invalid-7
+PASS explicit-invalid-8
+PASS explicit-invalid-9
+PASS explicit-invalid-10
+PASS explicit-invalid-11
+PASS explicit-invalid-12
+PASS explicit-invalid-13
+PASS explicit-invalid-14
+PASS not-inherited
+FAIL inherit assert_equals: expected "auto" but got "none"
+PASS initial
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt (239703 => 239704)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt 2019-01-07 22:41:29 UTC (rev 239703)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt 2019-01-07 23:15:59 UTC (rev 239704)
@@ -7,7 +7,7 @@
The following pointer types were detected: (none).
-FAIL 'pan-x none' is corrected properly assert_true: 'pan-x none' is corrected properly expected true got false
-FAIL 'pan-y none' is corrected properly assert_true: 'pan-y none' is corrected properly expected true got false
-FAIL 'auto none' is corrected properly assert_true: 'auto none' is corrected properly expected true got false
+PASS 'pan-x none' is corrected properly
+PASS 'pan-y none' is corrected properly
+PASS 'auto none' is corrected properly
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt (239703 => 239704)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt 2019-01-07 22:41:29 UTC (rev 239703)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt 2019-01-07 23:15:59 UTC (rev 239704)
@@ -5,29 +5,29 @@
touch-action: basic verification
-FAIL default assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL stylesheet-none assert_equals: expected (undefined) undefined but got (string) "none"
-FAIL explicit-auto assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-pan-x assert_equals: expected (undefined) undefined but got (string) "pan-x"
-FAIL explicit-pan-y assert_equals: expected (undefined) undefined but got (string) "pan-y"
-FAIL explicit-pan-x-pan-y assert_equals: expected (undefined) undefined but got (string) "pan-x pan-y"
-FAIL explicit-pan-y-pan-x assert_equals: expected (undefined) undefined but got (string) "pan-x pan-y"
-FAIL explicit-manipulation assert_equals: expected (undefined) undefined but got (string) "manipulation"
-FAIL explicit-none assert_equals: expected (undefined) undefined but got (string) "none"
-FAIL explicit-invalid-1 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-2 assert_equals: expected (undefined) undefined but got (string) "none"
-FAIL explicit-invalid-3 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-4 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-5 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-6 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-7 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-8 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-9 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-10 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-11 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-12 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-13 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL not-inherited assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL inherit assert_equals: expected (undefined) undefined but got (string) "none"
-FAIL initial assert_equals: expected (undefined) undefined but got (string) "auto"
+PASS default
+FAIL stylesheet-none assert_equals: expected "auto" but got "none"
+PASS explicit-auto
+FAIL explicit-pan-x assert_equals: expected "auto" but got "pan-x"
+FAIL explicit-pan-y assert_equals: expected "auto" but got "pan-y"
+FAIL explicit-pan-x-pan-y assert_equals: expected "auto" but got "pan-x pan-y"
+FAIL explicit-pan-y-pan-x assert_equals: expected "auto" but got "pan-x pan-y"
+PASS explicit-manipulation
+FAIL explicit-none assert_equals: expected "auto" but got "none"
+PASS explicit-invalid-1
+FAIL explicit-invalid-2 assert_equals: expected "auto" but got "none"
+PASS explicit-invalid-3
+PASS explicit-invalid-4
+PASS explicit-invalid-5
+PASS explicit-invalid-6
+PASS explicit-invalid-7
+PASS explicit-invalid-8
+PASS explicit-invalid-9
+PASS explicit-invalid-10
+PASS explicit-invalid-11
+PASS explicit-invalid-12
+PASS explicit-invalid-13
+PASS not-inherited
+FAIL inherit assert_equals: expected "auto" but got "none"
+PASS initial
Modified: trunk/LayoutTests/platform/ios-wk1/TestExpectations (239703 => 239704)
--- trunk/LayoutTests/platform/ios-wk1/TestExpectations 2019-01-07 22:41:29 UTC (rev 239703)
+++ trunk/LayoutTests/platform/ios-wk1/TestExpectations 2019-01-07 23:15:59 UTC (rev 239704)
@@ -23,10 +23,6 @@
# Not supported on WK1
media/no-fullscreen-when-hidden.html [ Skip ]
-# Skip pointerevents on WK1
-pointerevents [ Skip ]
-imported/w3c/web-platform-tests/pointerevents [ Skip ]
-
# Datalist is unsupported in WK1
fast/forms/datalist [ WontFix ]
imported/w3c/web-platform-tests/html/semantics/forms/the-datalist-element [ WontFix ]
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (239703 => 239704)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2019-01-07 22:41:29 UTC (rev 239703)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2019-01-07 23:15:59 UTC (rev 239704)
@@ -55,6 +55,9 @@
webkit.org/b/187773 http/tests/webAPIStatistics [ Pass ]
+imported/w3c/web-platform-tests/pointerevents [ Pass ]
+pointerevents [ Pass ]
+
#//////////////////////////////////////////////////////////////////////////////////////////
# End platform-specific directories.
#//////////////////////////////////////////////////////////////////////////////////////////
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (239703 => 239704)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2019-01-07 22:41:29 UTC (rev 239703)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2019-01-07 23:15:59 UTC (rev 239704)
@@ -166,10 +166,6 @@
webrtc/datachannel/mdns-ice-candidates.html [ Skip ]
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html [ Failure ]
-# Skip pointerevents on WK1
-pointerevents [ Skip ]
-imported/w3c/web-platform-tests/pointerevents [ Skip ]
-
# Datalist is unsupported in WK1
fast/forms/datalist [ WontFix ]
imported/w3c/web-platform-tests/html/semantics/forms/the-datalist-element [ WontFix ]
Modified: trunk/Source/WebKit/ChangeLog (239703 => 239704)
--- trunk/Source/WebKit/ChangeLog 2019-01-07 22:41:29 UTC (rev 239703)
+++ trunk/Source/WebKit/ChangeLog 2019-01-07 23:15:59 UTC (rev 239704)
@@ -1,3 +1,16 @@
+2019-01-07 Dean Jackson <[email protected]>
+
+ Turn on Pointer Events by default for iOS
+ https://bugs.webkit.org/show_bug.cgi?id=193214
+ <rdar://problem/46974878>
+
+ Reviewed by Wenson Hsieh.
+
+ Turn on Pointer Events.
+
+ * Shared/WebPreferences.yaml:
+ * Shared/WebPreferencesDefaultValues.h: Make a new #define for iOS.
+
2019-01-07 Alex Christensen <[email protected]>
Remove use of NetworkProcess::singleton in ServiceWorker code
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (239703 => 239704)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2019-01-07 22:41:29 UTC (rev 239703)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2019-01-07 23:15:59 UTC (rev 239704)
@@ -1240,7 +1240,7 @@
PointerEventsEnabled:
type: bool
- defaultValue: false
+ defaultValue: DEFAULT_POINTER_EVENTS_ENABLED
humanReadableName: "Pointer Events"
humanReadableDescription: "Enable Pointer Events"
webcoreBinding: RuntimeEnabledFeatures
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (239703 => 239704)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2019-01-07 22:41:29 UTC (rev 239703)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2019-01-07 23:15:59 UTC (rev 239704)
@@ -208,6 +208,12 @@
#define DEFAULT_SERVICE_WORKERS_ENABLED false
#endif
+#if PLATFORM(IOS_FAMILY)
+#define DEFAULT_POINTER_EVENTS_ENABLED true
+#else
+#define DEFAULT_POINTER_EVENTS_ENABLED false
+#endif
+
#if PLATFORM(MAC) || PLATFORM(IOS)
#define DEFAULT_PROCESS_SWAP_ON_CROSS_SITE_NAVIGATION_ENABLED true
#else
