Title: [239718] trunk/Tools
- Revision
- 239718
- Author
- [email protected]
- Date
- 2019-01-07 17:37:58 -0800 (Mon, 07 Jan 2019)
Log Message
[Win] EWS: wincairo-ews cannot apply a patch with *.png
https://bugs.webkit.org/show_bug.cgi?id=193044
Reviewed by Daniel Bates.
WinCairo EWS bots are using Windows Perl. Binary files should be
opened as binary mode.
* Scripts/svn-apply:
(handleGitBinaryChange): Use 'binmode' for binary file handles.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (239717 => 239718)
--- trunk/Tools/ChangeLog 2019-01-08 01:18:31 UTC (rev 239717)
+++ trunk/Tools/ChangeLog 2019-01-08 01:37:58 UTC (rev 239718)
@@ -1,3 +1,16 @@
+2019-01-07 Fujii Hironori <[email protected]>
+
+ [Win] EWS: wincairo-ews cannot apply a patch with *.png
+ https://bugs.webkit.org/show_bug.cgi?id=193044
+
+ Reviewed by Daniel Bates.
+
+ WinCairo EWS bots are using Windows Perl. Binary files should be
+ opened as binary mode.
+
+ * Scripts/svn-apply:
+ (handleGitBinaryChange): Use 'binmode' for binary file handles.
+
2019-01-07 Don Olmstead <[email protected]>
[CMake] Add ENABLE_CSS_TYPED_OM option
Modified: trunk/Tools/Scripts/svn-apply (239717 => 239718)
--- trunk/Tools/Scripts/svn-apply 2019-01-08 01:18:31 UTC (rev 239717)
+++ trunk/Tools/Scripts/svn-apply 2019-01-08 01:37:58 UTC (rev 239718)
@@ -264,6 +264,7 @@
if (open FILE, $fullPath) {
die "$fullPath already exists" if $isFileAddition;
+ binmode(FILE);
$originalContents = join("", <FILE>);
close FILE;
}
@@ -286,6 +287,7 @@
die "Original content of $fullPath mismatches" if $originalContents ne applyGitBinaryPatchDelta($reverseBinaryChunk, $out);
}
open FILE, ">", $fullPath or die "Failed to open $fullPath.";
+ binmode(FILE);
print FILE $out;
close FILE;
if ($isFileAddition) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes