Title: [239757] trunk/Source/WebKit
- Revision
- 239757
- Author
- jiewen_...@apple.com
- Date
- 2019-01-08 17:11:08 -0800 (Tue, 08 Jan 2019)
Log Message
[Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=192061
Reviewed by Dewei Zhu.
Part 6.
Add some additional temporary logging info to determine if data is actually sent.
Once the bug is determined and fixed, we should remove all logging added in this patch.
* UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
(WebKit::MockHidConnection::send):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (239756 => 239757)
--- trunk/Source/WebKit/ChangeLog 2019-01-09 01:09:06 UTC (rev 239756)
+++ trunk/Source/WebKit/ChangeLog 2019-01-09 01:11:08 UTC (rev 239757)
@@ -1,5 +1,20 @@
2019-01-08 Jiewen Tan <jiewen_...@apple.com>
+ [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=192061
+
+ Reviewed by Dewei Zhu.
+
+ Part 6.
+
+ Add some additional temporary logging info to determine if data is actually sent.
+ Once the bug is determined and fixed, we should remove all logging added in this patch.
+
+ * UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
+ (WebKit::MockHidConnection::send):
+
+2019-01-08 Jiewen Tan <jiewen_...@apple.com>
+
[WebAuthN] Support U2F HID Authenticators on macOS
https://bugs.webkit.org/show_bug.cgi?id=191535
<rdar://problem/47102027>
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp (239756 => 239757)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp 2019-01-09 01:09:06 UTC (rev 239756)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp 2019-01-09 01:11:08 UTC (rev 239757)
@@ -70,17 +70,23 @@
void MockHidConnection::send(Vector<uint8_t>&& data, DataSentCallback&& callback)
{
+ // FIXME(192061): Remove all LOG_ERRORs.
+ LOG_ERROR("Sending data: Phase 1. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
ASSERT(m_initialized);
auto task = makeBlockPtr([weakThis = makeWeakPtr(*this), data = "" callback = WTFMove(callback)]() mutable {
ASSERT(!RunLoop::isMain());
+ LOG_ERROR("Sending data: Phase 2. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
RunLoop::main().dispatch([weakThis, data = "" callback = WTFMove(callback)]() mutable {
+ LOG_ERROR("Sending data: Phase 3. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
if (!weakThis) {
callback(DataSent::No);
return;
}
+ LOG_ERROR("Sending data: Phase 4. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
weakThis->assembleRequest(WTFMove(data));
+ LOG_ERROR("Sending data: Phase 5. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
auto sent = DataSent::Yes;
if (weakThis->stagesMatch() && weakThis->m_configuration.hid->error == Mock::Error::DataNotSent)
sent = DataSent::No;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
