Title: [239805] branches/safari-607-branch/Source/_javascript_Core
- Revision
- 239805
- Author
- [email protected]
- Date
- 2019-01-09 17:38:27 -0800 (Wed, 09 Jan 2019)
Log Message
Cherry-pick r239755. rdar://problem/47158650
Leak of VectorBufferBase.m_buffer (16-64 bytes) under JSC::CompactVariableEnvironment in com.apple.WebKit.WebContent running layout tests
<https://webkit.org/b/193264>
<rdar://problem/46651026>
Reviewed by Yusuke Suzuki.
* parser/VariableEnvironment.cpp:
(JSC::CompactVariableMap::Handle::~Handle): Call delete on
m_environment instead of fastFree() to make sure the destructors
for the Vector instance variables are run. This fixes the leaks
because calling fastFree() would only free the
CompactVariableEnvironment object, but not the heap-based
buffers allocated for the Vector instance variables.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-607-branch/Source/_javascript_Core/ChangeLog (239804 => 239805)
--- branches/safari-607-branch/Source/_javascript_Core/ChangeLog 2019-01-10 01:38:24 UTC (rev 239804)
+++ branches/safari-607-branch/Source/_javascript_Core/ChangeLog 2019-01-10 01:38:27 UTC (rev 239805)
@@ -1,5 +1,42 @@
2019-01-09 Kocsen Chung <[email protected]>
+ Cherry-pick r239755. rdar://problem/47158650
+
+ Leak of VectorBufferBase.m_buffer (16-64 bytes) under JSC::CompactVariableEnvironment in com.apple.WebKit.WebContent running layout tests
+ <https://webkit.org/b/193264>
+ <rdar://problem/46651026>
+
+ Reviewed by Yusuke Suzuki.
+
+ * parser/VariableEnvironment.cpp:
+ (JSC::CompactVariableMap::Handle::~Handle): Call delete on
+ m_environment instead of fastFree() to make sure the destructors
+ for the Vector instance variables are run. This fixes the leaks
+ because calling fastFree() would only free the
+ CompactVariableEnvironment object, but not the heap-based
+ buffers allocated for the Vector instance variables.
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-01-08 David Kilzer <[email protected]>
+
+ Leak of VectorBufferBase.m_buffer (16-64 bytes) under JSC::CompactVariableEnvironment in com.apple.WebKit.WebContent running layout tests
+ <https://webkit.org/b/193264>
+ <rdar://problem/46651026>
+
+ Reviewed by Yusuke Suzuki.
+
+ * parser/VariableEnvironment.cpp:
+ (JSC::CompactVariableMap::Handle::~Handle): Call delete on
+ m_environment instead of fastFree() to make sure the destructors
+ for the Vector instance variables are run. This fixes the leaks
+ because calling fastFree() would only free the
+ CompactVariableEnvironment object, but not the heap-based
+ buffers allocated for the Vector instance variables.
+
+2019-01-09 Kocsen Chung <[email protected]>
+
Cherry-pick r239731. rdar://problem/47158715
LLInt put_by_id uses the wrong load instruction for loading flags from the metadata
Modified: branches/safari-607-branch/Source/_javascript_Core/parser/VariableEnvironment.cpp (239804 => 239805)
--- branches/safari-607-branch/Source/_javascript_Core/parser/VariableEnvironment.cpp 2019-01-10 01:38:24 UTC (rev 239804)
+++ branches/safari-607-branch/Source/_javascript_Core/parser/VariableEnvironment.cpp 2019-01-10 01:38:27 UTC (rev 239805)
@@ -179,7 +179,7 @@
if (!iter->value) {
ASSERT(m_environment == &iter->key.environment());
m_map->m_map.remove(iter);
- fastFree(m_environment);
+ delete m_environment;
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
