Diff
Modified: trunk/Source/WebCore/ChangeLog (239900 => 239901)
--- trunk/Source/WebCore/ChangeLog 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebCore/ChangeLog 2019-01-12 20:36:08 UTC (rev 239901)
@@ -1,3 +1,17 @@
+2019-01-12 Dan Bernstein <[email protected]>
+
+ [Cocoa] Avoid importing directly from subumbrella frameworks
+ https://bugs.webkit.org/show_bug.cgi?id=186016
+ <rdar://problem/40591038>
+
+ Reviewed by Sam Weinig.
+
+ * Configurations/WebCore.xcconfig: Removed -iframework options from OTHER_CFLAGS and
+ OTHER_CPLUSPLUSFLAGS.
+ * editing/mac/DictionaryLookupLegacy.mm: Import Quartz.h instead of a PDFKit header.
+ * platform/mac/PlatformEventFactoryMac.mm: Import Carbon.h instead of HIToolbox headers.
+ * platform/text/mac/TextEncodingRegistryMac.mm: Import Carbon.h instead of CarbonCore.h.
+
2019-01-12 Zalan Bujtas <[email protected]>
[LFC] Move formatting context creation from FormattingState to LayoutState
Modified: trunk/Source/WebCore/Configurations/WebCore.xcconfig (239900 => 239901)
--- trunk/Source/WebCore/Configurations/WebCore.xcconfig 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebCore/Configurations/WebCore.xcconfig 2019-01-12 20:36:08 UTC (rev 239901)
@@ -38,9 +38,6 @@
SYSTEM_FRAMEWORK_SEARCH_PATHS = $(inherited) $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks
LIBRARY_SEARCH_PATHS = $(inherited) "$(WK_LIBWEBRTC_LIBRARY_DIR)";
-ADDITIONAL_CFLAGS = -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Carbon.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/ApplicationServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/CoreServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Quartz.framework/Frameworks;
-OTHER_CFLAGS = $(inherited) $(ADDITIONAL_CFLAGS);
-OTHER_CPLUSPLUSFLAGS = $(inherited) $(ADDITIONAL_CFLAGS);
WEBKITADDITIONS_HEADER_SEARCH_PATHS = $(BUILT_PRODUCTS_DIR)/usr/local/include/WebKitAdditions $(SDKROOT)/usr/local/include/WebKitAdditions;
LIBWEBRTC_HEADER_SEARCH_PATHS = $(BUILT_PRODUCTS_DIR)/usr/local/include/webrtc $(SDKROOT)/usr/local/include/webrtc $(BUILT_PRODUCTS_DIR)/usr/local/include/webrtc/sdk/objc/Framework/Headers $(SDKROOT)/usr/local/include/webrtc/sdk/objc/Framework/Headers;
Modified: trunk/Source/WebCore/PAL/ChangeLog (239900 => 239901)
--- trunk/Source/WebCore/PAL/ChangeLog 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebCore/PAL/ChangeLog 2019-01-12 20:36:08 UTC (rev 239901)
@@ -1,3 +1,18 @@
+2019-01-12 Dan Bernstein <[email protected]>
+
+ [Cocoa] Avoid importing directly from subumbrella frameworks
+ https://bugs.webkit.org/show_bug.cgi?id=186016
+ <rdar://problem/40591038>
+
+ Reviewed by Sam Weinig.
+
+ * Configurations/PAL.xcconfig: Removed -iframework options from OTHER_CFLAGS and
+ OTHER_CPLUSPLUSFLAGS.
+ * pal/spi/cg/CoreGraphicsSPI.h: Import ApplicationServices.h instead of ColorSync.h
+ when using SDKs earlier than 10.13.
+ * pal/spi/mac/HIToolboxSPI.h: Import CarbonPriv.h instead of HIToolboxPriv.h.
+ * pal/spi/mac/QuickLookMacSPI.h: Import Quartz.h instead of a QuickLookUI header.
+
2019-01-11 John Wilander <[email protected]>
Compile out Web API Statistics Collection
Modified: trunk/Source/WebCore/PAL/Configurations/PAL.xcconfig (239900 => 239901)
--- trunk/Source/WebCore/PAL/Configurations/PAL.xcconfig 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebCore/PAL/Configurations/PAL.xcconfig 2019-01-12 20:36:08 UTC (rev 239901)
@@ -33,7 +33,7 @@
SYSTEM_FRAMEWORK_SEARCH_PATHS = $(inherited) $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks;
-OTHER_CFLAGS = $(inherited) -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Carbon.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/ApplicationServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/CoreServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Quartz.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
+OTHER_CFLAGS = $(inherited) -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
OTHER_CPLUSPLUSFLAGS = $(OTHER_CFLAGS);
HEADER_SEARCH_PATHS = "$(BUILT_PRODUCTS_DIR)/usr/local/include" $(inherited);
Modified: trunk/Source/WebCore/PAL/pal/spi/mac/HIToolboxSPI.h (239900 => 239901)
--- trunk/Source/WebCore/PAL/pal/spi/mac/HIToolboxSPI.h 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebCore/PAL/pal/spi/mac/HIToolboxSPI.h 2019-01-12 20:36:08 UTC (rev 239901)
@@ -27,7 +27,7 @@
#if USE(APPLE_INTERNAL_SDK)
-#include <HIToolbox/HIToolboxPriv.h>
+#include <Carbon/CarbonPriv.h>
#else
Modified: trunk/Source/WebCore/PAL/pal/spi/mac/QuickLookMacSPI.h (239900 => 239901)
--- trunk/Source/WebCore/PAL/pal/spi/mac/QuickLookMacSPI.h 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebCore/PAL/pal/spi/mac/QuickLookMacSPI.h 2019-01-12 20:36:08 UTC (rev 239901)
@@ -23,7 +23,7 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-#import <QuickLookUI/QLPreviewItem.h>
+#import <Quartz/Quartz.h>
@protocol QLPreviewMenuItemDelegate <NSObject>
@optional
Modified: trunk/Source/WebCore/editing/mac/DictionaryLookupLegacy.mm (239900 => 239901)
--- trunk/Source/WebCore/editing/mac/DictionaryLookupLegacy.mm 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebCore/editing/mac/DictionaryLookupLegacy.mm 2019-01-12 20:36:08 UTC (rev 239901)
@@ -42,7 +42,7 @@
#import "VisiblePosition.h"
#import "VisibleSelection.h"
#import "VisibleUnits.h"
-#import <PDFKit/PDFKit.h>
+#import <Quartz/Quartz.h>
#import <pal/spi/mac/LookupSPI.h>
#import <pal/spi/mac/NSImmediateActionGestureRecognizerSPI.h>
#import <wtf/BlockObjCExceptions.h>
Modified: trunk/Source/WebCore/platform/mac/PlatformEventFactoryMac.mm (239900 => 239901)
--- trunk/Source/WebCore/platform/mac/PlatformEventFactoryMac.mm 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebCore/platform/mac/PlatformEventFactoryMac.mm 2019-01-12 20:36:08 UTC (rev 239901)
@@ -33,8 +33,7 @@
#import "PlatformScreen.h"
#import "Scrollbar.h"
#import "WindowsKeyboardCodes.h"
-#import <HIToolbox/CarbonEvents.h>
-#import <HIToolbox/Events.h>
+#import <Carbon/Carbon.h>
#import <mach/mach_time.h>
#import <pal/spi/mac/HIToolboxSPI.h>
#import <pal/spi/mac/NSEventSPI.h>
Modified: trunk/Source/WebCore/platform/text/mac/TextEncodingRegistryMac.mm (239900 => 239901)
--- trunk/Source/WebCore/platform/text/mac/TextEncodingRegistryMac.mm 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebCore/platform/text/mac/TextEncodingRegistryMac.mm 2019-01-12 20:36:08 UTC (rev 239901)
@@ -28,7 +28,7 @@
#if PLATFORM(MAC)
-#import <CarbonCore/CarbonCore.h>
+#import <Carbon/Carbon.h>
#import <wtf/spi/cf/CFStringSPI.h>
namespace WebCore {
Modified: trunk/Source/WebKit/ChangeLog (239900 => 239901)
--- trunk/Source/WebKit/ChangeLog 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKit/ChangeLog 2019-01-12 20:36:08 UTC (rev 239901)
@@ -1,3 +1,29 @@
+2019-01-12 Dan Bernstein <[email protected]>
+
+ [Cocoa] Avoid importing directly from subumbrella frameworks
+ https://bugs.webkit.org/show_bug.cgi?id=186016
+ <rdar://problem/40591038>
+
+ Reviewed by Sam Weinig.
+
+ * Configurations/BaseTarget.xcconfig: Removed -iframework options from OTHER_CFLAGS and
+ OTHER_CPLUSPLUSFLAGS.
+ * UIProcess/Automation/mac/WebAutomationSessionMac.mm: Import Carbon.h instead of an
+ HIToolbox header.
+ * UIProcess/Cocoa/WebViewImpl.mm: Ditto.
+ * UIProcess/mac/WKPrintingView.mm: Import Quartz.h instead of a PDFKit header.
+ * UIProcess/mac/WKTextInputWindowController.mm: Import Carbon.h instead of an HIToolbox
+ header.
+ * WebProcess/Plugins/PDF/PDFAnnotationTextWidgetDetails.h: Import Quartz.h instead of a
+ PDFKit header.
+ * WebProcess/Plugins/PDF/PDFLayerControllerSPI.h: Ditto.
+ * WebProcess/Plugins/PDF/PDFPlugin.mm: Ditto.
+ * WebProcess/Plugins/PDF/PDFPluginAnnotation.mm: Ditto.
+ * WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm: Ditto.
+ * WebProcess/Plugins/PDF/PDFPluginPasswordField.mm: Ditto.
+ * WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm: Ditto.
+ * WebProcess/WebPage/mac/WebPageMac.mm: Ditto.
+
2019-01-11 Ryosuke Niwa <[email protected]>
Enable visual viewport API by default
Modified: trunk/Source/WebKit/Configurations/BaseTarget.xcconfig (239900 => 239901)
--- trunk/Source/WebKit/Configurations/BaseTarget.xcconfig 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKit/Configurations/BaseTarget.xcconfig 2019-01-12 20:36:08 UTC (rev 239901)
@@ -40,7 +40,7 @@
HEADER_SEARCH_PATHS = $(BUILT_PRODUCTS_DIR)/usr/local/include "$(WEBCORE_PRIVATE_HEADERS_DIR)/ForwardingHeaders" $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit2 $(WEBKITADDITIONS_HEADER_SEARCH_PATHS) $(LIBWEBRTC_HEADER_SEARCH_PATHS) $(SRCROOT) $(HEADER_SEARCH_PATHS);
-OTHER_CFLAGS = $(inherited) -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/ApplicationServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Carbon.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Quartz.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/CoreServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
+OTHER_CFLAGS = $(inherited) -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
OTHER_CPLUSPLUSFLAGS = $(OTHER_CFLAGS) -isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders;
NORMAL_WEBCORE_FRAMEWORKS_DIR = $(NORMAL_WEBCORE_FRAMEWORKS_DIR_COCOA_TOUCH_$(WK_IS_COCOA_TOUCH));
Modified: trunk/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm (239900 => 239901)
--- trunk/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm 2019-01-12 20:36:08 UTC (rev 239901)
@@ -33,7 +33,7 @@
#import "WebInspectorProxy.h"
#import "WebPageProxy.h"
#import "_WKAutomationSession.h"
-#import <HIToolbox/Events.h>
+#import <Carbon/Carbon.h>
#import <WebCore/IntPoint.h>
#import <WebCore/IntSize.h>
#import <WebCore/PlatformMouseEvent.h>
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm (239900 => 239901)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm 2019-01-12 20:36:08 UTC (rev 239901)
@@ -76,7 +76,7 @@
#import "WebProcessProxy.h"
#import "_WKRemoteObjectRegistryInternal.h"
#import "_WKThumbnailViewInternal.h"
-#import <HIToolbox/CarbonEventsCore.h>
+#import <Carbon/Carbon.h>
#import <WebCore/AXObjectCache.h>
#import <WebCore/ActivityState.h>
#import <WebCore/ColorMac.h>
Modified: trunk/Source/WebKit/UIProcess/mac/WKPrintingView.mm (239900 => 239901)
--- trunk/Source/WebKit/UIProcess/mac/WKPrintingView.mm 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKit/UIProcess/mac/WKPrintingView.mm 2019-01-12 20:36:08 UTC (rev 239901)
@@ -34,7 +34,7 @@
#import "PrintInfo.h"
#import "ShareableBitmap.h"
#import "WebPageProxy.h"
-#import <PDFKit/PDFKit.h>
+#import <Quartz/Quartz.h>
#import <WebCore/GraphicsContext.h>
#import <WebCore/LocalDefaultSystemAppearance.h>
#import <WebCore/WebCoreObjCExtras.h>
Modified: trunk/Source/WebKit/UIProcess/mac/WKTextInputWindowController.mm (239900 => 239901)
--- trunk/Source/WebKit/UIProcess/mac/WKTextInputWindowController.mm 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKit/UIProcess/mac/WKTextInputWindowController.mm 2019-01-12 20:36:08 UTC (rev 239901)
@@ -28,7 +28,7 @@
#if USE(APPKIT)
-#import <HIToolbox/CarbonEventsCore.h>
+#import <Carbon/Carbon.h>
#import <pal/spi/mac/HIToolboxSPI.h>
#import <pal/system/mac/WebPanel.h>
Modified: trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFAnnotationTextWidgetDetails.h (239900 => 239901)
--- trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFAnnotationTextWidgetDetails.h 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFAnnotationTextWidgetDetails.h 2019-01-12 20:36:08 UTC (rev 239901)
@@ -23,7 +23,7 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-#import <PDFKit/PDFKit.h>
+#import <Quartz/Quartz.h>
@interface PDFAnnotationTextWidget (Details)
- (BOOL)isMultiline;
Modified: trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFLayerControllerSPI.h (239900 => 239901)
--- trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFLayerControllerSPI.h 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFLayerControllerSPI.h 2019-01-12 20:36:08 UTC (rev 239901)
@@ -28,7 +28,7 @@
#if ENABLE(PDFKIT_PLUGIN)
-#import <PDFKit/PDFKit.h>
+#import <Quartz/Quartz.h>
@class CPReadingModel;
@class PDFViewLayout;
Modified: trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm (239900 => 239901)
--- trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm 2019-01-12 20:36:08 UTC (rev 239901)
@@ -48,7 +48,7 @@
#import "WebProcess.h"
#import <_javascript_Core/JSContextRef.h>
#import <_javascript_Core/JSObjectRef.h>
-#import <PDFKit/PDFKit.h>
+#import <Quartz/Quartz.h>
#import <QuartzCore/QuartzCore.h>
#import <WebCore/AXObjectCache.h>
#import <WebCore/ArchiveResource.h>
Modified: trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm (239900 => 239901)
--- trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm 2019-01-12 20:36:08 UTC (rev 239901)
@@ -33,7 +33,7 @@
#import "PDFPlugin.h"
#import "PDFPluginChoiceAnnotation.h"
#import "PDFPluginTextAnnotation.h"
-#import <PDFKit/PDFKit.h>
+#import <Quartz/Quartz.h>
#import <WebCore/CSSPrimitiveValue.h>
#import <WebCore/CSSPropertyNames.h>
#import <WebCore/ColorMac.h>
Modified: trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm (239900 => 239901)
--- trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm 2019-01-12 20:36:08 UTC (rev 239901)
@@ -30,7 +30,7 @@
#import "PDFKitImports.h"
#import "PDFLayerControllerSPI.h"
-#import <PDFKit/PDFKit.h>
+#import <Quartz/Quartz.h>
#import <WebCore/CSSPrimitiveValue.h>
#import <WebCore/CSSPropertyNames.h>
#import <WebCore/ColorMac.h>
Modified: trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.mm (239900 => 239901)
--- trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.mm 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.mm 2019-01-12 20:36:08 UTC (rev 239901)
@@ -31,7 +31,7 @@
#import "PDFKitImports.h"
#import "PDFLayerControllerSPI.h"
#import "PDFPlugin.h"
-#import <PDFKit/PDFKit.h>
+#import <Quartz/Quartz.h>
#import <WebCore/Event.h>
#import <WebCore/EventNames.h>
#import <WebCore/HTMLElement.h>
Modified: trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm (239900 => 239901)
--- trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm 2019-01-12 20:36:08 UTC (rev 239901)
@@ -32,7 +32,7 @@
#import "PDFKitImports.h"
#import "PDFLayerControllerSPI.h"
#import "PDFPlugin.h"
-#import <PDFKit/PDFKit.h>
+#import <Quartz/Quartz.h>
#import <WebCore/CSSPrimitiveValue.h>
#import <WebCore/CSSPropertyNames.h>
#import <WebCore/ColorMac.h>
Modified: trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm (239900 => 239901)
--- trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm 2019-01-12 20:36:08 UTC (rev 239901)
@@ -53,7 +53,7 @@
#import "WebPasteboardOverrides.h"
#import "WebPreferencesStore.h"
#import "WebProcess.h"
-#import <PDFKit/PDFKit.h>
+#import <Quartz/Quartz.h>
#import <QuartzCore/QuartzCore.h>
#import <WebCore/AXObjectCache.h>
#import <WebCore/BackForwardController.h>
Modified: trunk/Source/WebKitLegacy/mac/Carbon/CarbonWindowAdapter.h (239900 => 239901)
--- trunk/Source/WebKitLegacy/mac/Carbon/CarbonWindowAdapter.h 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKitLegacy/mac/Carbon/CarbonWindowAdapter.h 2019-01-12 20:36:08 UTC (rev 239901)
@@ -28,8 +28,7 @@
#import <Foundation/Foundation.h>
#import <AppKit/AppKit.h>
-#import <HIToolbox/CarbonEvents.h>
-#import <HIToolbox/MacWindows.h>
+#import <Carbon/Carbon.h>
@interface CarbonWindowAdapter : NSWindow
{
Modified: trunk/Source/WebKitLegacy/mac/Carbon/CarbonWindowAdapter.mm (239900 => 239901)
--- trunk/Source/WebKitLegacy/mac/Carbon/CarbonWindowAdapter.mm 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKitLegacy/mac/Carbon/CarbonWindowAdapter.mm 2019-01-12 20:36:08 UTC (rev 239901)
@@ -65,9 +65,7 @@
#import <AppKit/AppKit.h>
//#import <CoreGraphics/CGSWindow.h>
-#import <HIToolbox/CarbonEvents.h>
-#import <HIToolbox/Controls.h>
-#import <HIToolbox/HIView.h>
+#import <Carbon/Carbon.h>
#import <assert.h>
#import <_javascript_Core/InitializeThreading.h>
Modified: trunk/Source/WebKitLegacy/mac/Carbon/CarbonWindowFrame.m (239900 => 239901)
--- trunk/Source/WebKitLegacy/mac/Carbon/CarbonWindowFrame.m 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKitLegacy/mac/Carbon/CarbonWindowFrame.m 2019-01-12 20:36:08 UTC (rev 239901)
@@ -31,9 +31,9 @@
#import "CarbonWindowFrame.h"
#import "CarbonWindowAdapter.h"
#import "CarbonWindowContentView.h"
+#import <Carbon/Carbon.h>
#import <Foundation/NSGeometry.h>
#import <Foundation/NSString.h>
-#import <HIToolbox/MacWindows.h>
#import "WebTypesInternal.h"
Modified: trunk/Source/WebKitLegacy/mac/Carbon/HIViewAdapter.h (239900 => 239901)
--- trunk/Source/WebKitLegacy/mac/Carbon/HIViewAdapter.h 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKitLegacy/mac/Carbon/HIViewAdapter.h 2019-01-12 20:36:08 UTC (rev 239901)
@@ -27,7 +27,7 @@
*/
#import <WebKitLegacy/WebKit.h>
-#include <HIToolbox/HIView.h>
+#include <Carbon/Carbon.h>
@interface HIViewAdapter : NSObject
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (239900 => 239901)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2019-01-12 20:36:08 UTC (rev 239901)
@@ -1,3 +1,21 @@
+2019-01-12 Dan Bernstein <[email protected]>
+
+ [Cocoa] Avoid importing directly from subumbrella frameworks
+ https://bugs.webkit.org/show_bug.cgi?id=186016
+ <rdar://problem/40591038>
+
+ Reviewed by Sam Weinig.
+
+ * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
+ * Carbon/CarbonWindowAdapter.mm: Ditto.
+ * Carbon/CarbonWindowFrame.m: Ditto.
+ * Carbon/HIViewAdapter.h: Ditto.
+ * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
+ OTHER_CFLAGS_COCOA_TOUCH_NO.
+ * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
+ * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
+ * WebView/WebPDFView.h: Ditto.
+
2019-01-11 Ryosuke Niwa <[email protected]>
Enable visual viewport API by default
Modified: trunk/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig (239900 => 239901)
--- trunk/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig 2019-01-12 20:36:08 UTC (rev 239901)
@@ -48,7 +48,7 @@
OTHER_CFLAGS = $(OTHER_CFLAGS_COCOA_TOUCH_$(WK_IS_COCOA_TOUCH));
OTHER_CFLAGS_COCOA_TOUCH_YES = $(inherited) -isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders;
-OTHER_CFLAGS_COCOA_TOUCH_NO = $(inherited) -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/WebKit.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/ApplicationServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Carbon.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Quartz.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/CoreServices.framework/Frameworks;
+OTHER_CFLAGS_COCOA_TOUCH_NO = $(inherited) -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/WebKit.framework/Frameworks;
OTHER_CPLUSPLUSFLAGS = $(OTHER_CFLAGS);
GCC_PREFIX_HEADER = mac/WebKitPrefix.h;
Modified: trunk/Source/WebKitLegacy/mac/Plugins/WebNetscapePluginEventHandlerCarbon.mm (239900 => 239901)
--- trunk/Source/WebKitLegacy/mac/Plugins/WebNetscapePluginEventHandlerCarbon.mm 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKitLegacy/mac/Plugins/WebNetscapePluginEventHandlerCarbon.mm 2019-01-12 20:36:08 UTC (rev 239901)
@@ -29,7 +29,7 @@
#import "WebNetscapePluginView.h"
#import "WebKitLogging.h"
-#import <HIToolbox/CarbonEvents.h>
+#import <Carbon/Carbon.h>
#import <pal/spi/mac/HIToolboxSPI.h>
#import <pal/spi/mac/NSEventSPI.h>
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPDFDocumentExtras.mm (239900 => 239901)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPDFDocumentExtras.mm 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPDFDocumentExtras.mm 2019-01-12 20:36:08 UTC (rev 239901)
@@ -30,7 +30,7 @@
#import <wtf/RetainPtr.h>
#if !PLATFORM(IOS_FAMILY)
-#import <PDFKit/PDFDocument.h>
+#import <Quartz/Quartz.h>
#endif
static void appendValuesInPDFNameSubtreeToVector(CGPDFDictionaryRef subtree, Vector<CGPDFObjectRef>& values)
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPDFView.h (239900 => 239901)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPDFView.h 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPDFView.h 2019-01-12 20:36:08 UTC (rev 239901)
@@ -28,7 +28,7 @@
#if !PLATFORM(IOS_FAMILY)
-#import <PDFKit/PDFKit.h>
+#import <Quartz/Quartz.h>
#import <WebKitLegacy/WebDocumentInternal.h>
@class WebDataSource;
Modified: trunk/Tools/ChangeLog (239900 => 239901)
--- trunk/Tools/ChangeLog 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Tools/ChangeLog 2019-01-12 20:36:08 UTC (rev 239901)
@@ -1,3 +1,24 @@
+2019-01-12 Dan Bernstein <[email protected]>
+
+ [Cocoa] Avoid importing directly from subumbrella frameworks
+ https://bugs.webkit.org/show_bug.cgi?id=186016
+ <rdar://problem/40591038>
+
+ Reviewed by Sam Weinig.
+
+ * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
+ LaunchServices header.
+ * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
+ OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
+ * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
+ when using SDKs earlier than 10.13.
+ * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
+ and OTHER_CPLUSPLUSFLAGS.
+ * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
+ OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
+ * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
+ LaunchServices header.
+
2019-01-11 John Wilander <[email protected]>
Compile out Web API Statistics Collection
Modified: trunk/Tools/DumpRenderTree/cg/PixelDumpSupportCG.cpp (239900 => 239901)
--- trunk/Tools/DumpRenderTree/cg/PixelDumpSupportCG.cpp 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Tools/DumpRenderTree/cg/PixelDumpSupportCG.cpp 2019-01-12 20:36:08 UTC (rev 239901)
@@ -47,7 +47,7 @@
#define COMMON_DIGEST_FOR_OPENSSL
#include <CommonCrypto/CommonDigest.h>
#elif PLATFORM(MAC)
-#include <LaunchServices/UTCoreTypes.h>
+#include <CoreServices/CoreServices.h>
#define COMMON_DIGEST_FOR_OPENSSL
#include <CommonCrypto/CommonDigest.h>
#endif
Modified: trunk/Tools/DumpRenderTree/mac/Configurations/BaseTarget.xcconfig (239900 => 239901)
--- trunk/Tools/DumpRenderTree/mac/Configurations/BaseTarget.xcconfig 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/BaseTarget.xcconfig 2019-01-12 20:36:08 UTC (rev 239901)
@@ -21,7 +21,7 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-OTHER_CFLAGS = $(inherited) -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Quartz.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/ApplicationServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/CoreServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/WebKit.framework/Frameworks;
+OTHER_CFLAGS = $(inherited) -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/WebKit.framework/Frameworks;
OTHER_CPLUSPLUSFLAGS = $(OTHER_CFLAGS);
GCC_ENABLE_OBJC_EXCEPTIONS = YES;
GCC_PREFIX_HEADER = DumpRenderTreePrefix.h;
Modified: trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m (239900 => 239901)
--- trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m 2019-01-12 20:36:08 UTC (rev 239901)
@@ -43,7 +43,7 @@
#if USE(APPLE_INTERNAL_SDK)
-#include <ColorSync/ColorSyncPriv.h>
+#import <ColorSync/ColorSyncPriv.h>
#else
Modified: trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig (239900 => 239901)
--- trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig 2019-01-12 20:36:08 UTC (rev 239901)
@@ -101,7 +101,7 @@
EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = *Mac.h *Mac.cpp *Mac.mm */mac/*;
OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS) --system-header-prefix=WebKit/;
-OTHER_CFLAGS[sdk=macosx*] = $(inherited) -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/ApplicationServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Carbon.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Quartz.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/CoreServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
+OTHER_CFLAGS[sdk=macosx*] = $(inherited) -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS);
OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);
Modified: trunk/Tools/WebKitTestRunner/Configurations/BaseTarget.xcconfig (239900 => 239901)
--- trunk/Tools/WebKitTestRunner/Configurations/BaseTarget.xcconfig 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Tools/WebKitTestRunner/Configurations/BaseTarget.xcconfig 2019-01-12 20:36:08 UTC (rev 239901)
@@ -21,6 +21,4 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-OTHER_CFLAGS = $(inherited) -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Quartz.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/ApplicationServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/CoreServices.framework/Frameworks;
-OTHER_CPLUSPLUSFLAGS = $(OTHER_CFLAGS);
INSTALL_PATH = $(SYSTEM_LIBRARY_DIR)/Frameworks/WebKit.framework/Versions/A/Resources;
Modified: trunk/Tools/WebKitTestRunner/cg/TestInvocationCG.cpp (239900 => 239901)
--- trunk/Tools/WebKitTestRunner/cg/TestInvocationCG.cpp 2019-01-12 16:56:55 UTC (rev 239900)
+++ trunk/Tools/WebKitTestRunner/cg/TestInvocationCG.cpp 2019-01-12 20:36:08 UTC (rev 239901)
@@ -35,7 +35,7 @@
#include <wtf/RetainPtr.h>
#if PLATFORM(MAC) && !PLATFORM(IOS_FAMILY)
-#include <LaunchServices/UTCoreTypes.h>
+#include <CoreServices/CoreServices.h>
#endif
#if PLATFORM(IOS_FAMILY)
