Title: [239925] trunk/Source/WebCore
- Revision
- 239925
- Author
- [email protected]
- Date
- 2019-01-14 07:22:43 -0800 (Mon, 14 Jan 2019)
Log Message
[GStreamer][WebRTC] Override DeviceType() in RealtimeMediaSource implementations
https://bugs.webkit.org/show_bug.cgi?id=193397
This was necessary but wasn't done.
Patch by Thibault Saunier <[email protected]> on 2019-01-14
Reviewed by Philippe Normand.
No test required as this fixes a regression in all WebRTC tests when built in debug mode.
* platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h:
* platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (239924 => 239925)
--- trunk/Source/WebCore/ChangeLog 2019-01-14 15:09:56 UTC (rev 239924)
+++ trunk/Source/WebCore/ChangeLog 2019-01-14 15:22:43 UTC (rev 239925)
@@ -1,3 +1,17 @@
+2019-01-14 Thibault Saunier <[email protected]>
+
+ [GStreamer][WebRTC] Override DeviceType() in RealtimeMediaSource implementations
+ https://bugs.webkit.org/show_bug.cgi?id=193397
+
+ This was necessary but wasn't done.
+
+ Reviewed by Philippe Normand.
+
+ No test required as this fixes a regression in all WebRTC tests when built in debug mode.
+
+ * platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h:
+ * platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h:
+
2019-01-14 Zan Dobersek <[email protected]>
Unreviewed WPE debug build fix after r239921.
Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h (239924 => 239925)
--- trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h 2019-01-14 15:09:56 UTC (rev 239924)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h 2019-01-14 15:22:43 UTC (rev 239925)
@@ -22,6 +22,7 @@
#pragma once
#if ENABLE(MEDIA_STREAM) && USE(LIBWEBRTC) && USE(GSTREAMER)
+#include "CaptureDevice.h"
#include "GStreamerAudioCapturer.h"
#include "GStreamerCaptureDevice.h"
#include "RealtimeMediaSource.h"
@@ -45,6 +46,7 @@
virtual ~GStreamerAudioCaptureSource();
void startProducingData() override;
void stopProducingData() override;
+ CaptureDevice::DeviceType deviceType() const override { return CaptureDevice::DeviceType::Microphone; }
mutable Optional<RealtimeMediaSourceCapabilities> m_capabilities;
mutable Optional<RealtimeMediaSourceSettings> m_currentSettings;
Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h (239924 => 239925)
--- trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h 2019-01-14 15:09:56 UTC (rev 239924)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h 2019-01-14 15:22:43 UTC (rev 239925)
@@ -22,6 +22,7 @@
#pragma once
#if ENABLE(MEDIA_STREAM) && USE(LIBWEBRTC) && USE(GSTREAMER)
+#include "CaptureDevice.h"
#include "GStreamerVideoCapturer.h"
#include "RealtimeVideoSource.h"
@@ -52,6 +53,7 @@
mutable Optional<RealtimeMediaSourceCapabilities> m_capabilities;
mutable Optional<RealtimeMediaSourceSettings> m_currentSettings;
+ CaptureDevice::DeviceType deviceType() const override { return CaptureDevice::DeviceType::Camera; }
private:
static GstFlowReturn newSampleCallback(GstElement*, GStreamerVideoCaptureSource*);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
