Diff
Modified: trunk/Source/WebCore/ChangeLog (240019 => 240020)
--- trunk/Source/WebCore/ChangeLog 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/ChangeLog 2019-01-16 01:14:21 UTC (rev 240020)
@@ -1,5 +1,40 @@
2019-01-15 Myles C. Maxfield <[email protected]>
+ [WHLSL] Add ending namespace comments to make namespace boundaries more clear
+ https://bugs.webkit.org/show_bug.cgi?id=193471
+
+ Reviewed by Saam Barati.
+
+ This patch only adds the comments to the files that are too long to fit on a single screen in my editor.
+
+ No new tests because there is no behavior change.
+
+ * Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp:
+ * Modules/webgpu/WHLSL/WHLSLChecker.cpp:
+ * Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.cpp:
+ * Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.h:
+ * Modules/webgpu/WHLSL/WHLSLInferTypes.cpp:
+ * Modules/webgpu/WHLSL/WHLSLIntrinsics.cpp:
+ * Modules/webgpu/WHLSL/WHLSLIntrinsics.h:
+ * Modules/webgpu/WHLSL/WHLSLLexer.cpp:
+ * Modules/webgpu/WHLSL/WHLSLLexer.h:
+ * Modules/webgpu/WHLSL/WHLSLLoopChecker.cpp:
+ * Modules/webgpu/WHLSL/WHLSLNameContext.cpp:
+ * Modules/webgpu/WHLSL/WHLSLNameResolver.cpp:
+ * Modules/webgpu/WHLSL/WHLSLNameResolver.h:
+ * Modules/webgpu/WHLSL/WHLSLParser.h:
+ * Modules/webgpu/WHLSL/WHLSLProgram.h:
+ * Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp:
+ * Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp:
+ * Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.cpp:
+ * Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp:
+ * Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp:
+ * Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.cpp:
+ * Modules/webgpu/WHLSL/WHLSLVisitor.cpp:
+ * Modules/webgpu/WHLSL/WHLSLVisitor.h:
+
+2019-01-15 Myles C. Maxfield <[email protected]>
+
[WHLSL] Implement the loop checker
https://bugs.webkit.org/show_bug.cgi?id=193434
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp 2019-01-16 01:14:21 UTC (rev 240020)
@@ -105,8 +105,8 @@
return true;
}
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp 2019-01-16 01:14:21 UTC (rev 240020)
@@ -1472,8 +1472,8 @@
return checker.assignTypes();
}
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.cpp (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.cpp 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.cpp 2019-01-16 01:14:21 UTC (rev 240020)
@@ -177,8 +177,8 @@
return {{ inputGatherer.takeEntryPointItems(), outputGatherer.takeEntryPointItems() }};
}
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.h (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.h 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.h 2019-01-16 01:14:21 UTC (rev 240020)
@@ -62,8 +62,8 @@
Optional<EntryPointItems> gatherEntryPointItems(const Intrinsics&, AST::FunctionDefinition&);
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLInferTypes.cpp (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLInferTypes.cpp 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLInferTypes.cpp 2019-01-16 01:14:21 UTC (rev 240020)
@@ -239,8 +239,8 @@
return true;
}
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLIntrinsics.cpp (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLIntrinsics.cpp 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLIntrinsics.cpp 2019-01-16 01:14:21 UTC (rev 240020)
@@ -417,8 +417,8 @@
addTexture(nativeTypeDeclaration);
}
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLIntrinsics.h (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLIntrinsics.h 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLIntrinsics.h 2019-01-16 01:14:21 UTC (rev 240020)
@@ -146,8 +146,8 @@
AST::NativeTypeDeclaration* m_textureDepthCube[WTF_ARRAY_LENGTH(m_depthTextureInnerTypes)];
};
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.cpp (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.cpp 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.cpp 2019-01-16 01:14:21 UTC (rev 240020)
@@ -819,8 +819,8 @@
return WTF::nullopt;
}
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.h (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.h 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.h 2019-01-16 01:14:21 UTC (rev 240020)
@@ -276,8 +276,8 @@
return WTF::nullopt;
}
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLoopChecker.cpp (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLoopChecker.cpp 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLoopChecker.cpp 2019-01-16 01:14:21 UTC (rev 240020)
@@ -142,8 +142,8 @@
return !loopChecker.error();
}
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameContext.cpp (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameContext.cpp 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameContext.cpp 2019-01-16 01:14:21 UTC (rev 240020)
@@ -156,8 +156,8 @@
|| m_variables.find(name) != m_variables.end();
}
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.cpp (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.cpp 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.cpp 2019-01-16 01:14:21 UTC (rev 240020)
@@ -279,8 +279,8 @@
return true;
}
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.h (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.h 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.h 2019-01-16 01:14:21 UTC (rev 240020)
@@ -71,8 +71,8 @@
bool resolveNamesInTypes(Program&, NameResolver&);
bool resolveNamesInFunctions(Program&, NameResolver&);
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.h (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.h 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.h 2019-01-16 01:14:21 UTC (rev 240020)
@@ -105,8 +105,8 @@
};
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLProgram.h (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLProgram.h 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLProgram.h 2019-01-16 01:14:21 UTC (rev 240020)
@@ -106,8 +106,8 @@
Vector<UniqueRef<AST::NativeTypeDeclaration>> m_nativeTypeDeclarations;
};
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp 2019-01-16 01:14:21 UTC (rev 240020)
@@ -101,8 +101,8 @@
return recursiveTypeChecker.error();
}
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp 2019-01-16 01:14:21 UTC (rev 240020)
@@ -107,8 +107,8 @@
return result;
}
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.cpp (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.cpp 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.cpp 2019-01-16 01:14:21 UTC (rev 240020)
@@ -74,8 +74,8 @@
}
}
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp 2019-01-16 01:14:21 UTC (rev 240020)
@@ -126,8 +126,8 @@
}
}
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp 2019-01-16 01:14:21 UTC (rev 240020)
@@ -77,8 +77,8 @@
}
}
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.cpp (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.cpp 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.cpp 2019-01-16 01:14:21 UTC (rev 240020)
@@ -83,8 +83,8 @@
}
}
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.cpp (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.cpp 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.cpp 2019-01-16 01:14:21 UTC (rev 240020)
@@ -619,8 +619,8 @@
{
}
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.h (240019 => 240020)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.h 2019-01-16 00:35:26 UTC (rev 240019)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.h 2019-01-16 01:14:21 UTC (rev 240020)
@@ -195,8 +195,8 @@
bool m_error { false }; // FIXME: Migrate this to be some sort of descriptive string.
};
-}
+} // namespace WHLSL
-}
+} // namespace WebCore
-#endif
+#endif // ENABLE(WEBGPU)
