Title: [240025] trunk/Tools
- Revision
- 240025
- Author
- [email protected]
- Date
- 2019-01-15 19:09:22 -0800 (Tue, 15 Jan 2019)
Log Message
Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
https://bugs.webkit.org/show_bug.cgi?id=193451
Reviewed by Geoffrey Garen.
* TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
(TEST):
* TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(runWebsiteDataStoreCustomPaths):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (240024 => 240025)
--- trunk/Tools/ChangeLog 2019-01-16 02:17:31 UTC (rev 240024)
+++ trunk/Tools/ChangeLog 2019-01-16 03:09:22 UTC (rev 240025)
@@ -1,3 +1,15 @@
+2019-01-15 Sihui Liu <[email protected]>
+
+ Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
+ https://bugs.webkit.org/show_bug.cgi?id=193451
+
+ Reviewed by Geoffrey Garen.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
+ (TEST):
+ * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
+ (runWebsiteDataStoreCustomPaths):
+
2019-01-15 Jonathan Bedard <[email protected]>
webkitpy: Support boolean simctl isAvailable
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm (240024 => 240025)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm 2019-01-16 02:17:31 UTC (rev 240024)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm 2019-01-16 03:09:22 UTC (rev 240025)
@@ -30,6 +30,7 @@
#import "PlatformUtilities.h"
#import "Utilities.h"
+#import <WebKit/WKPreferencesRef.h>
#import <WebKit/WKUIDelegatePrivate.h>
#import <WebKit/WKWebViewPrivate.h>
#import <WebKit/_WKInputDelegate.h>
@@ -126,6 +127,9 @@
TEST(WebKit, DuplicateCompletionHandlerCalls)
{
auto webView = adoptNS([[WKWebView alloc] initWithFrame:CGRectMake(0, 0, 800, 600)]);
+ auto preferences = (__bridge WKPreferencesRef)[[webView configuration] preferences];
+ WKPreferencesSetWebSQLDisabled(preferences, false);
+
auto delegate = adoptNS([[DuplicateCompletionHandlerCallsDelegate alloc] init]);
[webView setNavigationDelegate:delegate.get()];
[webView setUIDelegate:delegate.get()];
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm (240024 => 240025)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm 2019-01-16 02:17:31 UTC (rev 240024)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm 2019-01-16 03:09:22 UTC (rev 240025)
@@ -28,6 +28,7 @@
#import "PlatformUtilities.h"
#import "Test.h"
#import "TestNavigationDelegate.h"
+#import <WebKit/WKPreferencesRef.h>
#import <WebKit/WKProcessPoolPrivate.h>
#import <WebKit/WKUserContentControllerPrivate.h>
#import <WebKit/WKWebViewConfigurationPrivate.h>
@@ -129,6 +130,9 @@
RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
[webView setNavigationDelegate:handler.get()];
+ auto preferences = (__bridge WKPreferencesRef)[[webView configuration] preferences];
+ WKPreferencesSetWebSQLDisabled(preferences, false);
+
NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"WebsiteDataStoreCustomPaths" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
[webView loadRequest:request];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
