Title: [240094] trunk/Source/WebKit
- Revision
- 240094
- Author
- [email protected]
- Date
- 2019-01-16 16:20:11 -0800 (Wed, 16 Jan 2019)
Log Message
sendBeacon to previously-unvisited https domain always fails
https://bugs.webkit.org/show_bug.cgi?id=193508
Reviewed by Geoffrey Garen.
* NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::didReceiveChallenge):
If a ping load is doing a TLS handshake, continue if the server has good certificates.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (240093 => 240094)
--- trunk/Source/WebKit/ChangeLog 2019-01-17 00:17:58 UTC (rev 240093)
+++ trunk/Source/WebKit/ChangeLog 2019-01-17 00:20:11 UTC (rev 240094)
@@ -1,3 +1,14 @@
+2019-01-16 Alex Christensen <[email protected]>
+
+ sendBeacon to previously-unvisited https domain always fails
+ https://bugs.webkit.org/show_bug.cgi?id=193508
+
+ Reviewed by Geoffrey Garen.
+
+ * NetworkProcess/PingLoad.cpp:
+ (WebKit::PingLoad::didReceiveChallenge):
+ If a ping load is doing a TLS handshake, continue if the server has good certificates.
+
2019-01-16 Youenn Fablet <[email protected]>
ASSERTION FAILED: m_networkLoadInformationByID.contains(identifier) in WebKit::NetworkConnectionToWebProcess::addNetworkLoadInformationMetrics
Modified: trunk/Source/WebKit/NetworkProcess/PingLoad.cpp (240093 => 240094)
--- trunk/Source/WebKit/NetworkProcess/PingLoad.cpp 2019-01-17 00:17:58 UTC (rev 240093)
+++ trunk/Source/WebKit/NetworkProcess/PingLoad.cpp 2019-01-17 00:20:11 UTC (rev 240094)
@@ -117,9 +117,13 @@
});
}
-void PingLoad::didReceiveChallenge(AuthenticationChallenge&&, ChallengeCompletionHandler&& completionHandler)
+void PingLoad::didReceiveChallenge(AuthenticationChallenge&& challenge, ChallengeCompletionHandler&& completionHandler)
{
RELEASE_LOG_IF_ALLOWED("didReceiveChallenge");
+ if (challenge.protectionSpace().authenticationScheme() == ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested) {
+ completionHandler(AuthenticationChallengeDisposition::PerformDefaultHandling, { });
+ return;
+ }
auto weakThis = makeWeakPtr(*this);
completionHandler(AuthenticationChallengeDisposition::Cancel, { });
if (!weakThis)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
