Title: [240143] trunk/Source/WebCore
- Revision
- 240143
- Author
- [email protected]
- Date
- 2019-01-18 06:12:53 -0800 (Fri, 18 Jan 2019)
Log Message
[WebAudio] Release the AudioDestination when uninitializing DefaultAudioDestinationNode
https://bugs.webkit.org/show_bug.cgi?id=192590
Patch by Yacine Bandou <[email protected]> on 2019-01-18
Reviewed by Philippe Normand.
When we uninitialize DefaultAudioDestinationNode, the AudioDestination is stopped but not destroyed.
On some platforms the resources are allocated and released with the AudioDestination, thus when we uninitialize
DefaultAudioDestinationNode we don't release resources because the AudioDestination is not destroyed.
* Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::uninitialize):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (240142 => 240143)
--- trunk/Source/WebCore/ChangeLog 2019-01-18 13:46:29 UTC (rev 240142)
+++ trunk/Source/WebCore/ChangeLog 2019-01-18 14:12:53 UTC (rev 240143)
@@ -1,5 +1,20 @@
2019-01-18 Yacine Bandou <[email protected]>
+ [WebAudio] Release the AudioDestination when uninitializing DefaultAudioDestinationNode
+ https://bugs.webkit.org/show_bug.cgi?id=192590
+
+ Reviewed by Philippe Normand.
+
+ When we uninitialize DefaultAudioDestinationNode, the AudioDestination is stopped but not destroyed.
+
+ On some platforms the resources are allocated and released with the AudioDestination, thus when we uninitialize
+ DefaultAudioDestinationNode we don't release resources because the AudioDestination is not destroyed.
+
+ * Modules/webaudio/DefaultAudioDestinationNode.cpp:
+ (WebCore::DefaultAudioDestinationNode::uninitialize):
+
+2019-01-18 Yacine Bandou <[email protected]>
+
[WebAudio] Call AudioContext::uninitialize() immediately when the AudioContext is stopped
https://bugs.webkit.org/show_bug.cgi?id=192586
Modified: trunk/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp (240142 => 240143)
--- trunk/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp 2019-01-18 13:46:29 UTC (rev 240142)
+++ trunk/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp 2019-01-18 14:12:53 UTC (rev 240143)
@@ -69,6 +69,7 @@
return;
m_destination->stop();
+ m_destination = nullptr;
m_numberOfInputChannels = 0;
AudioNode::uninitialize();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
