Title: [240203] trunk/Source/WebKit
Revision
240203
Author
[email protected]
Date
2019-01-19 09:38:40 -0800 (Sat, 19 Jan 2019)

Log Message

Follow-up: iOS: Updating input mode should update the software keyboard
<https://bugs.webkit.org/show_bug.cgi?id=193565>
<rdar://problem/47376334>

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::focusedElementDidChangeInputMode): Fix iOS
Debug builds after r240199 by downcasting `element` to
`HTMLElement` before calling canonicalInputMode().

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (240202 => 240203)


--- trunk/Source/WebKit/ChangeLog	2019-01-19 17:38:36 UTC (rev 240202)
+++ trunk/Source/WebKit/ChangeLog	2019-01-19 17:38:40 UTC (rev 240203)
@@ -1,5 +1,16 @@
 2019-01-19  David Kilzer  <[email protected]>
 
+        Follow-up: iOS: Updating input mode should update the software keyboard
+        <https://bugs.webkit.org/show_bug.cgi?id=193565>
+        <rdar://problem/47376334>
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::focusedElementDidChangeInputMode): Fix iOS
+        Debug builds after r240199 by downcasting `element` to
+        `HTMLElement` before calling canonicalInputMode().
+
+2019-01-19  David Kilzer  <[email protected]>
+
         Sort WebKit Xcode project file
 
         * WebKit.xcodeproj/project.pbxproj:

Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (240202 => 240203)


--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2019-01-19 17:38:36 UTC (rev 240202)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2019-01-19 17:38:40 UTC (rev 240203)
@@ -5365,7 +5365,8 @@
 {
 #if PLATFORM(IOS_FAMILY)
     ASSERT(m_focusedElement == &element);
-    ASSERT(element.canonicalInputMode() == mode);
+    ASSERT(is<HTMLElement>(element));
+    ASSERT(downcast<HTMLElement>(element).canonicalInputMode() == mode);
 
     if (!is<HTMLTextAreaElement>(*m_focusedElement) && !is<HTMLInputElement>(*m_focusedElement) && !m_focusedElement->hasEditableStyle())
         return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to