Title: [240250] trunk/Source/WebKit
Revision
240250
Author
[email protected]
Date
2019-01-22 01:07:00 -0800 (Tue, 22 Jan 2019)

Log Message

Enable CSSOMViewScrollingAPI
https://bugs.webkit.org/show_bug.cgi?id=189472

Patch by Frederic Wang <[email protected]> on 2019-01-22
Reviewed by Simon Fraser.

This patch enables the CSSOMViewScrollingAPI option by default. This feature has already been
enabled in tests since r235855. Basically, this change fixes an old compatibility issue
regarding which scrolling element correspond to the viewport in standard mode (WebKit uses
document.body while Gecko/Edge/Chromium use document.documentElement as described in the
CSSOM View specification). WebKit developers writing tests can use document.scrollingElement
for that purpose, so that they work independently of whether the option is enabled.

[1] https://lists.webkit.org/pipermail/webkit-dev/2018-January/029857.html

* Shared/WebPreferences.yaml: Enable by default and remove "experimental" category in
accordance with the new policy. Instead, keep an internal flag only for developers.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (240249 => 240250)


--- trunk/Source/WebKit/ChangeLog	2019-01-22 06:50:49 UTC (rev 240249)
+++ trunk/Source/WebKit/ChangeLog	2019-01-22 09:07:00 UTC (rev 240250)
@@ -1,3 +1,22 @@
+2019-01-22  Frederic Wang  <[email protected]>
+
+        Enable CSSOMViewScrollingAPI
+        https://bugs.webkit.org/show_bug.cgi?id=189472
+
+        Reviewed by Simon Fraser.
+
+        This patch enables the CSSOMViewScrollingAPI option by default. This feature has already been
+        enabled in tests since r235855. Basically, this change fixes an old compatibility issue
+        regarding which scrolling element correspond to the viewport in standard mode (WebKit uses
+        document.body while Gecko/Edge/Chromium use document.documentElement as described in the
+        CSSOM View specification). WebKit developers writing tests can use document.scrollingElement
+        for that purpose, so that they work independently of whether the option is enabled.
+
+        [1] https://lists.webkit.org/pipermail/webkit-dev/2018-January/029857.html
+
+        * Shared/WebPreferences.yaml: Enable by default and remove "experimental" category in
+        accordance with the new policy. Instead, keep an internal flag only for developers.
+
 2019-01-21  Antti Koivisto  <[email protected]>
 
         [iOS] Handle hit testing for subframes

Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (240249 => 240250)


--- trunk/Source/WebKit/Shared/WebPreferences.yaml	2019-01-22 06:50:49 UTC (rev 240249)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml	2019-01-22 09:07:00 UTC (rev 240250)
@@ -1255,10 +1255,10 @@
 
 CSSOMViewScrollingAPIEnabled:
   type: bool
-  defaultValue: false
+  defaultValue: true
   humanReadableName: "CSSOM View Scrolling API"
   humanReadableDescription: "Implement standard behavior for scrollLeft, scrollTop, scrollWidth, scrollHeight, scrollTo, scrollBy and scrollingElement."
-  category: experimental
+  category: internal
 
 WebAnimationsEnabled:
   type: bool
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to