Title: [240270] trunk/Source/WebInspectorUI
- Revision
- 240270
- Author
- [email protected]
- Date
- 2019-01-22 11:54:05 -0800 (Tue, 22 Jan 2019)
Log Message
Web Inspector: Audit: use plural strings for Passed, Failed, and Unsupported
https://bugs.webkit.org/show_bug.cgi?id=193675
<rdar://problem/46628680>
Reviewed by Joseph Pecoraro.
* UserInterface/Views/AuditTestGroupContentView.js:
(WI.AuditTestGroupContentView.prototype.layout):
* Localizations/en.lproj/localizedStrings.js:
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (240269 => 240270)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-01-22 19:41:10 UTC (rev 240269)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-01-22 19:54:05 UTC (rev 240270)
@@ -1,3 +1,16 @@
+2019-01-22 Devin Rousso <[email protected]>
+
+ Web Inspector: Audit: use plural strings for Passed, Failed, and Unsupported
+ https://bugs.webkit.org/show_bug.cgi?id=193675
+ <rdar://problem/46628680>
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/AuditTestGroupContentView.js:
+ (WI.AuditTestGroupContentView.prototype.layout):
+
+ * Localizations/en.lproj/localizedStrings.js:
+
2019-01-18 Jer Noble <[email protected]>
SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (240269 => 240270)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-01-22 19:41:10 UTC (rev 240269)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-01-22 19:54:05 UTC (rev 240270)
@@ -25,13 +25,16 @@
localizedStrings["%d Error"] = "%d Error";
localizedStrings["%d Errors"] = "%d Errors";
localizedStrings["%d Errors, %d Warnings"] = "%d Errors, %d Warnings";
-localizedStrings["%d Failed"] = "%d Failed";
+localizedStrings["%d Failed (plural)"] = "%d Failed";
+localizedStrings["%d Failed (singular)"] = "%d Failed";
localizedStrings["%d Frame"] = "%d Frame";
localizedStrings["%d Frames"] = "%d Frames";
localizedStrings["%d More\u2026"] = "%d More\u2026";
-localizedStrings["%d Passed"] = "%d Passed";
+localizedStrings["%d Passed (plural)"] = "%d Passed";
+localizedStrings["%d Passed (singular)"] = "%d Passed";
localizedStrings["%d Threads"] = "%d Threads";
-localizedStrings["%d Unsupported"] = "%d Unsupported";
+localizedStrings["%d Unsupported (plural)"] = "%d Unsupported";
+localizedStrings["%d Unsupported (singular)"] = "%d Unsupported";
localizedStrings["%d Warning"] = "%d Warning";
localizedStrings["%d Warnings"] = "%d Warnings";
localizedStrings["%d \xd7 %d pixels"] = "%d \xd7 %d pixels";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js (240269 => 240270)
--- trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js 2019-01-22 19:41:10 UTC (rev 240269)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js 2019-01-22 19:54:05 UTC (rev 240270)
@@ -122,11 +122,11 @@
scopeBarItems.push(scopeBarItem);
};
- addScopeBarItem(WI.AuditTestCaseResult.Level.Pass, WI.UIString("%d Passed"));
+ addScopeBarItem(WI.AuditTestCaseResult.Level.Pass, WI.UIString("%d Passed", "%d Passed (singular)"), WI.UIString("%d Passed", "%d Passed (plural)"));
addScopeBarItem(WI.AuditTestCaseResult.Level.Warn, WI.UIString("%d Warning"), WI.UIString("%d Warnings"));
- addScopeBarItem(WI.AuditTestCaseResult.Level.Fail, WI.UIString("%d Failed"));
+ addScopeBarItem(WI.AuditTestCaseResult.Level.Fail, WI.UIString("%d Failed", "%d Failed (singular)"), WI.UIString("%d Failed", "%d Failed (plural)"));
addScopeBarItem(WI.AuditTestCaseResult.Level.Error, WI.UIString("%d Error"), WI.UIString("%d Errors"));
- addScopeBarItem(WI.AuditTestCaseResult.Level.Unsupported, WI.UIString("%d Unsupported"));
+ addScopeBarItem(WI.AuditTestCaseResult.Level.Unsupported, WI.UIString("%d Unsupported", "%d Unsupported (singular)"), WI.UIString("%d Unsupported", "%d Unsupported (plural)"));
this._levelScopeBar = new WI.ScopeBar(null, scopeBarItems);
this._levelScopeBar.addEventListener(WI.ScopeBar.Event.SelectionChanged, this._handleLevelScopeBarSelectionChanged, this);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
