Title: [102016] trunk/Source/WebCore
- Revision
- 102016
- Author
- [email protected]
- Date
- 2011-12-05 10:46:55 -0800 (Mon, 05 Dec 2011)
Log Message
2011-12-05 Steve Falkenburg <[email protected]>
Reviewed by Sam Weinig.
On Windows, filenames not properly preserved when copied into a file list exposed by Event.dataTransfer
https://bugs.webkit.org/show_bug.cgi?id=73841
<rdar://problem/10521879>
No test since repro case involves dropping a file onto the WebView.
Calling characters() explicitly causes a non-terminated string buffer to get passed back
to the String() constructor that expects a terminated buffer. The characters() call isn't
necessary at all, since we have a String and the method we're calling expects a String.
* platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::files): Remove characters() since it doesn't null terminate.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (102015 => 102016)
--- trunk/Source/WebCore/ChangeLog 2011-12-05 18:45:30 UTC (rev 102015)
+++ trunk/Source/WebCore/ChangeLog 2011-12-05 18:46:55 UTC (rev 102016)
@@ -1,3 +1,20 @@
+2011-12-05 Steve Falkenburg <[email protected]>
+
+ Reviewed by Sam Weinig.
+
+ On Windows, filenames not properly preserved when copied into a file list exposed by Event.dataTransfer
+ https://bugs.webkit.org/show_bug.cgi?id=73841
+ <rdar://problem/10521879>
+
+ No test since repro case involves dropping a file onto the WebView.
+
+ Calling characters() explicitly causes a non-terminated string buffer to get passed back
+ to the String() constructor that expects a terminated buffer. The characters() call isn't
+ necessary at all, since we have a String and the method we're calling expects a String.
+
+ * platform/win/ClipboardWin.cpp:
+ (WebCore::ClipboardWin::files): Remove characters() since it doesn't null terminate.
+
2011-12-05 Timothy Hatcher <[email protected]>
Keep both InspectorBackend.js and InspectorBackendStub.js in Release builds after
Modified: trunk/Source/WebCore/platform/win/ClipboardWin.cpp (102015 => 102016)
--- trunk/Source/WebCore/platform/win/ClipboardWin.cpp 2011-12-05 18:45:30 UTC (rev 102015)
+++ trunk/Source/WebCore/platform/win/ClipboardWin.cpp 2011-12-05 18:46:55 UTC (rev 102016)
@@ -572,7 +572,7 @@
return files.release();
Vector<String> filesVector = m_dragDataMap.get(cfHDropFormat()->cfFormat);
for (Vector<String>::iterator it = filesVector.begin(); it != filesVector.end(); ++it)
- files->append(File::create((*it).characters()));
+ files->append(File::create(*it));
return files.release();
#endif
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
