Title: [240335] trunk/Source/_javascript_Core
- Revision
- 240335
- Author
- [email protected]
- Date
- 2019-01-23 07:40:55 -0800 (Wed, 23 Jan 2019)
Log Message
[JSC] Duplicate global variables: JSC::opcodeLengths
<https://webkit.org/b/193714>
<rdar://problem/47340200>
Reviewed by Mark Lam.
* bytecode/Opcode.cpp:
(JSC::opcodeLengths): Move array implementation here and mark
const.
* bytecode/Opcode.h:
(JSC::opcodeLengths): Change to extern declaration.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (240334 => 240335)
--- trunk/Source/_javascript_Core/ChangeLog 2019-01-23 15:04:50 UTC (rev 240334)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-01-23 15:40:55 UTC (rev 240335)
@@ -1,3 +1,17 @@
+2019-01-23 David Kilzer <[email protected]>
+
+ [JSC] Duplicate global variables: JSC::opcodeLengths
+ <https://webkit.org/b/193714>
+ <rdar://problem/47340200>
+
+ Reviewed by Mark Lam.
+
+ * bytecode/Opcode.cpp:
+ (JSC::opcodeLengths): Move array implementation here and mark
+ const.
+ * bytecode/Opcode.h:
+ (JSC::opcodeLengths): Change to extern declaration.
+
2019-01-23 Carlos Garcia Campos <[email protected]>
[GLIB] Remote Inspector: no data displayed
Modified: trunk/Source/_javascript_Core/bytecode/Opcode.cpp (240334 => 240335)
--- trunk/Source/_javascript_Core/bytecode/Opcode.cpp 2019-01-23 15:04:50 UTC (rev 240334)
+++ trunk/Source/_javascript_Core/bytecode/Opcode.cpp 2019-01-23 15:40:55 UTC (rev 240335)
@@ -40,6 +40,12 @@
namespace JSC {
+const unsigned opcodeLengths[] = {
+#define OPCODE_LENGTH(opcode, length) length,
+ FOR_EACH_OPCODE_ID(OPCODE_LENGTH)
+#undef OPCODE_LENGTH
+};
+
const char* const opcodeNames[] = {
#define OPCODE_NAME_ENTRY(opcode, size) #opcode,
FOR_EACH_OPCODE_ID(OPCODE_NAME_ENTRY)
Modified: trunk/Source/_javascript_Core/bytecode/Opcode.h (240334 => 240335)
--- trunk/Source/_javascript_Core/bytecode/Opcode.h 2019-01-23 15:04:50 UTC (rev 240334)
+++ trunk/Source/_javascript_Core/bytecode/Opcode.h 2019-01-23 15:40:55 UTC (rev 240335)
@@ -71,16 +71,8 @@
#undef OPCODE_ID_ENUM
#endif
-IGNORE_WARNINGS_BEGIN("unused-variable")
+extern const unsigned opcodeLengths[];
-#define OPCODE_LENGTH(opcode, length) length,
- static unsigned opcodeLengths[] = {
- FOR_EACH_OPCODE_ID(OPCODE_LENGTH)
- };
-#undef OPCODE_LENGTH
-
-IGNORE_WARNINGS_END
-
#define OPCODE_ID_LENGTHS(id, length) const int id##_length = length;
FOR_EACH_OPCODE_ID(OPCODE_ID_LENGTHS);
#undef OPCODE_ID_LENGTHS
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
