Title: [240381] branches/safari-607-branch/Source/WebInspectorUI
Revision
240381
Author
[email protected]
Date
2019-01-23 17:21:35 -0800 (Wed, 23 Jan 2019)

Log Message

Cherry-pick r240051. rdar://problem/47458262

    Web Inspector: Fix TreeOutline TypeError:​ this._indexesForSubtree is not a function
    https://bugs.webkit.org/show_bug.cgi?id=193501
    <rdar://problem/47323967>

    Reviewed by Joseph Pecoraro.

    * UserInterface/Views/TreeOutline.js:
    (WI.TreeOutline.prototype.removeChildAtIndex):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-607-branch/Source/WebInspectorUI/ChangeLog (240380 => 240381)


--- branches/safari-607-branch/Source/WebInspectorUI/ChangeLog	2019-01-24 01:21:32 UTC (rev 240380)
+++ branches/safari-607-branch/Source/WebInspectorUI/ChangeLog	2019-01-24 01:21:35 UTC (rev 240381)
@@ -1,3 +1,30 @@
+2019-01-23  Alan Coon  <[email protected]>
+
+        Cherry-pick r240051. rdar://problem/47458262
+
+    Web Inspector: Fix TreeOutline TypeError:​ this._indexesForSubtree is not a function
+    https://bugs.webkit.org/show_bug.cgi?id=193501
+    <rdar://problem/47323967>
+    
+    Reviewed by Joseph Pecoraro.
+    
+    * UserInterface/Views/TreeOutline.js:
+    (WI.TreeOutline.prototype.removeChildAtIndex):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-01-16  Matt Baker  <[email protected]>
+
+            Web Inspector: Fix TreeOutline TypeError:​ this._indexesForSubtree is not a function
+            https://bugs.webkit.org/show_bug.cgi?id=193501
+            <rdar://problem/47323967>
+
+            Reviewed by Joseph Pecoraro.
+
+            * UserInterface/Views/TreeOutline.js:
+            (WI.TreeOutline.prototype.removeChildAtIndex):
+
 2019-01-15  Alan Coon  <[email protected]>
 
         Cherry-pick r239870. rdar://problem/47260266

Modified: branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (240380 => 240381)


--- branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js	2019-01-24 01:21:32 UTC (rev 240380)
+++ branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js	2019-01-24 01:21:35 UTC (rev 240381)
@@ -323,14 +323,15 @@
                 parent.select(true, false);
         }
 
+        let removedIndexes = null;
+
         let treeOutline = child.treeOutline;
         if (treeOutline) {
             treeOutline._forgetTreeElement(child);
             treeOutline._forgetChildrenRecursive(child);
+            removedIndexes = treeOutline._indexesForSubtree(child);
         }
 
-        let removedIndexes = this._indexesForSubtree(child);
-
         if (child.previousSibling)
             child.previousSibling.nextSibling = child.nextSibling;
         if (child.nextSibling)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to