Diff
Modified: branches/safari-607-branch/LayoutTests/ChangeLog (240387 => 240388)
--- branches/safari-607-branch/LayoutTests/ChangeLog 2019-01-24 01:21:56 UTC (rev 240387)
+++ branches/safari-607-branch/LayoutTests/ChangeLog 2019-01-24 01:22:00 UTC (rev 240388)
@@ -1,5 +1,42 @@
2019-01-23 Alan Coon <[email protected]>
+ Cherry-pick r240158. rdar://problem/47458281
+
+ FetchResponse::url should return the empty string for tainted responses
+ https://bugs.webkit.org/show_bug.cgi?id=193553
+
+ Reviewed by Youenn Fablet.
+
+ LayoutTests/imported/w3c:
+
+ * web-platform-tests/fetch/api/basic/mode-no-cors.sub.any.js:
+ (fetchNoCors):
+
+ Source/WebCore:
+
+ Check whether the response is tainted in FetchResponse::url, to match
+ the behavior described in https://fetch.spec.whatwg.org/#concept-filtered-response-opaque.
+
+ * Modules/fetch/FetchResponse.cpp:
+ (WebCore::FetchResponse::url const):
+
+ LayoutTests:
+
+ * http/wpt/fetch/response-opaque-clone.html:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-01-18 Ali Juma <[email protected]>
+
+ FetchResponse::url should return the empty string for tainted responses
+ https://bugs.webkit.org/show_bug.cgi?id=193553
+
+ Reviewed by Youenn Fablet.
+
+ * http/wpt/fetch/response-opaque-clone.html:
+
+2019-01-23 Alan Coon <[email protected]>
+
Cherry-pick r240152. rdar://problem/47458242
A track source should be unmuted whenever reenabled after setDirection changes
Modified: branches/safari-607-branch/LayoutTests/http/wpt/fetch/response-opaque-clone.html (240387 => 240388)
--- branches/safari-607-branch/LayoutTests/http/wpt/fetch/response-opaque-clone.html 2019-01-24 01:21:56 UTC (rev 240387)
+++ branches/safari-607-branch/LayoutTests/http/wpt/fetch/response-opaque-clone.html 2019-01-24 01:22:00 UTC (rev 240388)
@@ -16,6 +16,7 @@
assert_equals(response.type, "opaque", testName + " type");
assert_equals(response.status, 0, testName + " status");
assert_equals(response.statusText, "", testName + " statusText");
+ assert_equals(response.url, "", testName + " url");
assert_false(response.redirected, testName + " redirected");
assert_true(response.headers.values().next().done, testName + " headers");
assert_equals(response.body, null, testName + " opaque response body should be null");
Modified: branches/safari-607-branch/LayoutTests/imported/w3c/ChangeLog (240387 => 240388)
--- branches/safari-607-branch/LayoutTests/imported/w3c/ChangeLog 2019-01-24 01:21:56 UTC (rev 240387)
+++ branches/safari-607-branch/LayoutTests/imported/w3c/ChangeLog 2019-01-24 01:22:00 UTC (rev 240388)
@@ -1,3 +1,41 @@
+2019-01-23 Alan Coon <[email protected]>
+
+ Cherry-pick r240158. rdar://problem/47458281
+
+ FetchResponse::url should return the empty string for tainted responses
+ https://bugs.webkit.org/show_bug.cgi?id=193553
+
+ Reviewed by Youenn Fablet.
+
+ LayoutTests/imported/w3c:
+
+ * web-platform-tests/fetch/api/basic/mode-no-cors.sub.any.js:
+ (fetchNoCors):
+
+ Source/WebCore:
+
+ Check whether the response is tainted in FetchResponse::url, to match
+ the behavior described in https://fetch.spec.whatwg.org/#concept-filtered-response-opaque.
+
+ * Modules/fetch/FetchResponse.cpp:
+ (WebCore::FetchResponse::url const):
+
+ LayoutTests:
+
+ * http/wpt/fetch/response-opaque-clone.html:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-01-18 Ali Juma <[email protected]>
+
+ FetchResponse::url should return the empty string for tainted responses
+ https://bugs.webkit.org/show_bug.cgi?id=193553
+
+ Reviewed by Youenn Fablet.
+
+ * web-platform-tests/fetch/api/basic/mode-no-cors.sub.any.js:
+ (fetchNoCors):
+
2019-01-05 Youenn Fablet <[email protected]>
Service Worker fetch should obey its referrer policy
Modified: branches/safari-607-branch/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.js (240387 => 240388)
--- branches/safari-607-branch/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.js 2019-01-24 01:21:56 UTC (rev 240387)
+++ branches/safari-607-branch/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.js 2019-01-24 01:22:00 UTC (rev 240388)
@@ -10,6 +10,7 @@
return fetch(url + urlQuery, {"mode": "no-cors"}).then(function(resp) {
assert_equals(resp.status, 0, "Opaque filter: status is 0");
assert_equals(resp.statusText, "", "Opaque filter: statusText is \"\"");
+ assert_equals(resp.url, "", "Opaque filter: url is \"\"");
assert_equals(resp.type , "opaque", "Opaque filter: response's type is opaque");
assert_equals(resp.headers.get("x-is-filtered"), null, "Header x-is-filtered is filtered");
});
Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (240387 => 240388)
--- branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 01:21:56 UTC (rev 240387)
+++ branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 01:22:00 UTC (rev 240388)
@@ -1,5 +1,46 @@
2019-01-23 Alan Coon <[email protected]>
+ Cherry-pick r240158. rdar://problem/47458281
+
+ FetchResponse::url should return the empty string for tainted responses
+ https://bugs.webkit.org/show_bug.cgi?id=193553
+
+ Reviewed by Youenn Fablet.
+
+ LayoutTests/imported/w3c:
+
+ * web-platform-tests/fetch/api/basic/mode-no-cors.sub.any.js:
+ (fetchNoCors):
+
+ Source/WebCore:
+
+ Check whether the response is tainted in FetchResponse::url, to match
+ the behavior described in https://fetch.spec.whatwg.org/#concept-filtered-response-opaque.
+
+ * Modules/fetch/FetchResponse.cpp:
+ (WebCore::FetchResponse::url const):
+
+ LayoutTests:
+
+ * http/wpt/fetch/response-opaque-clone.html:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-01-18 Ali Juma <[email protected]>
+
+ FetchResponse::url should return the empty string for tainted responses
+ https://bugs.webkit.org/show_bug.cgi?id=193553
+
+ Reviewed by Youenn Fablet.
+
+ Check whether the response is tainted in FetchResponse::url, to match
+ the behavior described in https://fetch.spec.whatwg.org/#concept-filtered-response-opaque.
+
+ * Modules/fetch/FetchResponse.cpp:
+ (WebCore::FetchResponse::url const):
+
+2019-01-23 Alan Coon <[email protected]>
+
Cherry-pick r240152. rdar://problem/47458242
A track source should be unmuted whenever reenabled after setDirection changes
Modified: branches/safari-607-branch/Source/WebCore/Modules/fetch/FetchResponse.cpp (240387 => 240388)
--- branches/safari-607-branch/Source/WebCore/Modules/fetch/FetchResponse.cpp 2019-01-24 01:21:56 UTC (rev 240387)
+++ branches/safari-607-branch/Source/WebCore/Modules/fetch/FetchResponse.cpp 2019-01-24 01:22:00 UTC (rev 240388)
@@ -243,7 +243,7 @@
const String& FetchResponse::url() const
{
if (m_responseURL.isNull()) {
- URL url = ""
+ URL url = ""
url.removeFragmentIdentifier();
m_responseURL = url.string();
}
