[webkit-changes] [240403] trunk/Source

Wed, 23 Jan 2019 18:51:31 -0800

Title: [240403] trunk/Source
Revision
240403
Author
[email protected]
Date
2019-01-23 18:50:13 -0800 (Wed, 23 Jan 2019)

Log Message

[Curl] Unreviewed build fix for r240292 and friends.

WinCairo test stability must be restored in subsequent patch.

Source/WebKit:

* NetworkProcess/curl/NetworkProcessCurl.cpp:
(WebKit::NetworkProcess::platformCreateDefaultStorageSession const):
(WebKit::NetworkProcess::setNetworkProxySettings):

Source/WebKitLegacy:

* WebCoreSupport/NetworkStorageSessionMap.cpp:
(NetworkStorageSessionMap::defaultStorageSession):
(NetworkStorageSessionMap::switchToNewTestingSession):
(NetworkStorageSessionMap::ensureSession):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (240402 => 240403)


--- trunk/Source/WebKit/ChangeLog	2019-01-24 02:47:53 UTC (rev 240402)
+++ trunk/Source/WebKit/ChangeLog	2019-01-24 02:50:13 UTC (rev 240403)
@@ -1,3 +1,13 @@
+2019-01-23  Ross Kirsling  <[email protected]>
+
+        [Curl] Unreviewed build fix for r240292 and friends.
+
+        WinCairo test stability must be restored in subsequent patch.
+
+        * NetworkProcess/curl/NetworkProcessCurl.cpp:
+        (WebKit::NetworkProcess::platformCreateDefaultStorageSession const):
+        (WebKit::NetworkProcess::setNetworkProxySettings):
+
 2019-01-23  Alex Christensen  <[email protected]>
 
         Stop using NetworkProcess::singleton

Modified: trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp (240402 => 240403)


--- trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp	2019-01-24 02:47:53 UTC (rev 240402)
+++ trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp	2019-01-24 02:50:13 UTC (rev 240403)
@@ -41,7 +41,7 @@
 
 std::unique_ptr<WebCore::NetworkStorageSession> NetworkProcess::platformCreateDefaultStorageSession() const
 {
-    return std::make_unique<WebCore::NetworkStorageSession>(PAL::SessionID::defaultSessionID(), CurlContext::singleton());
+    return std::make_unique<WebCore::NetworkStorageSession>(PAL::SessionID::defaultSessionID(), nullptr);
 }
 
 void NetworkProcess::allowSpecificHTTPSCertificateForHost(const CertificateInfo& certificateInfo, const String& host)
@@ -88,7 +88,7 @@
 
 void NetworkProcess::setNetworkProxySettings(PAL::SessionID sessionID, WebCore::CurlProxySettings&& settings)
 {
-    if (auto* networkStorageSession = NetworkStorageSession::storageSession(sessionID))
+    if (auto* networkStorageSession = storageSession(sessionID))
         networkStorageSession->setProxySettings(WTFMove(settings));
     else
         ASSERT_NOT_REACHED();

Modified: trunk/Source/WebKitLegacy/ChangeLog (240402 => 240403)


--- trunk/Source/WebKitLegacy/ChangeLog	2019-01-24 02:47:53 UTC (rev 240402)
+++ trunk/Source/WebKitLegacy/ChangeLog	2019-01-24 02:50:13 UTC (rev 240403)
@@ -1,3 +1,14 @@
+2019-01-23  Ross Kirsling  <[email protected]>
+
+        [Curl] Unreviewed build fix for r240292 and friends.
+
+        WinCairo test stability must be restored in subsequent patch.
+
+        * WebCoreSupport/NetworkStorageSessionMap.cpp:
+        (NetworkStorageSessionMap::defaultStorageSession):
+        (NetworkStorageSessionMap::switchToNewTestingSession):
+        (NetworkStorageSessionMap::ensureSession):
+
 2019-01-22  Alex Christensen  <[email protected]>
 
         Fix some builds after r240292

Modified: trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp (240402 => 240403)


--- trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp	2019-01-24 02:47:53 UTC (rev 240402)
+++ trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp	2019-01-24 02:50:13 UTC (rev 240403)
@@ -53,13 +53,19 @@
 
 WebCore::NetworkStorageSession& NetworkStorageSessionMap::defaultStorageSession()
 {
-    if (!defaultNetworkStorageSession())
+    if (!defaultNetworkStorageSession()) {
+#if USE(CURL)
+        defaultNetworkStorageSession() = std::make_unique<WebCore::NetworkStorageSession>(PAL::SessionID::defaultSessionID(), nullptr);
+#else
         defaultNetworkStorageSession() = std::make_unique<WebCore::NetworkStorageSession>(PAL::SessionID::defaultSessionID());
+#endif
+    }
     return *defaultNetworkStorageSession();
 }
 
 void NetworkStorageSessionMap::switchToNewTestingSession()
 {
+#if USE(CFURLCONNECTION)
     // Session name should be short enough for shared memory region name to be under the limit, otehrwise sandbox rules won't work (see <rdar://problem/13642852>).
     String sessionName = String::format("WebKit Test-%u", static_cast<uint32_t>(getCurrentProcessID()));
 
@@ -73,10 +79,12 @@
     }
 
     defaultNetworkStorageSession() = std::make_unique<WebCore::NetworkStorageSession>(PAL::SessionID::defaultSessionID(), WTFMove(session), WTFMove(cookieStorage));
+#endif
 }
 
 void NetworkStorageSessionMap::ensureSession(const PAL::SessionID& sessionID, const String& identifierBase)
 {
+#if USE(CFURLCONNECTION)
     auto addResult = globalSessionMap().add(sessionID, nullptr);
     if (!addResult.isNewEntry)
         return;
@@ -97,6 +105,7 @@
     }
 
     addResult.iterator->value = std::make_unique<WebCore::NetworkStorageSession>(sessionID, WTFMove(storageSession), WTFMove(cookieStorage));
+#endif
 }
 
 void NetworkStorageSessionMap::destroySession(const PAL::SessionID& sessionID)

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to