Title: [240422] branches/safari-607-branch/Source/WebInspectorUI
- Revision
- 240422
- Author
- [email protected]
- Date
- 2019-01-23 22:42:35 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r240290. rdar://problem/47494764
Web Inspector: Network Table appears broken after filter - rows look collapsed
https://bugs.webkit.org/show_bug.cgi?id=192730
<rdar://problem/46853158>
Patch by Joseph Pecoraro <[email protected]> on 2019-01-22
Reviewed by Devin Rousso.
* UserInterface/Views/Table.js:
(WI.Table.prototype._applyColumnWidthsToColumnsIfNeeded):
Affect the filler row like the other applyColumnWidths calls since this
now may be the initial call to size visible columns.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-607-branch/Source/WebInspectorUI/ChangeLog (240421 => 240422)
--- branches/safari-607-branch/Source/WebInspectorUI/ChangeLog 2019-01-24 06:42:32 UTC (rev 240421)
+++ branches/safari-607-branch/Source/WebInspectorUI/ChangeLog 2019-01-24 06:42:35 UTC (rev 240422)
@@ -1,5 +1,36 @@
2019-01-23 Alan Coon <[email protected]>
+ Cherry-pick r240290. rdar://problem/47494764
+
+ Web Inspector: Network Table appears broken after filter - rows look collapsed
+ https://bugs.webkit.org/show_bug.cgi?id=192730
+ <rdar://problem/46853158>
+
+ Patch by Joseph Pecoraro <[email protected]> on 2019-01-22
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/Table.js:
+ (WI.Table.prototype._applyColumnWidthsToColumnsIfNeeded):
+ Affect the filler row like the other applyColumnWidths calls since this
+ now may be the initial call to size visible columns.
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-01-22 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Network Table appears broken after filter - rows look collapsed
+ https://bugs.webkit.org/show_bug.cgi?id=192730
+ <rdar://problem/46853158>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/Table.js:
+ (WI.Table.prototype._applyColumnWidthsToColumnsIfNeeded):
+ Affect the filler row like the other applyColumnWidths calls since this
+ now may be the initial call to size visible columns.
+
+2019-01-23 Alan Coon <[email protected]>
+
Cherry-pick r239935. rdar://problem/47295382
Web Inspector: Styles: pressing Down key on empty value field shouldn't discard completion popover
Modified: branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/Table.js (240421 => 240422)
--- branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/Table.js 2019-01-24 06:42:32 UTC (rev 240421)
+++ branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/Table.js 2019-01-24 06:42:35 UTC (rev 240422)
@@ -1153,11 +1153,13 @@
{
// Apply and create missing cells only if row needs a width update.
for (let row of this._listElement.children) {
- if (row.__widthGeneration !== this._widthGeneration && row !== this._fillerRow) {
+ if (row.__widthGeneration !== this._widthGeneration) {
for (let i = 0; i < row.children.length; ++i)
row.children[i].style.width = this._columnWidths[i] + "px";
- if (row.children.length !== this._visibleColumns.length)
- this._populateRow(row);
+ if (row !== this._fillerRow) {
+ if (row.children.length !== this._visibleColumns.length)
+ this._populateRow(row);
+ }
row.__widthGeneration = this._widthGeneration;
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
