Title: [240440] trunk/Tools
- Revision
- 240440
- Author
- [email protected]
- Date
- 2019-01-24 10:26:05 -0800 (Thu, 24 Jan 2019)
Log Message
webkitpy: Missing PID in crashlog name should not be fatal
https://bugs.webkit.org/show_bug.cgi?id=193771
If we can't determine the PID of a crashlog, just ignore the crashlog instead
of raising an exception.
Reviewed by Lucas Forschler.
* Scripts/webkitpy/port/darwin.py:
(DarwinPort._merge_crash_logs):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (240439 => 240440)
--- trunk/Tools/ChangeLog 2019-01-24 17:52:35 UTC (rev 240439)
+++ trunk/Tools/ChangeLog 2019-01-24 18:26:05 UTC (rev 240440)
@@ -1,3 +1,16 @@
+2019-01-24 Jonathan Bedard <[email protected]>
+
+ webkitpy: Missing PID in crashlog name should not be fatal
+ https://bugs.webkit.org/show_bug.cgi?id=193771
+
+ If we can't determine the PID of a crashlog, just ignore the crashlog instead
+ of raising an exception.
+
+ Reviewed by Lucas Forschler.
+
+ * Scripts/webkitpy/port/darwin.py:
+ (DarwinPort._merge_crash_logs):
+
2019-01-24 Michael Catanzaro <[email protected]>
test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
Modified: trunk/Tools/Scripts/webkitpy/port/darwin.py (240439 => 240440)
--- trunk/Tools/Scripts/webkitpy/port/darwin.py 2019-01-24 17:52:35 UTC (rev 240439)
+++ trunk/Tools/Scripts/webkitpy/port/darwin.py 2019-01-24 18:26:05 UTC (rev 240440)
@@ -104,7 +104,7 @@
else:
process_name = test.split('-')[0]
pid = int(test.split('-')[1])
- except IndexError:
+ except IndexError, ValueError:
continue
if not any(entry[1] == process_name and entry[2] == pid for entry in crashed_processes):
# if this is a new crash, then append the logs
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
