Title: [102038] trunk/Source/_javascript_Core
- Revision
- 102038
- Author
- [email protected]
- Date
- 2011-12-05 13:25:18 -0800 (Mon, 05 Dec 2011)
Log Message
Unreviewed, build fixes for ARM.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::unreachableForPlatform):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::loadFloat):
(JSC::MacroAssemblerARMv7::storeFloat):
(JSC::MacroAssemblerARMv7::convertFloatToDouble):
(JSC::MacroAssemblerARMv7::convertDoubleToFloat):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (102037 => 102038)
--- trunk/Source/_javascript_Core/ChangeLog 2011-12-05 21:23:54 UTC (rev 102037)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-12-05 21:25:18 UTC (rev 102038)
@@ -1,3 +1,16 @@
+2011-12-05 Filip Pizlo <[email protected]>
+
+ Unreviewed, build fixes for ARM.
+
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::unreachableForPlatform):
+ * assembler/MacroAssemblerARMv7.h:
+ (JSC::MacroAssemblerARMv7::loadDouble):
+ (JSC::MacroAssemblerARMv7::loadFloat):
+ (JSC::MacroAssemblerARMv7::storeFloat):
+ (JSC::MacroAssemblerARMv7::convertFloatToDouble):
+ (JSC::MacroAssemblerARMv7::convertDoubleToFloat):
+
2011-12-05 Benjamin Poulain <[email protected]>
Update String::containsOnlyLatin1() to avoid converting to 16 bits
Modified: trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h (102037 => 102038)
--- trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h 2011-12-05 21:23:54 UTC (rev 102037)
+++ trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h 2011-12-05 21:25:18 UTC (rev 102038)
@@ -597,6 +597,18 @@
{
return AssemblerType::readPointer(dataLabelPtr.dataLocation());
}
+
+ static void unreachableForPlatform()
+ {
+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wmissing-noreturn"
+ ASSERT_NOT_REACHED();
+#pragma clang diagnostic pop
+#else
+ ASSERT_NOT_REACHED();
+#endif
+ }
};
} // namespace JSC
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h (102037 => 102038)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h 2011-12-05 21:23:54 UTC (rev 102037)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h 2011-12-05 21:25:18 UTC (rev 102038)
@@ -713,12 +713,16 @@
void loadDouble(BaseIndex address, FPRegisterID dest)
{
- ASSERT_NOT_REACHED();
+ UNUSED_PARAM(address);
+ UNUSED_PARAM(dest);
+ unreachableForPlatform();
}
void loadFloat(BaseIndex address, FPRegisterID dest)
{
- ASSERT_NOT_REACHED();
+ UNUSED_PARAM(address);
+ UNUSED_PARAM(dest);
+ unreachableForPlatform();
}
void moveDouble(FPRegisterID src, FPRegisterID dest)
@@ -765,7 +769,7 @@
{
move(address.index, addressTempRegister);
mul32(TrustedImm32(address.scale), addressTempRegister, addressTempRegister);
- storeDouble(ARMRegisters::asSingle(src), Address(addressTempRegister, address.offset));
+ storeDouble(src, Address(addressTempRegister, address.offset));
}
void addDouble(FPRegisterID src, FPRegisterID dest)
@@ -866,12 +870,16 @@
void convertFloatToDouble(FPRegisterID src, FPRegisterID dst)
{
- ASSERT_NOT_REACHED();
+ UNUSED_PARAM(src);
+ UNUSED_PARAM(dst);
+ unreachableForPlatform();
}
void convertDoubleToFloat(FPRegisterID src, FPRegisterID dst)
{
- ASSERT_NOT_REACHED();
+ UNUSED_PARAM(src);
+ UNUSED_PARAM(dst);
+ unreachableForPlatform();
}
Jump branchDouble(DoubleCondition cond, FPRegisterID left, FPRegisterID right)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
