Title: [240514] trunk/Source/WebKit
- Revision
- 240514
- Author
- [email protected]
- Date
- 2019-01-25 15:12:43 -0800 (Fri, 25 Jan 2019)
Log Message
[iOS] Pressing Tab key doesn't move to next cell with Google Sheets
https://bugs.webkit.org/show_bug.cgi?id=193048
<rdar://problem/46433836>
Reviewed by Brent Fulgham.
WebCore knows how interpret the Tab and Shift + Tab keys. When building with UIKit keyboard additions
we do not need to register key commands for handling them from the UIProcess code. Instead UIKit will
sends key events for these commands to us. This will make the behavior of these key commands when executed
in an editable field match the behavior of these command when executed in a non-editable field since
both code paths will now go through WebCore.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView keyCommands]): Only compile when building with !USE(UIKIT_KEYBOARD_ADDITIONS).
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (240513 => 240514)
--- trunk/Source/WebKit/ChangeLog 2019-01-25 22:57:42 UTC (rev 240513)
+++ trunk/Source/WebKit/ChangeLog 2019-01-25 23:12:43 UTC (rev 240514)
@@ -1,3 +1,20 @@
+2019-01-25 Daniel Bates <[email protected]>
+
+ [iOS] Pressing Tab key doesn't move to next cell with Google Sheets
+ https://bugs.webkit.org/show_bug.cgi?id=193048
+ <rdar://problem/46433836>
+
+ Reviewed by Brent Fulgham.
+
+ WebCore knows how interpret the Tab and Shift + Tab keys. When building with UIKit keyboard additions
+ we do not need to register key commands for handling them from the UIProcess code. Instead UIKit will
+ sends key events for these commands to us. This will make the behavior of these key commands when executed
+ in an editable field match the behavior of these command when executed in a non-editable field since
+ both code paths will now go through WebCore.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView keyCommands]): Only compile when building with !USE(UIKIT_KEYBOARD_ADDITIONS).
+
2019-01-25 Alex Christensen <[email protected]>
Fix Linux build.
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (240513 => 240514)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-01-25 22:57:42 UTC (rev 240513)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-01-25 23:12:43 UTC (rev 240514)
@@ -3306,6 +3306,7 @@
[self resignFirstResponder];
}
+#if !USE(UIKIT_KEYBOARD_ADDITIONS)
- (NSArray *)keyCommands
{
if (!_page->editorState().isContentEditable)
@@ -3317,6 +3318,7 @@
] retain];
return editableKeyCommands;
}
+#endif
- (void)_nextAccessoryTabForWebView:(id)sender
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
