Title: [240536] trunk/LayoutTests
Revision
240536
Author
[email protected]
Date
2019-01-25 17:40:24 -0800 (Fri, 25 Jan 2019)

Log Message

Fix failing scrollingcoordinator/scrolling-tree/remove-scrolling-role.html

Test needed different macOS and iOS results. Added window.internals.settings.setAsyncOverflowScrollingEnabled(true)
so the test uses async overflow scrolling in the macOS result.

* platform/ios-wk2/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt: Copied from LayoutTests/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt.
* scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt:
* scrollingcoordinator/scrolling-tree/remove-scrolling-role.html:

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (240535 => 240536)


--- trunk/LayoutTests/ChangeLog	2019-01-26 01:40:20 UTC (rev 240535)
+++ trunk/LayoutTests/ChangeLog	2019-01-26 01:40:24 UTC (rev 240536)
@@ -1,5 +1,16 @@
 2019-01-25  Simon Fraser  <[email protected]>
 
+        Fix failing scrollingcoordinator/scrolling-tree/remove-scrolling-role.html
+
+        Test needed different macOS and iOS results. Added window.internals.settings.setAsyncOverflowScrollingEnabled(true)
+        so the test uses async overflow scrolling in the macOS result.
+
+        * platform/ios-wk2/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt: Copied from LayoutTests/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt.
+        * scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt:
+        * scrollingcoordinator/scrolling-tree/remove-scrolling-role.html:
+
+2019-01-25  Simon Fraser  <[email protected]>
+
         Add a scrolling tree test that toggles scrollability on an intermediate iframe
         https://bugs.webkit.org/show_bug.cgi?id=193849
 

Copied: trunk/LayoutTests/platform/ios-wk2/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt (from rev 240535, trunk/LayoutTests/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt) (0 => 240536)


--- trunk/LayoutTests/platform/ios-wk2/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/ios-wk2/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt	2019-01-26 01:40:24 UTC (rev 240536)
@@ -0,0 +1,27 @@
+
+(Frame scrolling node
+  (scrollable area size 800 600)
+  (contents size 800 2513)
+  (scrollable area parameters 
+    (horizontal scroll elasticity 1)
+    (vertical scroll elasticity 1)
+    (horizontal scrollbar mode 0)
+    (vertical scrollbar mode 0))
+  (visual viewport enabled 1)
+  (layout viewport at (0,0) size 800x600)
+  (min layout viewport origin (0,0))
+  (max layout viewport origin (0,1913))
+  (behavior for fixed 0)
+  (children 1
+    (Overflow scrolling node
+      (scrollable area size 300 400)
+      (contents size 300 2000)
+      (scrollable area parameters 
+        (horizontal scroll elasticity 1)
+        (vertical scroll elasticity 1)
+        (horizontal scrollbar mode 0)
+        (vertical scrollbar mode 0))
+    )
+  )
+)
+

Modified: trunk/LayoutTests/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt (240535 => 240536)


--- trunk/LayoutTests/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt	2019-01-26 01:40:20 UTC (rev 240535)
+++ trunk/LayoutTests/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt	2019-01-26 01:40:24 UTC (rev 240536)
@@ -1,21 +1,22 @@
 
 (Frame scrolling node
-  (scrollable area size 800 600)
-  (contents size 800 2513)
+  (scrollable area size 785 600)
+  (contents size 785 2513)
   (scrollable area parameters 
-    (horizontal scroll elasticity 1)
-    (vertical scroll elasticity 1)
+    (horizontal scroll elasticity 2)
+    (vertical scroll elasticity 2)
     (horizontal scrollbar mode 0)
-    (vertical scrollbar mode 0))
+    (vertical scrollbar mode 0)
+    (has enabled vertical scrollbar 1))
   (visual viewport enabled 1)
-  (layout viewport at (0,0) size 800x600)
+  (layout viewport at (0,0) size 785x600)
   (min layout viewport origin (0,0))
   (max layout viewport origin (0,1913))
   (behavior for fixed 0)
   (children 1
     (Overflow scrolling node
-      (scrollable area size 300 400)
-      (contents size 300 2000)
+      (scrollable area size 285 400)
+      (contents size 285 2000)
       (scrollable area parameters 
         (horizontal scroll elasticity 1)
         (vertical scroll elasticity 1)

Modified: trunk/LayoutTests/scrollingcoordinator/scrolling-tree/remove-scrolling-role.html (240535 => 240536)


--- trunk/LayoutTests/scrollingcoordinator/scrolling-tree/remove-scrolling-role.html	2019-01-26 01:40:20 UTC (rev 240535)
+++ trunk/LayoutTests/scrollingcoordinator/scrolling-tree/remove-scrolling-role.html	2019-01-26 01:40:24 UTC (rev 240536)
@@ -36,6 +36,9 @@
             testRunner.dumpAsText();
         }
 
+        if (window.internals)
+            window.internals.settings.setAsyncOverflowScrollingEnabled(true);
+
         function doTest()
         {
             window.setTimeout(function() {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to