Title: [240538] trunk/Source/WebInspectorUI
- Revision
- 240538
- Author
- [email protected]
- Date
- 2019-01-25 19:24:03 -0800 (Fri, 25 Jan 2019)
Log Message
Web Inspector: Audit: unable to import audits
https://bugs.webkit.org/show_bug.cgi?id=193861
Reviewed by Joseph Pecoraro.
* UserInterface/Controllers/AuditManager.js:
(WI.AuditManager.prototype.async processJSON):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (240537 => 240538)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-01-26 01:46:50 UTC (rev 240537)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-01-26 03:24:03 UTC (rev 240538)
@@ -1,5 +1,15 @@
2019-01-25 Devin Rousso <[email protected]>
+ Web Inspector: Audit: unable to import audits
+ https://bugs.webkit.org/show_bug.cgi?id=193861
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Controllers/AuditManager.js:
+ (WI.AuditManager.prototype.async processJSON):
+
+2019-01-25 Devin Rousso <[email protected]>
+
Web Inspector: Uncaught Exception: No node with given id found
https://bugs.webkit.org/show_bug.cgi?id=193833
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js (240537 => 240538)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js 2019-01-26 01:46:50 UTC (rev 240537)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js 2019-01-26 03:24:03 UTC (rev 240538)
@@ -198,8 +198,8 @@
return;
}
- if (json.type !== WI.AuditTestCase.TypeIdentifier || json.type !== WI.AuditTestGroup.TypeIdentifier
- || json.type !== WI.AuditTestCaseResult.TypeIdentifier || json.type !== WI.AuditTestGroupResult.TypeIdentifier) {
+ if (json.type !== WI.AuditTestCase.TypeIdentifier && json.type !== WI.AuditTestGroup.TypeIdentifier
+ && json.type !== WI.AuditTestCaseResult.TypeIdentifier && json.type !== WI.AuditTestGroupResult.TypeIdentifier) {
WI.AuditManager.synthesizeError(WI.UIString("unknown %s \u0022%s\u0022").format(WI.unlocalizedString("type"), json.type));
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
