Title: [240566] branches/safari-607-branch/Source/WebCore
- Revision
- 240566
- Author
- [email protected]
- Date
- 2019-01-28 01:40:54 -0800 (Mon, 28 Jan 2019)
Log Message
Cherry-pick r240451. rdar://problem/47586844
Fix leak of AVSampleBufferRenderSynchronizer boundaryObserver object.
https://bugs.webkit.org/show_bug.cgi?id=193778
Reviewed by Jon Lee.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::performTaskAtMediaTime):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (240565 => 240566)
--- branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-28 09:40:51 UTC (rev 240565)
+++ branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-28 09:40:54 UTC (rev 240566)
@@ -1,5 +1,30 @@
2019-01-28 Babak Shafiei <[email protected]>
+ Cherry-pick r240451. rdar://problem/47586844
+
+ Fix leak of AVSampleBufferRenderSynchronizer boundaryObserver object.
+ https://bugs.webkit.org/show_bug.cgi?id=193778
+
+ Reviewed by Jon Lee.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
+ (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::performTaskAtMediaTime):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-01-24 Jer Noble <[email protected]>
+
+ Fix leak of AVSampleBufferRenderSynchronizer boundaryObserver object.
+ https://bugs.webkit.org/show_bug.cgi?id=193778
+
+ Reviewed by Jon Lee.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
+ (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::performTaskAtMediaTime):
+
+2019-01-28 Babak Shafiei <[email protected]>
+
Cherry-pick r240450. rdar://problem/47586830
DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
Modified: branches/safari-607-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm (240565 => 240566)
--- branches/safari-607-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2019-01-28 09:40:51 UTC (rev 240565)
+++ branches/safari-607-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2019-01-28 09:40:54 UTC (rev 240566)
@@ -1103,7 +1103,10 @@
{
__block WTF::Function<void()> taskIn = WTFMove(task);
- [m_synchronizer addBoundaryTimeObserverForTimes:@[[NSValue valueWithCMTime:toCMTime(time)]] queue:dispatch_get_main_queue() usingBlock:^{
+ if (m_performTaskObserver)
+ [m_synchronizer removeTimeObserver:m_performTaskObserver.get()];
+
+ m_performTaskObserver = [m_synchronizer addBoundaryTimeObserverForTimes:@[[NSValue valueWithCMTime:toCMTime(time)]] queue:dispatch_get_main_queue() usingBlock:^{
taskIn();
}];
return true;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
