Diff
Modified: trunk/Source/_javascript_Core/API/JSWeakObjectMapRefPrivate.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/API/JSWeakObjectMapRefPrivate.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/API/JSWeakObjectMapRefPrivate.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -34,7 +34,6 @@
#include "Weak.h"
#include "WeakGCMapInlines.h"
-using namespace WTF;
using namespace JSC;
#ifdef __cplusplus
Modified: trunk/Source/_javascript_Core/ChangeLog (240640 => 240641)
--- trunk/Source/_javascript_Core/ChangeLog 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-01-29 06:00:30 UTC (rev 240641)
@@ -1,3 +1,33 @@
+2019-01-28 Ross Kirsling <[email protected]>
+
+ Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
+ https://bugs.webkit.org/show_bug.cgi?id=193941
+
+ Reviewed by Alex Christensen.
+
+ * API/JSWeakObjectMapRefPrivate.cpp:
+ * bytecompiler/NodesCodegen.cpp:
+ * heap/MachineStackMarker.cpp:
+ * jit/ExecutableAllocator.cpp:
+ * jsc.cpp:
+ * parser/Nodes.cpp:
+ * runtime/DateConstructor.cpp:
+ * runtime/DateConversion.cpp:
+ * runtime/DateInstance.cpp:
+ * runtime/DatePrototype.cpp:
+ * runtime/InitializeThreading.cpp:
+ * runtime/IteratorOperations.cpp:
+ * runtime/JSDateMath.cpp:
+ * runtime/JSGlobalObjectFunctions.cpp:
+ * runtime/StringPrototype.cpp:
+ * runtime/VM.cpp:
+ * testRegExp.cpp:
+ * tools/JSDollarVM.cpp:
+ * yarr/YarrInterpreter.cpp:
+ * yarr/YarrJIT.cpp:
+ * yarr/YarrPattern.cpp:
+ * yarr/YarrUnicodeProperties.cpp:
+
2019-01-28 Yusuke Suzuki <[email protected]>
[JSC] Reduce size of memory used for ShadowChicken
Modified: trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -45,8 +45,6 @@
#include <wtf/Threading.h>
#include <wtf/text/StringBuilder.h>
-using namespace WTF;
-
namespace JSC {
/*
Modified: trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -30,8 +30,6 @@
#include <wtf/PageBlock.h>
#include <wtf/StdLibExtras.h>
-using namespace WTF;
-
namespace JSC {
MachineThreads::MachineThreads()
Modified: trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -82,10 +82,10 @@
#endif
+namespace JSC {
+
using namespace WTF;
-namespace JSC {
-
#if defined(FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB) && FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB > 0
static const size_t fixedExecutableMemoryPoolSize = FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB * 1024 * 1024;
#elif CPU(ARM)
Modified: trunk/Source/_javascript_Core/jsc.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/jsc.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/jsc.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -157,7 +157,6 @@
#endif
using namespace JSC;
-using namespace WTF;
namespace {
Modified: trunk/Source/_javascript_Core/parser/Nodes.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/parser/Nodes.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/parser/Nodes.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -31,8 +31,6 @@
#include "ModuleScopeData.h"
#include <wtf/Assertions.h>
-using namespace WTF;
-
namespace JSC {
// ------------------------------ StatementNode --------------------------------
Modified: trunk/Source/_javascript_Core/runtime/DateConstructor.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/runtime/DateConstructor.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/runtime/DateConstructor.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -43,8 +43,6 @@
#include <sys/timeb.h>
#endif
-using namespace WTF;
-
namespace JSC {
EncodedJSValue JSC_HOST_CALL dateParse(ExecState*);
@@ -56,6 +54,8 @@
namespace JSC {
+using namespace WTF;
+
const ClassInfo DateConstructor::s_info = { "Function", &InternalFunction::s_info, &dateConstructorTable, nullptr, CREATE_METHOD_TABLE(DateConstructor) };
/* Source for DateConstructor.lut.h
Modified: trunk/Source/_javascript_Core/runtime/DateConversion.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/runtime/DateConversion.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/runtime/DateConversion.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -35,10 +35,10 @@
#include <wtf/text/win/WCharStringExtras.h>
#endif
+namespace JSC {
+
using namespace WTF;
-namespace JSC {
-
template<int width>
static inline void appendNumber(StringBuilder& builder, int value)
{
Modified: trunk/Source/_javascript_Core/runtime/DateInstance.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/runtime/DateInstance.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/runtime/DateInstance.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -28,10 +28,10 @@
#include <math.h>
#include <wtf/MathExtras.h>
+namespace JSC {
+
using namespace WTF;
-namespace JSC {
-
const ClassInfo DateInstance::s_info = {"Date", &JSWrapperObject::s_info, nullptr, nullptr, CREATE_METHOD_TABLE(DateInstance)};
DateInstance::DateInstance(VM& vm, Structure* structure)
Modified: trunk/Source/_javascript_Core/runtime/DatePrototype.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/runtime/DatePrototype.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/runtime/DatePrototype.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -67,10 +67,10 @@
#include <CoreFoundation/CoreFoundation.h>
#endif
+namespace JSC {
+
using namespace WTF;
-namespace JSC {
-
EncodedJSValue JSC_HOST_CALL dateProtoFuncGetDate(ExecState*);
EncodedJSValue JSC_HOST_CALL dateProtoFuncGetDay(ExecState*);
EncodedJSValue JSC_HOST_CALL dateProtoFuncGetFullYear(ExecState*);
Modified: trunk/Source/_javascript_Core/runtime/InitializeThreading.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/runtime/InitializeThreading.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/runtime/InitializeThreading.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -49,8 +49,6 @@
#include <wtf/dtoa.h>
#include <wtf/dtoa/cached-powers.h>
-using namespace WTF;
-
namespace JSC {
static_assert(sizeof(bool) == 1, "LLInt and JIT assume sizeof(bool) is always 1 when touching it directly from assembly code.");
Modified: trunk/Source/_javascript_Core/runtime/IteratorOperations.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/runtime/IteratorOperations.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/runtime/IteratorOperations.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -32,8 +32,6 @@
#include "JSCInlines.h"
#include "ObjectConstructor.h"
-using namespace WTF;
-
namespace JSC {
JSValue iteratorNext(ExecState* exec, IterationRecord iterationRecord, JSValue argument)
Modified: trunk/Source/_javascript_Core/runtime/JSDateMath.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/runtime/JSDateMath.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/runtime/JSDateMath.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -98,10 +98,10 @@
#include <sys/timeb.h>
#endif
+namespace JSC {
+
using namespace WTF;
-namespace JSC {
-
static inline double timeToMS(double hour, double min, double sec, double ms)
{
return (((hour * minutesPerHour + min) * secondsPerMinute + sec) * msPerSecond + ms);
Modified: trunk/Source/_javascript_Core/runtime/JSGlobalObjectFunctions.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/runtime/JSGlobalObjectFunctions.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalObjectFunctions.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -57,11 +57,10 @@
#include <wtf/text/StringBuilder.h>
#include <wtf/unicode/UTF8Conversion.h>
-using namespace WTF;
-using namespace Unicode;
-
namespace JSC {
+using namespace WTF::Unicode;
+
const ASCIILiteral ObjectProtoCalledOnNullOrUndefinedError { "Object.prototype.__proto__ called on null or undefined"_s };
template<unsigned charactersCount>
Modified: trunk/Source/_javascript_Core/runtime/StringPrototype.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/runtime/StringPrototype.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/runtime/StringPrototype.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -55,8 +55,6 @@
#include <wtf/text/StringView.h>
#include <wtf/unicode/Collator.h>
-using namespace WTF;
-
namespace JSC {
STATIC_ASSERT_IS_TRIVIALLY_DESTRUCTIBLE(StringPrototype);
Modified: trunk/Source/_javascript_Core/runtime/VM.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/runtime/VM.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/runtime/VM.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -170,8 +170,6 @@
#include "RegExp.h"
#endif
-using namespace WTF;
-
namespace JSC {
#if ENABLE(JIT)
Modified: trunk/Source/_javascript_Core/testRegExp.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/testRegExp.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/testRegExp.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -48,7 +48,6 @@
const int MaxLineLength = 100 * 1024;
using namespace JSC;
-using namespace WTF;
struct CommandLine {
CommandLine()
Modified: trunk/Source/_javascript_Core/tools/JSDollarVM.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/tools/JSDollarVM.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/tools/JSDollarVM.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -57,7 +57,6 @@
#endif
using namespace JSC;
-using namespace WTF;
namespace {
Modified: trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -37,8 +37,6 @@
#include <wtf/text/CString.h>
#include <wtf/text/WTFString.h>
-using namespace WTF;
-
namespace JSC { namespace Yarr {
template<typename CharType>
@@ -1655,7 +1653,7 @@
bool unicode;
unsigned* output;
InputStream input;
- BumpPointerPool* allocatorPool { nullptr };
+ WTF::BumpPointerPool* allocatorPool { nullptr };
unsigned startOffset;
unsigned remainingMatchCount;
};
Modified: trunk/Source/_javascript_Core/yarr/YarrJIT.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/yarr/YarrJIT.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/yarr/YarrJIT.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -36,8 +36,6 @@
#if ENABLE(YARR_JIT)
-using namespace WTF;
-
namespace JSC { namespace Yarr {
template<YarrJITCompileMode compileMode>
Modified: trunk/Source/_javascript_Core/yarr/YarrPattern.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/yarr/YarrPattern.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/yarr/YarrPattern.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -38,8 +38,6 @@
#include <wtf/Vector.h>
#include <wtf/text/WTFString.h>
-using namespace WTF;
-
namespace JSC { namespace Yarr {
#include "RegExpJitTables.h"
Modified: trunk/Source/_javascript_Core/yarr/YarrUnicodeProperties.cpp (240640 => 240641)
--- trunk/Source/_javascript_Core/yarr/YarrUnicodeProperties.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/_javascript_Core/yarr/YarrUnicodeProperties.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -29,8 +29,6 @@
#include "Yarr.h"
#include "YarrPattern.h"
-using namespace WTF;
-
namespace JSC { namespace Yarr {
struct HashIndex {
Modified: trunk/Source/WebCore/ChangeLog (240640 => 240641)
--- trunk/Source/WebCore/ChangeLog 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/ChangeLog 2019-01-29 06:00:30 UTC (rev 240641)
@@ -1,3 +1,45 @@
+2019-01-28 Ross Kirsling <[email protected]>
+
+ Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
+ https://bugs.webkit.org/show_bug.cgi?id=193941
+
+ Reviewed by Alex Christensen.
+
+ * css/CSSBasicShapes.cpp:
+ * css/CSSPrimitiveValue.cpp:
+ * css/parser/CSSParser.cpp:
+ * css/parser/CSSParserSelector.cpp:
+ * css/parser/CSSPropertyParser.cpp:
+ * dom/Document.cpp:
+ * dom/EventListenerMap.cpp:
+ * dom/EventTarget.cpp:
+ * editing/Editor.cpp:
+ * html/HTMLElement.cpp:
+ * html/HTMLFontElement.cpp:
+ * html/parser/HTMLTokenizer.cpp:
+ * html/track/TrackBase.cpp:
+ * loader/FTPDirectoryParser.cpp:
+ * loader/TextResourceDecoder.cpp:
+ * loader/cache/CachedResource.cpp:
+ * page/ContextMenuController.cpp:
+ * page/Navigator.cpp:
+ * platform/Length.cpp:
+ * platform/cocoa/KeyEventCocoa.mm:
+ * platform/graphics/FontCascade.cpp:
+ * platform/graphics/WidthIterator.cpp:
+ * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
+ * platform/ios/KeyEventIOS.mm:
+ * platform/mac/KeyEventMac.mm:
+ * platform/network/HTTPParsers.cpp:
+ * platform/text/TextCodecUTF8.cpp:
+ * platform/text/TextEncodingRegistry.cpp:
+ * platform/win/KeyEventWin.cpp:
+ * rendering/BidiRun.cpp:
+ * rendering/FloatingObjects.cpp:
+ * rendering/RenderBlock.cpp:
+ * rendering/RenderListMarker.cpp:
+ * rendering/RenderText.cpp:
+
2019-01-28 Fujii Hironori <[email protected]>
[Win] WebCore/platform/Process.h is conflicting with process.h
Modified: trunk/Source/WebCore/css/CSSBasicShapes.cpp (240640 => 240641)
--- trunk/Source/WebCore/css/CSSBasicShapes.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/css/CSSBasicShapes.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -28,7 +28,6 @@
*/
#include "config.h"
-
#include "CSSBasicShapes.h"
#include "CSSMarkup.h"
@@ -39,9 +38,7 @@
#include "SVGPathUtilities.h"
#include <wtf/text/StringBuilder.h>
-
namespace WebCore {
-using namespace WTF;
static String serializePositionOffset(const Pair& offset, const Pair& other)
{
@@ -365,7 +362,7 @@
}
if (verticalRadii.size() != horizontalRadii.size()
- || !VectorComparer<false, String>::compare(verticalRadii.data(), horizontalRadii.data(), verticalRadii.size())) {
+ || !WTF::VectorComparer<false, String>::compare(verticalRadii.data(), horizontalRadii.data(), verticalRadii.size())) {
result.appendLiteral(separator);
result.appendLiteral("/");
Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.cpp (240640 => 240641)
--- trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -52,7 +52,6 @@
namespace WebCore {
-using namespace WTF;
static inline bool isValidCSSUnitTypeForDoubleConversion(CSSPrimitiveValue::UnitType unitType)
{
Modified: trunk/Source/WebCore/css/parser/CSSParser.cpp (240640 => 240641)
--- trunk/Source/WebCore/css/parser/CSSParser.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/css/parser/CSSParser.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -54,7 +54,6 @@
#include <wtf/text/StringBuilder.h>
namespace WebCore {
-using namespace WTF;
CSSParser::CSSParser(const CSSParserContext& context)
: m_context(context)
Modified: trunk/Source/WebCore/css/parser/CSSParserSelector.cpp (240640 => 240641)
--- trunk/Source/WebCore/css/parser/CSSParserSelector.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/css/parser/CSSParserSelector.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -32,8 +32,6 @@
namespace WebCore {
-using namespace WTF;
-
CSSParserSelector* CSSParserSelector::parsePagePseudoSelector(const AtomicString& pseudoTypeString)
{
CSSSelector::PagePseudoClassType pseudoType;
Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (240640 => 240641)
--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -82,11 +82,8 @@
#include <memory>
#include <wtf/text/StringBuilder.h>
-
namespace WebCore {
-using namespace WTF;
-
bool isCustomPropertyName(const String& propertyName)
{
return propertyName.length() > 2 && propertyName.characterAt(0) == '-' && propertyName.characterAt(1) == '-';
Modified: trunk/Source/WebCore/dom/Document.cpp (240640 => 240641)
--- trunk/Source/WebCore/dom/Document.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/dom/Document.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -321,17 +321,14 @@
#include "WebMetalRenderingContext.h"
#endif
-
namespace WebCore {
WTF_MAKE_ISO_ALLOCATED_IMPL(Document);
+using namespace HTMLNames;
using namespace PAL;
-using namespace WTF;
-using namespace Unicode;
+using namespace WTF::Unicode;
-using namespace HTMLNames;
-
static const unsigned cMaxWriteRecursionDepth = 21;
bool Document::hasEverCreatedAnAXObjectCache = false;
Modified: trunk/Source/WebCore/dom/EventListenerMap.cpp (240640 => 240641)
--- trunk/Source/WebCore/dom/EventListenerMap.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/dom/EventListenerMap.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -41,7 +41,6 @@
namespace WebCore {
-using namespace WTF;
#ifndef NDEBUG
void EventListenerMap::assertNoActiveIterators() const
Modified: trunk/Source/WebCore/dom/EventTarget.cpp (240640 => 240641)
--- trunk/Source/WebCore/dom/EventTarget.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/dom/EventTarget.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -51,8 +51,6 @@
namespace WebCore {
-using namespace WTF;
-
bool EventTarget::isNode() const
{
return false;
Modified: trunk/Source/WebCore/editing/Editor.cpp (240640 => 240641)
--- trunk/Source/WebCore/editing/Editor.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/editing/Editor.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -200,8 +200,7 @@
}
using namespace HTMLNames;
-using namespace WTF;
-using namespace Unicode;
+using namespace WTF::Unicode;
TemporarySelectionChange::TemporarySelectionChange(Frame& frame, Optional<VisibleSelection> temporarySelection, OptionSet<TemporarySelectionOption> options)
: m_frame(frame)
Modified: trunk/Source/WebCore/html/HTMLElement.cpp (240640 => 240641)
--- trunk/Source/WebCore/html/HTMLElement.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/html/HTMLElement.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -76,7 +76,6 @@
WTF_MAKE_ISO_ALLOCATED_IMPL(HTMLElement);
using namespace HTMLNames;
-using namespace WTF;
Ref<HTMLElement> HTMLElement::create(const QualifiedName& tagName, Document& document)
{
Modified: trunk/Source/WebCore/html/HTMLFontElement.cpp (240640 => 240641)
--- trunk/Source/WebCore/html/HTMLFontElement.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/html/HTMLFontElement.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -39,7 +39,6 @@
WTF_MAKE_ISO_ALLOCATED_IMPL(HTMLFontElement);
using namespace HTMLNames;
-using namespace WTF;
HTMLFontElement::HTMLFontElement(const QualifiedName& tagName, Document& document)
: HTMLElement(tagName, document)
Modified: trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp (240640 => 240641)
--- trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -35,7 +35,6 @@
namespace WebCore {
-using namespace WTF;
using namespace HTMLNames;
Modified: trunk/Source/WebCore/html/track/TrackBase.cpp (240640 => 240641)
--- trunk/Source/WebCore/html/track/TrackBase.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/html/track/TrackBase.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -35,7 +35,6 @@
#include "HTMLMediaElement.h"
namespace WebCore {
-using namespace WTF;
static int s_uniqueId = 0;
Modified: trunk/Source/WebCore/loader/FTPDirectoryParser.cpp (240640 => 240641)
--- trunk/Source/WebCore/loader/FTPDirectoryParser.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/loader/FTPDirectoryParser.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -34,7 +34,7 @@
namespace WebCore {
-using namespace WTF;
+
#if OS(WINDOWS) && !defined(gmtime_r)
#define gmtime_r(x, y) gmtime_s((y), (x))
#endif
Modified: trunk/Source/WebCore/loader/TextResourceDecoder.cpp (240640 => 240641)
--- trunk/Source/WebCore/loader/TextResourceDecoder.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/loader/TextResourceDecoder.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -34,7 +34,6 @@
namespace WebCore {
-using namespace WTF;
using namespace HTMLNames;
Modified: trunk/Source/WebCore/loader/cache/CachedResource.cpp (240640 => 240641)
--- trunk/Source/WebCore/loader/cache/CachedResource.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/loader/cache/CachedResource.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -60,11 +60,9 @@
#include "QuickLook.h"
#endif
-
#define RELEASE_LOG_IF_ALLOWED(fmt, ...) RELEASE_LOG_IF(cachedResourceLoader.isAlwaysOnLoggingAllowed(), Network, "%p - CachedResource::" fmt, this, ##__VA_ARGS__)
namespace WebCore {
-using namespace WTF;
ResourceLoadPriority CachedResource::defaultPriorityForResourceType(Type type)
{
@@ -115,7 +113,7 @@
return MemoryCache::singleton().deadDecodedDataDeletionInterval();
}
-DEFINE_DEBUG_ONLY_GLOBAL(RefCountedLeakCounter, cachedResourceLeakCounter, ("CachedResource"));
+DEFINE_DEBUG_ONLY_GLOBAL(WTF::RefCountedLeakCounter, cachedResourceLeakCounter, ("CachedResource"));
CachedResource::CachedResource(CachedResourceRequest&& request, Type type, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
: m_options(request.options())
Modified: trunk/Source/WebCore/page/ContextMenuController.cpp (240640 => 240641)
--- trunk/Source/WebCore/page/ContextMenuController.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/page/ContextMenuController.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -73,9 +73,9 @@
namespace WebCore {
-using namespace WTF;
-using namespace Unicode;
+using namespace WTF::Unicode;
+
ContextMenuController::ContextMenuController(Page& page, ContextMenuClient& client)
: m_page(page)
, m_client(client)
Modified: trunk/Source/WebCore/page/Navigator.cpp (240640 => 240641)
--- trunk/Source/WebCore/page/Navigator.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/page/Navigator.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -47,7 +47,6 @@
#include <wtf/WeakPtr.h>
namespace WebCore {
-using namespace WTF;
Navigator::Navigator(ScriptExecutionContext* context, DOMWindow& window)
: NavigatorBase(context)
Modified: trunk/Source/WebCore/platform/Length.cpp (240640 => 240641)
--- trunk/Source/WebCore/platform/Length.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/platform/Length.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -37,7 +37,6 @@
namespace WebCore {
-using namespace WTF;
static Length parseLength(const UChar* data, unsigned length)
{
Modified: trunk/Source/WebCore/platform/cocoa/KeyEventCocoa.mm (240640 => 240641)
--- trunk/Source/WebCore/platform/cocoa/KeyEventCocoa.mm 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/platform/cocoa/KeyEventCocoa.mm 2019-01-29 06:00:30 UTC (rev 240641)
@@ -37,8 +37,6 @@
#import "KeyEventCodesIOS.h"
#endif
-using namespace WTF;
-
namespace WebCore {
bool PlatformKeyboardEvent::currentCapsLockState()
Modified: trunk/Source/WebCore/platform/graphics/FontCascade.cpp (240640 => 240641)
--- trunk/Source/WebCore/platform/graphics/FontCascade.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/platform/graphics/FontCascade.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -46,9 +46,9 @@
#endif
namespace WebCore {
-using namespace WTF;
-using namespace Unicode;
+using namespace WTF::Unicode;
+
static bool useBackslashAsYenSignForFamily(const AtomicString& family)
{
if (family.isEmpty())
Modified: trunk/Source/WebCore/platform/graphics/WidthIterator.cpp (240640 => 240641)
--- trunk/Source/WebCore/platform/graphics/WidthIterator.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/platform/graphics/WidthIterator.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -32,9 +32,9 @@
namespace WebCore {
-using namespace WTF;
-using namespace Unicode;
+using namespace WTF::Unicode;
+
WidthIterator::WidthIterator(const FontCascade* font, const TextRun& run, HashSet<const Font*>* fallbackFonts, bool accountForGlyphBounds, bool forTextEmphasis)
: m_font(font)
, m_run(run)
Modified: trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp (240640 => 240641)
--- trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -88,7 +88,6 @@
namespace WebCore {
-using namespace WTF;
static ThreadSpecific<ShaderNameHash*>& getCurrentNameHashMapForShader()
{
Modified: trunk/Source/WebCore/platform/ios/KeyEventIOS.mm (240640 => 240641)
--- trunk/Source/WebCore/platform/ios/KeyEventIOS.mm 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/platform/ios/KeyEventIOS.mm 2019-01-29 06:00:30 UTC (rev 240641)
@@ -36,8 +36,6 @@
#import <pal/spi/cocoa/IOKitSPI.h>
#import <wtf/MainThread.h>
-using namespace WTF;
-
namespace WebCore {
int windowsKeyCodeForKeyCode(uint16_t keyCode)
Modified: trunk/Source/WebCore/platform/mac/KeyEventMac.mm (240640 => 240641)
--- trunk/Source/WebCore/platform/mac/KeyEventMac.mm 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/platform/mac/KeyEventMac.mm 2019-01-29 06:00:30 UTC (rev 240641)
@@ -35,7 +35,6 @@
#import <wtf/MainThread.h>
namespace WebCore {
-using namespace WTF;
int windowsKeyCodeForKeyCode(uint16_t keyCode)
{
Modified: trunk/Source/WebCore/platform/network/HTTPParsers.cpp (240640 => 240641)
--- trunk/Source/WebCore/platform/network/HTTPParsers.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/platform/network/HTTPParsers.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -44,7 +44,6 @@
namespace WebCore {
-using namespace WTF;
// true if there is more to parse, after incrementing pos past whitespace.
// Note: Might return pos == str.length()
Modified: trunk/Source/WebCore/platform/text/TextCodecUTF8.cpp (240640 => 240641)
--- trunk/Source/WebCore/platform/text/TextCodecUTF8.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/platform/text/TextCodecUTF8.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -33,7 +33,7 @@
#include <wtf/unicode/CharacterNames.h>
namespace WebCore {
-using namespace WTF;
+
using namespace WTF::Unicode;
const int nonCharacter = -1;
Modified: trunk/Source/WebCore/platform/text/TextEncodingRegistry.cpp (240640 => 240641)
--- trunk/Source/WebCore/platform/text/TextEncodingRegistry.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/platform/text/TextEncodingRegistry.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -45,7 +45,6 @@
#include <wtf/text/CString.h>
namespace WebCore {
-using namespace WTF;
const size_t maxEncodingNameLength = 63;
Modified: trunk/Source/WebCore/platform/win/KeyEventWin.cpp (240640 => 240641)
--- trunk/Source/WebCore/platform/win/KeyEventWin.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/platform/win/KeyEventWin.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -33,9 +33,7 @@
#define MAPVK_VSC_TO_VK_EX 3
#endif
-
namespace WebCore {
-using namespace WTF;
static const unsigned short HIGH_BIT_MASK_SHORT = 0x8000;
Modified: trunk/Source/WebCore/rendering/BidiRun.cpp (240640 => 240641)
--- trunk/Source/WebCore/rendering/BidiRun.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/rendering/BidiRun.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -27,11 +27,9 @@
#include <wtf/RefCountedLeakCounter.h>
#include <wtf/StdLibExtras.h>
-
namespace WebCore {
-using namespace WTF;
-DEFINE_DEBUG_ONLY_GLOBAL(RefCountedLeakCounter, bidiRunCounter, ("BidiRun"));
+DEFINE_DEBUG_ONLY_GLOBAL(WTF::RefCountedLeakCounter, bidiRunCounter, ("BidiRun"));
BidiRun::BidiRun(unsigned start, unsigned stop, RenderObject& renderer, BidiContext* context, UCharDirection dir)
: BidiCharacterRun(start, stop, context, dir)
Modified: trunk/Source/WebCore/rendering/FloatingObjects.cpp (240640 => 240641)
--- trunk/Source/WebCore/rendering/FloatingObjects.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/rendering/FloatingObjects.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -28,9 +28,7 @@
#include "RenderBox.h"
#include "RenderView.h"
-
namespace WebCore {
-using namespace WTF;
struct SameSizeAsFloatingObject {
void* pointers[2];
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (240640 => 240641)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -71,7 +71,6 @@
#include "ShadowRoot.h"
#include "ShapeOutsideInfo.h"
#include "TransformState.h"
-
#include <wtf/IsoMallocInlines.h>
#include <wtf/NeverDestroyed.h>
#include <wtf/Optional.h>
@@ -78,12 +77,10 @@
#include <wtf/SetForScope.h>
#include <wtf/StackStats.h>
-
namespace WebCore {
-using namespace WTF;
-using namespace Unicode;
using namespace HTMLNames;
+using namespace WTF::Unicode;
WTF_MAKE_ISO_ALLOCATED_IMPL(RenderBlock);
Modified: trunk/Source/WebCore/rendering/RenderListMarker.cpp (240640 => 240641)
--- trunk/Source/WebCore/rendering/RenderListMarker.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/rendering/RenderListMarker.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -37,11 +37,10 @@
#include <wtf/text/StringBuilder.h>
#include <wtf/unicode/CharacterNames.h>
-
namespace WebCore {
-using namespace WTF;
-using namespace Unicode;
+using namespace WTF::Unicode;
+
WTF_MAKE_ISO_ALLOCATED_IMPL(RenderListMarker);
const int cMarkerPadding = 7;
Modified: trunk/Source/WebCore/rendering/RenderText.cpp (240640 => 240641)
--- trunk/Source/WebCore/rendering/RenderText.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebCore/rendering/RenderText.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -64,11 +64,10 @@
#include "SelectionRect.h"
#endif
-
namespace WebCore {
-using namespace WTF;
-using namespace Unicode;
+using namespace WTF::Unicode;
+
WTF_MAKE_ISO_ALLOCATED_IMPL(RenderText);
struct SameSizeAsRenderText : public RenderObject {
Modified: trunk/Source/WebKit/ChangeLog (240640 => 240641)
--- trunk/Source/WebKit/ChangeLog 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebKit/ChangeLog 2019-01-29 06:00:30 UTC (rev 240641)
@@ -1,3 +1,12 @@
+2019-01-28 Ross Kirsling <[email protected]>
+
+ Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
+ https://bugs.webkit.org/show_bug.cgi?id=193941
+
+ Reviewed by Alex Christensen.
+
+ * Shared/linux/WebMemorySamplerLinux.cpp:
+
2019-01-28 Fujii Hironori <[email protected]>
[Win] WebCore/platform/Process.h is conflicting with process.h
Modified: trunk/Source/WebKit/Shared/linux/WebMemorySamplerLinux.cpp (240640 => 240641)
--- trunk/Source/WebKit/Shared/linux/WebMemorySamplerLinux.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebKit/Shared/linux/WebMemorySamplerLinux.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -41,9 +41,9 @@
#include <wtf/text/WTFString.h>
namespace WebKit {
+
+using namespace JSC;
using namespace WebCore;
-using namespace JSC;
-using namespace WTF;
static const unsigned int maxBuffer = 128;
static const unsigned int maxProcessPath = 35;
@@ -113,7 +113,7 @@
size_t totalBytesInUse = 0;
size_t totalBytesCommitted = 0;
- FastMallocStatistics fastMallocStatistics = WTF::fastMallocStatistics();
+ auto fastMallocStatistics = WTF::fastMallocStatistics();
size_t fastMallocBytesInUse = fastMallocStatistics.committedVMBytes - fastMallocStatistics.freeListBytes;
size_t fastMallocBytesCommitted = fastMallocStatistics.committedVMBytes;
totalBytesInUse += fastMallocBytesInUse;
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (240640 => 240641)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2019-01-29 06:00:30 UTC (rev 240641)
@@ -1,3 +1,14 @@
+2019-01-28 Ross Kirsling <[email protected]>
+
+ Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
+ https://bugs.webkit.org/show_bug.cgi?id=193941
+
+ Reviewed by Alex Christensen.
+
+ * Plugins/PluginMessageThrottlerWin.cpp:
+ * Plugins/PluginView.cpp:
+ * Plugins/PluginViewWin.cpp:
+
2019-01-24 Ross Kirsling <[email protected]>
Move FileSystem to WTF
Modified: trunk/Source/WebKitLegacy/win/Plugins/PluginMessageThrottlerWin.cpp (240640 => 240641)
--- trunk/Source/WebKitLegacy/win/Plugins/PluginMessageThrottlerWin.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebKitLegacy/win/Plugins/PluginMessageThrottlerWin.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -30,8 +30,6 @@
#include <wtf/ASCIICType.h>
#include <wtf/MonotonicTime.h>
-using namespace WTF;
-
namespace WebCore {
// Set a timer to make sure we process any queued messages at least every 16ms.
Modified: trunk/Source/WebKitLegacy/win/Plugins/PluginView.cpp (240640 => 240641)
--- trunk/Source/WebKitLegacy/win/Plugins/PluginView.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebKitLegacy/win/Plugins/PluginView.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -88,8 +88,6 @@
#if ENABLE(NETSCAPE_PLUGIN_API)
-using namespace WTF;
-
namespace WebCore {
using namespace HTMLNames;
Modified: trunk/Source/WebKitLegacy/win/Plugins/PluginViewWin.cpp (240640 => 240641)
--- trunk/Source/WebKitLegacy/win/Plugins/PluginViewWin.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Source/WebKitLegacy/win/Plugins/PluginViewWin.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -84,16 +84,10 @@
return client;
}
-using JSC::ExecState;
+namespace WebCore {
+
using JSC::JSLock;
-using JSC::JSObject;
-using std::min;
-
-using namespace WTF;
-
-namespace WebCore {
-
using namespace HTMLNames;
const LPCWSTR kWebPluginViewClassName = L"WebPluginView";
Modified: trunk/Tools/ChangeLog (240640 => 240641)
--- trunk/Tools/ChangeLog 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Tools/ChangeLog 2019-01-29 06:00:30 UTC (rev 240641)
@@ -1,3 +1,23 @@
+2019-01-28 Ross Kirsling <[email protected]>
+
+ Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
+ https://bugs.webkit.org/show_bug.cgi?id=193941
+
+ Reviewed by Alex Christensen.
+
+ * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
+ * TestWebKitAPI/Tests/WTF/Condition.cpp:
+ * TestWebKitAPI/Tests/WTF/Lock.cpp:
+ * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
+ * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
+ * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
+ * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
+ * TestWebKitAPI/Tests/WTF/Time.cpp:
+ * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
+ * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
+ * TestWebKitAPI/Tests/WebCore/Logging.cpp:
+ * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
+
2019-01-28 Yusuke Suzuki <[email protected]>
Unreviewed, reorder my emails to fix autocomplete in bugzilla
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp (240640 => 240641)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -26,8 +26,6 @@
#include "config.h"
#include <wtf/ConcurrentPtrHashSet.h>
-using namespace WTF;
-
namespace TestWebKitAPI {
namespace {
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Condition.cpp (240640 => 240641)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/Condition.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/Condition.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -34,8 +34,6 @@
#include <wtf/Threading.h>
#include <wtf/Vector.h>
-using namespace WTF;
-
namespace TestWebKitAPI {
namespace {
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Lock.cpp (240640 => 240641)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/Lock.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/Lock.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -29,8 +29,6 @@
#include <wtf/ThreadingPrimitives.h>
#include <wtf/WordLock.h>
-using namespace WTF;
-
namespace TestWebKitAPI {
struct LockInspector {
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/MetaAllocator.cpp (240640 => 240641)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/MetaAllocator.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/MetaAllocator.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -35,10 +35,10 @@
#undef small
#endif
+namespace TestWebKitAPI {
+
using namespace WTF;
-namespace TestWebKitAPI {
-
class MetaAllocatorTest: public testing::Test {
public:
enum SanityCheckMode { RunSanityCheck, DontRunSanityCheck };
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/ParkingLot.cpp (240640 => 240641)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/ParkingLot.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/ParkingLot.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -34,8 +34,6 @@
#include <wtf/Threading.h>
#include <wtf/ThreadingPrimitives.h>
-using namespace WTF;
-
namespace TestWebKitAPI {
namespace {
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/RedBlackTree.cpp (240640 => 240641)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/RedBlackTree.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/RedBlackTree.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -30,10 +30,10 @@
#include <wtf/RedBlackTree.h>
#include <wtf/Vector.h>
+namespace TestWebKitAPI {
+
using namespace WTF;
-namespace TestWebKitAPI {
-
class TestNode : public RedBlackTree<TestNode, char>::Node {
public:
TestNode(char key, unsigned value)
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/ScopedLambda.cpp (240640 => 240641)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/ScopedLambda.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/ScopedLambda.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -27,8 +27,6 @@
#include <wtf/ScopedLambda.h>
#include <wtf/Vector.h>
-using namespace WTF;
-
namespace TestWebKitAPI {
// This test relies on this module being compiled with -fno-elide-constructors
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Time.cpp (240640 => 240641)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/Time.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/Time.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -59,8 +59,6 @@
} // namespace WTF
-using namespace WTF;
-
namespace TestWebKitAPI {
namespace {
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/UniqueArray.cpp (240640 => 240641)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/UniqueArray.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/UniqueArray.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -26,8 +26,6 @@
#include "config.h"
#include <wtf/UniqueArray.h>
-using namespace WTF;
-
namespace TestWebKitAPI {
static unsigned numberOfConstructions { 0 };
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp (240640 => 240641)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -31,7 +31,6 @@
#include <WebCore/ApplicationManifestParser.h>
#include <wtf/RunLoop.h>
-using namespace WTF;
using namespace WebCore;
namespace WebCore {
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/Logging.cpp (240640 => 240641)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/Logging.cpp 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/Logging.cpp 2019-01-29 06:00:30 UTC (rev 240641)
@@ -31,8 +31,6 @@
#define LOG_CHANNEL_PREFIX Test
-using namespace WTF;
-
const char* logTestingSubsystem = "com.webkit.testing";
DEFINE_LOG_CHANNEL(Channel1, logTestingSubsystem);
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm (240640 => 240641)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm 2019-01-29 05:58:00 UTC (rev 240640)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm 2019-01-29 06:00:30 UTC (rev 240641)
@@ -35,8 +35,6 @@
namespace WTR {
-using namespace WTF;
-
void InjectedBundlePage::platformDidStartProvisionalLoadForFrame(WKBundleFrameRef frame)
{
if (!WKBundleFrameIsMainFrame(frame))
