Title: [240653] trunk/Source/WebCore
- Revision
- 240653
- Author
- [email protected]
- Date
- 2019-01-29 06:53:03 -0800 (Tue, 29 Jan 2019)
Log Message
[LFC][BFC][MarginCollapsing] Remove quirk from MarginCollapse::marginsCollapseThrough
https://bugs.webkit.org/show_bug.cgi?id=193948
Reviewed by Antti Koivisto.
This is now implemented in BlockFormattingContext::Quirks::stretchedInFlowHeight().
* layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (240652 => 240653)
--- trunk/Source/WebCore/ChangeLog 2019-01-29 14:50:43 UTC (rev 240652)
+++ trunk/Source/WebCore/ChangeLog 2019-01-29 14:53:03 UTC (rev 240653)
@@ -1,5 +1,17 @@
2019-01-29 Zalan Bujtas <[email protected]>
+ [LFC][BFC][MarginCollapsing] Remove quirk from MarginCollapse::marginsCollapseThrough
+ https://bugs.webkit.org/show_bug.cgi?id=193948
+
+ Reviewed by Antti Koivisto.
+
+ This is now implemented in BlockFormattingContext::Quirks::stretchedInFlowHeight().
+
+ * layout/blockformatting/BlockMarginCollapse.cpp:
+ (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough):
+
+2019-01-29 Zalan Bujtas <[email protected]>
+
[LFC][BFC][MarginCollapsing] Anonymous block container's margin before does not collapse with previous inflow sibling margin after.
https://bugs.webkit.org/show_bug.cgi?id=193952
Modified: trunk/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp (240652 => 240653)
--- trunk/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp 2019-01-29 14:50:43 UTC (rev 240652)
+++ trunk/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp 2019-01-29 14:53:03 UTC (rev 240653)
@@ -398,9 +398,6 @@
if (!downcast<Container>(layoutBox).hasInFlowChild())
return !establishesBlockFormattingContext(layoutBox);
- if (Quirks::needsStretching(layoutState, layoutBox))
- return false;
-
if (layoutBox.establishesFormattingContext()) {
if (layoutBox.establishesInlineFormattingContext()) {
// If we get here through margin estimation, we don't necessarily have an actual state for this layout box since
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
