Title: [240729] trunk/Source/WebKit
- Revision
- 240729
- Author
- [email protected]
- Date
- 2019-01-30 13:46:52 -0800 (Wed, 30 Jan 2019)
Log Message
Ensure image picker sourceType is set before cameraDevice
https://bugs.webkit.org/show_bug.cgi?id=193998
Reviewed by Beth Dakin.
* UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel _showPhotoPickerWithSourceType:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (240728 => 240729)
--- trunk/Source/WebKit/ChangeLog 2019-01-30 21:33:17 UTC (rev 240728)
+++ trunk/Source/WebKit/ChangeLog 2019-01-30 21:46:52 UTC (rev 240729)
@@ -1,3 +1,13 @@
+2019-01-29 Conrad Shultz <[email protected]>
+
+ Ensure image picker sourceType is set before cameraDevice
+ https://bugs.webkit.org/show_bug.cgi?id=193998
+
+ Reviewed by Beth Dakin.
+
+ * UIProcess/ios/forms/WKFileUploadPanel.mm:
+ (-[WKFileUploadPanel _showPhotoPickerWithSourceType:]):
+
2019-01-30 Chris Dumez <[email protected]>
Regression(PSON) Load hang can occur on history navigation
Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm (240728 => 240729)
--- trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm 2019-01-30 21:33:17 UTC (rev 240728)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm 2019-01-30 21:46:52 UTC (rev 240729)
@@ -415,10 +415,10 @@
ASSERT([UIImagePickerController isSourceTypeAvailable:sourceType]);
_imagePicker = adoptNS([[UIImagePickerController alloc] init]);
- [self _configureImagePicker:_imagePicker.get()];
[_imagePicker setSourceType:sourceType];
[_imagePicker setMediaTypes:[self _mediaTypesForPickerSourceType:sourceType]];
-
+ [self _configureImagePicker:_imagePicker.get()];
+
// Use a popover on the iPad if the source type is not the camera.
// The camera will use a fullscreen, modal view controller.
BOOL usePopover = currentUserInterfaceIdiomIsPad() && sourceType != UIImagePickerControllerSourceTypeCamera;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
