Title: [240744] trunk/Source/WebCore
- Revision
- 240744
- Author
- krol...@apple.com
- Date
- 2019-01-30 17:35:26 -0800 (Wed, 30 Jan 2019)
Log Message
FloatWithRect has invalid and inaccessible default constructor
https://bugs.webkit.org/show_bug.cgi?id=194057
<rdar://problem/47685211>
Reviewed by Zalan Bujtas.
FloatWithRect has a default constructor declared as 'default'. This
constructor is invalid because FloatWithRect has a data member that's
a reference that will not get initialized with this constructor. Since
it's invalid, and since it's private and not accessed by anything,
remove this constructor.
No new tests since there should be no observable behavior difference.
* rendering/line/LineLayoutState.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (240743 => 240744)
--- trunk/Source/WebCore/ChangeLog 2019-01-31 00:56:56 UTC (rev 240743)
+++ trunk/Source/WebCore/ChangeLog 2019-01-31 01:35:26 UTC (rev 240744)
@@ -1,3 +1,21 @@
+2019-01-30 Keith Rollin <krol...@apple.com>
+
+ FloatWithRect has invalid and inaccessible default constructor
+ https://bugs.webkit.org/show_bug.cgi?id=194057
+ <rdar://problem/47685211>
+
+ Reviewed by Zalan Bujtas.
+
+ FloatWithRect has a default constructor declared as 'default'. This
+ constructor is invalid because FloatWithRect has a data member that's
+ a reference that will not get initialized with this constructor. Since
+ it's invalid, and since it's private and not accessed by anything,
+ remove this constructor.
+
+ No new tests since there should be no observable behavior difference.
+
+ * rendering/line/LineLayoutState.h:
+
2019-01-30 Daniel Bates <daba...@apple.com>
[iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
Modified: trunk/Source/WebCore/rendering/line/LineLayoutState.h (240743 => 240744)
--- trunk/Source/WebCore/rendering/line/LineLayoutState.h 2019-01-31 00:56:56 UTC (rev 240743)
+++ trunk/Source/WebCore/rendering/line/LineLayoutState.h 2019-01-31 01:35:26 UTC (rev 240744)
@@ -54,8 +54,6 @@
void adjustRect(const LayoutRect& rect) { m_rect = rect; }
private:
- FloatWithRect() = default;
-
FloatWithRect(RenderBox& renderer)
: m_renderer(renderer)
, m_rect(LayoutRect(renderer.x() - renderer.marginLeft(), renderer.y() - renderer.marginTop(), renderer.width() + renderer.horizontalMarginExtent(), renderer.height() + renderer.verticalMarginExtent()))
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
