Title: [240809] trunk/Source/WebKit
- Revision
- 240809
- Author
- [email protected]
- Date
- 2019-01-31 13:34:34 -0800 (Thu, 31 Jan 2019)
Log Message
Remove WKPageIsWebProcessResponsive
https://bugs.webkit.org/show_bug.cgi?id=194096
Reviewed by Alex Christensen.
It is not used by any client.
It is also bad API. It is better to let WebKit track
responsiveness and tell the client with processDidBecomeResponsive.
* UIProcess/API/C/WKPage.cpp:
(WKPageIsWebProcessResponsive): Deleted.
* UIProcess/API/C/WKPagePrivate.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::isWebProcessResponsive): Deleted.
* UIProcess/WebPageProxy.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (240808 => 240809)
--- trunk/Source/WebKit/ChangeLog 2019-01-31 21:23:44 UTC (rev 240808)
+++ trunk/Source/WebKit/ChangeLog 2019-01-31 21:34:34 UTC (rev 240809)
@@ -1,3 +1,22 @@
+2019-01-31 Benjamin Poulain <[email protected]>
+
+ Remove WKPageIsWebProcessResponsive
+ https://bugs.webkit.org/show_bug.cgi?id=194096
+
+ Reviewed by Alex Christensen.
+
+ It is not used by any client.
+
+ It is also bad API. It is better to let WebKit track
+ responsiveness and tell the client with processDidBecomeResponsive.
+
+ * UIProcess/API/C/WKPage.cpp:
+ (WKPageIsWebProcessResponsive): Deleted.
+ * UIProcess/API/C/WKPagePrivate.h:
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::isWebProcessResponsive): Deleted.
+ * UIProcess/WebPageProxy.h:
+
2019-01-31 Alex Christensen <[email protected]>
Revert r238819 which is unneeded and caused a performance regression.
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp (240808 => 240809)
--- trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp 2019-01-31 21:23:44 UTC (rev 240808)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp 2019-01-31 21:34:34 UTC (rev 240809)
@@ -2327,13 +2327,6 @@
toImpl(pageRef)->getSamplingProfilerOutput(toGenericCallbackFunction(context, callback));
}
-void WKPageIsWebProcessResponsive(WKPageRef pageRef, void* context, WKPageIsWebProcessResponsiveFunction callback)
-{
- toImpl(pageRef)->isWebProcessResponsive([context, callback](bool isWebProcessResponsive) {
- callback(isWebProcessResponsive, context);
- });
-}
-
void WKPageGetSelectionAsWebArchiveData(WKPageRef pageRef, void* context, WKPageGetSelectionAsWebArchiveDataFunction callback)
{
toImpl(pageRef)->getSelectionAsWebArchiveData(toGenericCallbackFunction(context, callback));
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPagePrivate.h (240808 => 240809)
--- trunk/Source/WebKit/UIProcess/API/C/WKPagePrivate.h 2019-01-31 21:23:44 UTC (rev 240808)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPagePrivate.h 2019-01-31 21:34:34 UTC (rev 240809)
@@ -103,9 +103,6 @@
typedef void (*WKPageGetSamplingProfilerOutputFunction)(WKStringRef, WKErrorRef, void*);
WK_EXPORT void WKPageGetSamplingProfilerOutput(WKPageRef page, void* context, WKPageGetSamplingProfilerOutputFunction function);
-typedef void (*WKPageIsWebProcessResponsiveFunction)(bool isWebProcessResponsive, void* context);
-WK_EXPORT void WKPageIsWebProcessResponsive(WKPageRef page, void* context, WKPageIsWebProcessResponsiveFunction function);
-
WK_EXPORT WKArrayRef WKPageCopyRelatedPages(WKPageRef page);
WK_EXPORT WKFrameRef WKPageLookUpFrameFromHandle(WKPageRef page, WKFrameHandleRef handle);
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (240808 => 240809)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-01-31 21:23:44 UTC (rev 240808)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-01-31 21:34:34 UTC (rev 240809)
@@ -3538,19 +3538,6 @@
m_process->send(Messages::WebPage::GetSamplingProfilerOutput(callbackID), m_pageID);
}
-void WebPageProxy::isWebProcessResponsive(WTF::Function<void (bool isWebProcessResponsive)>&& callbackFunction)
-{
- if (!isValid()) {
- RunLoop::main().dispatch([callbackFunction = WTFMove(callbackFunction)] {
- bool isWebProcessResponsive = true;
- callbackFunction(isWebProcessResponsive);
- });
- return;
- }
-
- m_process->isResponsive(WTFMove(callbackFunction));
-}
-
#if ENABLE(MHTML)
void WebPageProxy::getContentsAsMHTMLData(Function<void (API::Data*, CallbackBase::Error)>&& callbackFunction)
{
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.h (240808 => 240809)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.h 2019-01-31 21:23:44 UTC (rev 240808)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.h 2019-01-31 21:34:34 UTC (rev 240809)
@@ -945,7 +945,6 @@
void getContentsAsString(WTF::Function<void (const String&, CallbackBase::Error)>&&);
void getBytecodeProfile(WTF::Function<void (const String&, CallbackBase::Error)>&&);
void getSamplingProfilerOutput(WTF::Function<void (const String&, CallbackBase::Error)>&&);
- void isWebProcessResponsive(WTF::Function<void (bool isWebProcessResponsive)>&&);
#if ENABLE(MHTML)
void getContentsAsMHTMLData(Function<void (API::Data*, CallbackBase::Error)>&&);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
