Title: [240819] trunk/Source/WebInspectorUI
- Revision
- 240819
- Author
- [email protected]
- Date
- 2019-01-31 14:17:49 -0800 (Thu, 31 Jan 2019)
Log Message
REGRESSION(r?): Web Inspector: Clicking on text doesn't move text caret when editing innerHTML/tagName/attribute
https://bugs.webkit.org/show_bug.cgi?id=192652
<rdar://problem/46684612>
Reviewed by Devin Rousso.
* UserInterface/Views/DOMTreeElement.js:
(WI.DOMTreeElement.prototype.canSelectOnMouseDown):
Call to Event.preventDefault() should be made here instead of at the
TreeOutline level.
* UserInterface/Views/TreeElement.js:
(WI.TreeElement.prototype.selectOnMouseDown): Deleted.
Remove dead code.
* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline._handleMouseDown):
Do not prevent default event handling when the item cannot be selected.
This matches TreeOutline behavior prior to introducing SelectionController.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (240818 => 240819)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-01-31 22:14:17 UTC (rev 240818)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-01-31 22:17:49 UTC (rev 240819)
@@ -1,3 +1,25 @@
+2019-01-31 Matt Baker <[email protected]>
+
+ REGRESSION(r?): Web Inspector: Clicking on text doesn't move text caret when editing innerHTML/tagName/attribute
+ https://bugs.webkit.org/show_bug.cgi?id=192652
+ <rdar://problem/46684612>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/DOMTreeElement.js:
+ (WI.DOMTreeElement.prototype.canSelectOnMouseDown):
+ Call to Event.preventDefault() should be made here instead of at the
+ TreeOutline level.
+
+ * UserInterface/Views/TreeElement.js:
+ (WI.TreeElement.prototype.selectOnMouseDown): Deleted.
+ Remove dead code.
+
+ * UserInterface/Views/TreeOutline.js:
+ (WI.TreeOutline._handleMouseDown):
+ Do not prevent default event handling when the item cannot be selected.
+ This matches TreeOutline behavior prior to introducing SelectionController.
+
2019-01-30 Devin Rousso <[email protected]>
Web Inspector: Memory Timeline View should be responsive / resizable
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js (240818 => 240819)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2019-01-31 22:14:17 UTC (rev 240818)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2019-01-31 22:17:49 UTC (rev 240819)
@@ -646,8 +646,10 @@
return false;
// Prevent selecting the nearest word on double click.
- if (event.detail >= 2)
+ if (event.detail >= 2) {
+ event.preventDefault();
return false;
+ }
return true;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js (240818 => 240819)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js 2019-01-31 22:14:17 UTC (rev 240818)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js 2019-01-31 22:17:49 UTC (rev 240819)
@@ -490,14 +490,6 @@
return true;
}
- selectOnMouseDown(event)
- {
- if (!this.treeOutline.selectable)
- return;
-
- this.select(false, true);
- }
-
select(omitFocus, selectedByUser, suppressNotification)
{
if (!this.treeOutline || !this.selectable)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (240818 => 240819)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2019-01-31 22:14:17 UTC (rev 240818)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2019-01-31 22:17:49 UTC (rev 240819)
@@ -1012,10 +1012,8 @@
return;
}
- if (!treeElement.canSelectOnMouseDown(event)) {
- event.preventDefault();
+ if (!treeElement.canSelectOnMouseDown(event))
return;
- }
let index = this._indexOfTreeElement(treeElement);
if (isNaN(index))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
