Title: [240821] trunk/Source/_javascript_Core
- Revision
- 240821
- Author
- [email protected]
- Date
- 2019-01-31 14:21:57 -0800 (Thu, 31 Jan 2019)
Log Message
Fix `runJITThreadLimitTests` in testapi
https://bugs.webkit.org/show_bug.cgi?id=194064
<rdar://problem/46139147>
Reviewed by Mark Lam.
Fix typo where `targetNumberOfThreads` was not being used.
* API/tests/testapi.mm:
(runJITThreadLimitTests):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/tests/testapi.mm (240820 => 240821)
--- trunk/Source/_javascript_Core/API/tests/testapi.mm 2019-01-31 22:19:52 UTC (rev 240820)
+++ trunk/Source/_javascript_Core/API/tests/testapi.mm 2019-01-31 22:21:57 UTC (rev 240821)
@@ -529,7 +529,7 @@
auto testDFG = [] {
unsigned defaultNumberOfThreads = JSC::Options::numberOfDFGCompilerThreads();
unsigned targetNumberOfThreads = 1;
- unsigned initialNumberOfThreads = [JSVirtualMachine setNumberOfDFGCompilerThreads:1];
+ unsigned initialNumberOfThreads = [JSVirtualMachine setNumberOfDFGCompilerThreads:targetNumberOfThreads];
checkResult(@"Initial number of DFG threads should be the value provided through Options", initialNumberOfThreads == defaultNumberOfThreads);
unsigned updatedNumberOfThreads = [JSVirtualMachine setNumberOfDFGCompilerThreads:initialNumberOfThreads];
checkResult(@"Number of DFG threads should have been updated", updatedNumberOfThreads == targetNumberOfThreads);
@@ -538,7 +538,7 @@
auto testFTL = [] {
unsigned defaultNumberOfThreads = JSC::Options::numberOfFTLCompilerThreads();
unsigned targetNumberOfThreads = 3;
- unsigned initialNumberOfThreads = [JSVirtualMachine setNumberOfFTLCompilerThreads:1];
+ unsigned initialNumberOfThreads = [JSVirtualMachine setNumberOfFTLCompilerThreads:targetNumberOfThreads];
checkResult(@"Initial number of FTL threads should be the value provided through Options", initialNumberOfThreads == defaultNumberOfThreads);
unsigned updatedNumberOfThreads = [JSVirtualMachine setNumberOfFTLCompilerThreads:initialNumberOfThreads];
checkResult(@"Number of FTL threads should have been updated", updatedNumberOfThreads == targetNumberOfThreads);
Modified: trunk/Source/_javascript_Core/ChangeLog (240820 => 240821)
--- trunk/Source/_javascript_Core/ChangeLog 2019-01-31 22:19:52 UTC (rev 240820)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-01-31 22:21:57 UTC (rev 240821)
@@ -1,5 +1,18 @@
2019-01-31 Tadeu Zagallo <[email protected]>
+ Fix `runJITThreadLimitTests` in testapi
+ https://bugs.webkit.org/show_bug.cgi?id=194064
+ <rdar://problem/46139147>
+
+ Reviewed by Mark Lam.
+
+ Fix typo where `targetNumberOfThreads` was not being used.
+
+ * API/tests/testapi.mm:
+ (runJITThreadLimitTests):
+
+2019-01-31 Tadeu Zagallo <[email protected]>
+
testapi fails RELEASE_ASSERT(codeBlock) in fetchFromDisk() of CodeCache.h
https://bugs.webkit.org/show_bug.cgi?id=194112
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
