Title: [240836] trunk/Source/WebCore
- Revision
- 240836
- Author
- mmaxfi...@apple.com
- Date
- 2019-01-31 23:09:22 -0800 (Thu, 31 Jan 2019)
Log Message
[WHLSL] Expressions can't be copyable
https://bugs.webkit.org/show_bug.cgi?id=194116
Reviewed by Keith Rollin.
Expressions have UniqueRef members, which can't be copied. Describe this constraint explicitly rather than implicitly.
No new tests because there is no behavior change.
* Modules/webgpu/WHLSL/AST/WHLSLEnumerationMemberLiteral.h:
* Modules/webgpu/WHLSL/AST/WHLSLExpression.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (240835 => 240836)
--- trunk/Source/WebCore/ChangeLog 2019-02-01 05:53:06 UTC (rev 240835)
+++ trunk/Source/WebCore/ChangeLog 2019-02-01 07:09:22 UTC (rev 240836)
@@ -1,3 +1,17 @@
+2019-01-31 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ [WHLSL] Expressions can't be copyable
+ https://bugs.webkit.org/show_bug.cgi?id=194116
+
+ Reviewed by Keith Rollin.
+
+ Expressions have UniqueRef members, which can't be copied. Describe this constraint explicitly rather than implicitly.
+
+ No new tests because there is no behavior change.
+
+ * Modules/webgpu/WHLSL/AST/WHLSLEnumerationMemberLiteral.h:
+ * Modules/webgpu/WHLSL/AST/WHLSLExpression.h:
+
2019-01-31 Takashi Komori <takashi.kom...@sony.com>
[Curl] Remove unnecessary member from NetworkStorageSession.
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEnumerationMemberLiteral.h (240835 => 240836)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEnumerationMemberLiteral.h 2019-02-01 05:53:06 UTC (rev 240835)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEnumerationMemberLiteral.h 2019-02-01 07:09:22 UTC (rev 240836)
@@ -50,7 +50,7 @@
virtual ~EnumerationMemberLiteral() = default;
- explicit EnumerationMemberLiteral(const EnumerationMemberLiteral&) = default;
+ explicit EnumerationMemberLiteral(const EnumerationMemberLiteral&) = delete;
EnumerationMemberLiteral(EnumerationMemberLiteral&&) = default;
EnumerationMemberLiteral& operator=(const EnumerationMemberLiteral&) = delete;
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLExpression.h (240835 => 240836)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLExpression.h 2019-02-01 05:53:06 UTC (rev 240835)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLExpression.h 2019-02-01 07:09:22 UTC (rev 240836)
@@ -49,10 +49,10 @@
virtual ~_expression_() = default;
- _expression_(const _expression_&) = default;
+ _expression_(const _expression_&) = delete;
_expression_(_expression_&&) = default;
- _expression_& operator=(const _expression_&) = default;
+ _expression_& operator=(const _expression_&) = delete;
_expression_& operator=(_expression_&&) = default;
const Lexer::Token& origin() const { return m_origin; }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
