Title: [240862] trunk/Source/WebKit
- Revision
- 240862
- Author
- [email protected]
- Date
- 2019-02-01 12:20:26 -0800 (Fri, 01 Feb 2019)
Log Message
Force settings.acceleratedCompositingEnabled() to true for WebKit
https://bugs.webkit.org/show_bug.cgi?id=194166
rdar://problem/47694328
Reviewed by Tim Horton.
WebKit relies on accelerated compositing for its drawing areas to function correctly,
and sometimes clients (*cough* Safari *cough*) have bugs where they clobber the settings,
so force this setting to be always on (and release log if this happens).
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (240861 => 240862)
--- trunk/Source/WebKit/ChangeLog 2019-02-01 20:10:23 UTC (rev 240861)
+++ trunk/Source/WebKit/ChangeLog 2019-02-01 20:20:26 UTC (rev 240862)
@@ -1,3 +1,18 @@
+2019-02-01 Simon Fraser <[email protected]>
+
+ Force settings.acceleratedCompositingEnabled() to true for WebKit
+ https://bugs.webkit.org/show_bug.cgi?id=194166
+ rdar://problem/47694328
+
+ Reviewed by Tim Horton.
+
+ WebKit relies on accelerated compositing for its drawing areas to function correctly,
+ and sometimes clients (*cough* Safari *cough*) have bugs where they clobber the settings,
+ so force this setting to be always on (and release log if this happens).
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+
2019-02-01 Antti Koivisto <[email protected]>
Don't use base layer() as the scroll layer in scrolling tree.
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (240861 => 240862)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2019-02-01 20:10:23 UTC (rev 240861)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2019-02-01 20:20:26 UTC (rev 240862)
@@ -3365,6 +3365,11 @@
Settings& settings = m_page->settings();
+ if (!settings.acceleratedCompositingEnabled()) {
+ RELEASE_LOG_IF_ALLOWED("%p - WebPage - acceleratedCompositingEnabled setting was false. WebKit cannot function in this mode; changing setting to true", this);
+ settings.setAcceleratedCompositingEnabled(true);
+ }
+
bool requiresUserGestureForMedia = store.getBoolValueForKey(WebPreferencesKey::requiresUserGestureForMediaPlaybackKey());
settings.setVideoPlaybackRequiresUserGesture(requiresUserGestureForMedia || store.getBoolValueForKey(WebPreferencesKey::requiresUserGestureForVideoPlaybackKey()));
settings.setAudioPlaybackRequiresUserGesture(requiresUserGestureForMedia || store.getBoolValueForKey(WebPreferencesKey::requiresUserGestureForAudioPlaybackKey()));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
