Title: [240868] trunk/Source/WebCore
- Revision
- 240868
- Author
- joep...@webkit.org
- Date
- 2019-02-01 13:24:14 -0800 (Fri, 01 Feb 2019)
Log Message
Web Inspector: Memory timeline starts from zero when both CPU and Memory timeline are enabled
https://bugs.webkit.org/show_bug.cgi?id=194111
<rdar://problem/47714555>
Rubber-stamped by Devin Rousso.
* page/ResourceUsageThread.cpp:
(WebCore::ResourceUsageThread::waitUntilObservers):
(WebCore::ResourceUsageThread::threadBody):
Wait a short period of time before the first listener registers
and we start sampling. This will allow multiple listeners to
register, each that wants different data.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (240867 => 240868)
--- trunk/Source/WebCore/ChangeLog 2019-02-01 21:24:12 UTC (rev 240867)
+++ trunk/Source/WebCore/ChangeLog 2019-02-01 21:24:14 UTC (rev 240868)
@@ -1,3 +1,18 @@
+2019-02-01 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Memory timeline starts from zero when both CPU and Memory timeline are enabled
+ https://bugs.webkit.org/show_bug.cgi?id=194111
+ <rdar://problem/47714555>
+
+ Rubber-stamped by Devin Rousso.
+
+ * page/ResourceUsageThread.cpp:
+ (WebCore::ResourceUsageThread::waitUntilObservers):
+ (WebCore::ResourceUsageThread::threadBody):
+ Wait a short period of time before the first listener registers
+ and we start sampling. This will allow multiple listeners to
+ register, each that wants different data.
+
2019-02-01 Antti Koivisto <an...@apple.com>
Don't use base layer() as the scroll layer in scrolling tree.
Modified: trunk/Source/WebCore/page/ResourceUsageThread.cpp (240867 => 240868)
--- trunk/Source/WebCore/page/ResourceUsageThread.cpp 2019-02-01 21:24:12 UTC (rev 240867)
+++ trunk/Source/WebCore/page/ResourceUsageThread.cpp 2019-02-01 21:24:14 UTC (rev 240868)
@@ -78,8 +78,12 @@
void ResourceUsageThread::waitUntilObservers()
{
LockHolder locker(m_lock);
- while (m_observers.isEmpty())
+ while (m_observers.isEmpty()) {
m_condition.wait(m_lock);
+
+ // Wait a bit after waking up for the first time.
+ WTF::sleep(10_ms);
+ }
}
void ResourceUsageThread::notifyObservers(ResourceUsageData&& data)
@@ -119,6 +123,9 @@
NO_RETURN void ResourceUsageThread::threadBody()
{
+ // Wait a bit after waking up for the first time.
+ WTF::sleep(10_ms);
+
while (true) {
// Only do work if we have observers.
waitUntilObservers();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
