Title: [240886] trunk
- Revision
- 240886
- Author
- [email protected]
- Date
- 2019-02-01 15:54:22 -0800 (Fri, 01 Feb 2019)
Log Message
[LFC] Fix statically positioned replaced out-of-flow horizontal geometry
https://bugs.webkit.org/show_bug.cgi?id=194163
Reviewed by Simon Fraser.
Source/WebCore:
Fix a typo.
* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
Tools:
775
* LayoutReloaded/misc/LFC-passing-tests.txt:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (240885 => 240886)
--- trunk/Source/WebCore/ChangeLog 2019-02-01 23:32:42 UTC (rev 240885)
+++ trunk/Source/WebCore/ChangeLog 2019-02-01 23:54:22 UTC (rev 240886)
@@ -1,3 +1,15 @@
+2019-02-01 Zalan Bujtas <[email protected]>
+
+ [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
+ https://bugs.webkit.org/show_bug.cgi?id=194163
+
+ Reviewed by Simon Fraser.
+
+ Fix a typo.
+
+ * layout/FormattingContextGeometry.cpp:
+ (WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
+
2019-02-01 Chris Dumez <[email protected]>
REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
Modified: trunk/Source/WebCore/layout/FormattingContextGeometry.cpp (240885 => 240886)
--- trunk/Source/WebCore/layout/FormattingContextGeometry.cpp 2019-02-01 23:32:42 UTC (rev 240885)
+++ trunk/Source/WebCore/layout/FormattingContextGeometry.cpp 2019-02-01 23:54:22 UTC (rev 240886)
@@ -711,7 +711,7 @@
// For out-of-flow elements the containing block is formed by the padding edge of the ancestor.
// At this point the non-statically positioned value is in the coordinate system of the padding box. Let's convert it to border box coordinate system.
- if (isStaticallyPositioned) {
+ if (!isStaticallyPositioned) {
auto containingBlockPaddingVerticalEdge = containingBlockDisplayBox.paddingBoxLeft();
*left += containingBlockPaddingVerticalEdge;
*right += containingBlockPaddingVerticalEdge;
Modified: trunk/Tools/ChangeLog (240885 => 240886)
--- trunk/Tools/ChangeLog 2019-02-01 23:32:42 UTC (rev 240885)
+++ trunk/Tools/ChangeLog 2019-02-01 23:54:22 UTC (rev 240886)
@@ -1,3 +1,14 @@
+2019-02-01 Zalan Bujtas <[email protected]>
+
+ [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
+ https://bugs.webkit.org/show_bug.cgi?id=194163
+
+ Reviewed by Simon Fraser.
+
+ 775
+
+ * LayoutReloaded/misc/LFC-passing-tests.txt:
+
2019-02-01 Wenson Hsieh <[email protected]>
[iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
Modified: trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt (240885 => 240886)
--- trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt 2019-02-01 23:32:42 UTC (rev 240885)
+++ trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt 2019-02-01 23:54:22 UTC (rev 240886)
@@ -389,8 +389,10 @@
css2.1/20110323/absolute-non-replaced-height-012.htm
css2.1/20110323/absolute-non-replaced-max-height-001.htm
css2.1/20110323/absolute-non-replaced-max-height-002.htm
+css2.1/t0402-c71-fwd-parsing-00-f.html
css2.1/20110323/absolute-non-replaced-max-height-003.htm
css2.1/20110323/absolute-non-replaced-max-height-004.htm
+css2.1/t0402-c71-fwd-parsing-01-f.html
css2.1/20110323/absolute-non-replaced-max-height-005.htm
css2.1/20110323/absolute-non-replaced-max-height-006.htm
css2.1/20110323/absolute-non-replaced-max-height-007.htm
@@ -405,6 +407,7 @@
css2.1/20110323/absolute-non-replaced-width-004.htm
css2.1/20110323/absolute-non-replaced-width-005.htm
css2.1/20110323/absolute-non-replaced-width-006.htm
+css2.1/t0402-c71-fwd-parsing-03-f.html
css2.1/20110323/absolute-non-replaced-width-007.htm
css2.1/20110323/absolute-non-replaced-width-008.htm
css2.1/20110323/absolute-non-replaced-width-009.htm
@@ -415,9 +418,6 @@
css2.1/20110323/absolute-non-replaced-width-014.htm
css2.1/20110323/absolute-non-replaced-width-015.htm
css2.1/20110323/absolute-non-replaced-width-016.htm
-css2.1/t0402-c71-fwd-parsing-00-f.html
-css2.1/t0402-c71-fwd-parsing-01-f.html
-css2.1/t0402-c71-fwd-parsing-03-f.html
css2.1/t0402-syntax-01-f.html
css2.1/t0402-syntax-02-f.html
css2.1/t0402-syntax-03-f.html
@@ -460,6 +460,7 @@
css2.1/20110323/absolute-replaced-height-026.htm
css2.1/20110323/absolute-replaced-height-028.htm
css2.1/20110323/absolute-replaced-height-029.htm
+css2.1/t0803-c5502-imrgn-r-00-b-ag.html
css2.1/20110323/absolute-replaced-height-030.htm
css2.1/20110323/absolute-replaced-height-031.htm
css2.1/20110323/absolute-replaced-height-032.htm
@@ -467,35 +468,35 @@
css2.1/20110323/absolute-replaced-height-035.htm
css2.1/20110323/absolute-replaced-height-036.htm
css2.1/20110323/absolute-replaced-width-001.htm
+css2.1/20110323/absolute-replaced-width-006.htm
css2.1/20110323/absolute-replaced-width-008.htm
-css2.1/t0803-c5502-imrgn-r-00-b-ag.html
+css2.1/20110323/absolute-replaced-width-013.htm
+css2.1/20110323/absolute-replaced-width-022.htm
+css2.1/20110323/absolute-replaced-width-027.htm
+css2.1/20110323/absolute-replaced-width-034.htm
+css2.1/20110323/absolute-replaced-width-036.htm
+css2.1/20110323/absolute-replaced-width-041.htm
+css2.1/20110323/absolute-replaced-width-043.htm
+css2.1/20110323/absolute-replaced-width-048.htm
+css2.1/20110323/absolute-replaced-width-050.htm
+css2.1/20110323/absolute-replaced-width-055.htm
+css2.1/20110323/absolute-replaced-width-064.htm
+css2.1/20110323/absolute-replaced-width-069.htm
css2.1/t0803-c5502-mrgn-r-02-c.html
css2.1/t0803-c5502-mrgn-r-03-c.html
-css2.1/t0803-c5504-imrgn-l-00-b-ag.html
-css2.1/t0803-c5504-mrgn-l-00-c-ag.html
-css2.1/t0803-c5504-mrgn-l-02-c.html
-css2.1/t0803-c5504-mrgn-l-03-c.html
css2.1/20110323/abspos-containing-block-initial-001.htm
css2.1/20110323/abspos-containing-block-initial-004a.htm
css2.1/20110323/abspos-containing-block-initial-004b.htm
-css2.1/t0803-c5505-mrgn-00-b-ag.html
-css2.1/t0803-c5505-mrgn-03-c-ag.html
-css2.1/t0804-c5506-ipadn-t-00-b-a.html
-css2.1/t0804-c5506-ipadn-t-01-b-a.html
-css2.1/t0804-c5506-ipadn-t-02-b-a.html
+css2.1/t0803-c5504-imrgn-l-00-b-ag.html
css2.1/20110323/abspos-containing-block-initial-005a.htm
-css2.1/t0804-c5507-ipadn-r-00-b-ag.html
css2.1/20110323/abspos-containing-block-initial-005c.htm
css2.1/20110323/abspos-containing-block-initial-007.htm
css2.1/20110323/abspos-containing-block-initial-009b.htm
css2.1/20110323/abspos-containing-block-initial-009e.htm
-css2.1/t0804-c5507-padn-r-00-c-ag.html
-css2.1/t0804-c5507-padn-r-02-f.html
-css2.1/t0804-c5507-padn-r-03-f.html
-css2.1/t0804-c5508-ipadn-b-00-b-a.html
-css2.1/t0804-c5508-ipadn-b-01-f-a.html
-css2.1/t0804-c5508-ipadn-b-02-b-a.html
-css2.1/t0804-c5509-ipadn-l-00-b-ag.html
+css2.1/t0803-c5504-mrgn-l-00-c-ag.html
+css2.1/t0803-c5504-mrgn-l-02-c.html
+css2.1/t0803-c5504-mrgn-l-03-c.html
+css2.1/t0803-c5505-mrgn-00-b-ag.html
css2.1/20110323/at-import-001.htm
css2.1/20110323/at-import-002.htm
css2.1/20110323/at-import-003.htm
@@ -506,37 +507,62 @@
css2.1/20110323/at-import-009.htm
css2.1/20110323/at-import-010.htm
css2.1/20110323/at-import-011.htm
+css2.1/t0803-c5505-mrgn-03-c-ag.html
+css2.1/t0804-c5506-ipadn-t-00-b-a.html
+css2.1/t0804-c5506-ipadn-t-01-b-a.html
+css2.1/t0804-c5506-ipadn-t-02-b-a.html
+css2.1/t0804-c5507-ipadn-r-00-b-ag.html
css2.1/20110323/background-intrinsic-003.htm
-css2.1/t0804-c5509-padn-l-00-b-ag.html
-css2.1/t0804-c5509-padn-l-02-f.html
+css2.1/t0804-c5507-padn-r-00-c-ag.html
css2.1/20110323/background-intrinsic-008.htm
css2.1/20110323/background-intrinsic-009.htm
css2.1/20110323/block-non-replaced-height-001.htm
+css2.1/t0804-c5507-padn-r-02-f.html
+css2.1/t0804-c5507-padn-r-03-f.html
+css2.1/t0804-c5508-ipadn-b-00-b-a.html
+css2.1/t0804-c5508-ipadn-b-01-f-a.html
+css2.1/t0804-c5508-ipadn-b-02-b-a.html
+css2.1/20110323/block-non-replaced-height-003.htm
+css2.1/t0804-c5509-ipadn-l-00-b-ag.html
+css2.1/20110323/block-non-replaced-height-007.htm
+css2.1/20110323/block-non-replaced-height-009.htm
+css2.1/t0804-c5509-padn-l-00-b-ag.html
+css2.1/20110323/block-non-replaced-height-011.htm
+css2.1/t0804-c5509-padn-l-02-f.html
+css2.1/20110323/block-non-replaced-height-013.htm
+css2.1/20110323/block-non-replaced-height-015.htm
css2.1/t0804-c5510-padn-00-b-ag.html
-css2.1/20110323/block-non-replaced-height-003.htm
css2.1/t0804-c5510-padn-02-f.html
css2.1/t0805-c5511-brdr-tw-01-b-g.html
css2.1/t0805-c5511-brdr-tw-02-b.html
css2.1/t0805-c5511-brdr-tw-03-b.html
+css2.1/20110323/block-non-replaced-width-003.htm
+css2.1/20110323/block-non-replaced-width-004.htm
+css2.1/20110323/block-non-replaced-width-005.htm
+css2.1/20110323/block-non-replaced-width-006.htm
+css2.1/20110323/block-non-replaced-width-007.htm
+css2.1/20110323/block-non-replaced-width-008.htm
+css2.1/20110323/block-replaced-height-001.htm
css2.1/t0805-c5512-brdr-rw-00-b.html
css2.1/t0805-c5512-brdr-rw-01-b-g.html
css2.1/t0805-c5512-brdr-rw-02-b.html
css2.1/t0805-c5512-brdr-rw-03-b.html
-css2.1/20110323/block-non-replaced-height-007.htm
-css2.1/20110323/block-non-replaced-height-009.htm
+css2.1/20110323/block-replaced-height-003.htm
+css2.1/20110323/block-replaced-height-004.htm
+css2.1/20110323/block-replaced-height-005.htm
+css2.1/20110323/block-replaced-height-007.htm
+css2.1/20110323/block-replaced-width-001.htm
+css2.1/20110323/block-replaced-width-006.htm
css2.1/t0805-c5513-brdr-bw-01-b-g.html
css2.1/t0805-c5513-brdr-bw-02-b.html
css2.1/t0805-c5513-brdr-bw-03-b.html
-css2.1/20110323/block-non-replaced-height-011.htm
css2.1/t0805-c5514-brdr-lw-00-b.html
css2.1/t0805-c5514-brdr-lw-01-b-g.html
css2.1/t0805-c5514-brdr-lw-02-b.html
css2.1/t0805-c5514-brdr-lw-03-b.html
-css2.1/20110323/block-non-replaced-height-013.htm
css2.1/t0805-c5515-brdr-w-00-a.html
css2.1/t0805-c5515-brdr-w-01-b-g.html
css2.1/t0805-c5515-brdr-w-02-b.html
-css2.1/20110323/block-non-replaced-height-015.htm
css2.1/t0805-c5516-brdr-c-00-a.html
css2.1/t0805-c5516-ibrdr-c-00-a.html
css2.1/t0805-c5517-brdr-s-00-c.html
@@ -543,19 +569,6 @@
css2.1/t0805-c5517-ibrdr-s-00-a.html
css2.1/t0805-c5518-brdr-t-00-a.html
css2.1/t0805-c5518-ibrdr-t-00-a.html
-css2.1/20110323/block-non-replaced-width-003.htm
-css2.1/20110323/block-non-replaced-width-004.htm
-css2.1/20110323/block-non-replaced-width-005.htm
-css2.1/20110323/block-non-replaced-width-006.htm
-css2.1/20110323/block-non-replaced-width-007.htm
-css2.1/20110323/block-non-replaced-width-008.htm
-css2.1/20110323/block-replaced-height-001.htm
-css2.1/20110323/block-replaced-height-003.htm
-css2.1/20110323/block-replaced-height-004.htm
-css2.1/20110323/block-replaced-height-005.htm
-css2.1/20110323/block-replaced-height-007.htm
-css2.1/20110323/block-replaced-width-001.htm
-css2.1/20110323/block-replaced-width-006.htm
css2.1/t0805-c5520-brdr-b-00-a.html
css2.1/t0805-c5520-ibrdr-b-00-a.html
css2.1/t0805-c5522-brdr-00-b.html
@@ -610,6 +623,9 @@
css2.1/t1507-c526-font-sz-01-b-a.html
css2.1/t1507-c526-font-sz-02-b-a.html
css2.1/t1507-c526-font-sz-03-f-a.html
+css2.1/20110323/clip-001.html
+css2.1/20110323/dynamic-top-change-001.htm
+css2.1/20110323/dynamic-top-change-004.htm
css2.1/t1604-c542-letter-sp-00-b-a.html
css2.1/t1605-c545-txttrans-00-b-ag.html
css2.1/t010403-shand-border-00-c.html
@@ -657,13 +673,21 @@
css2.1/t040105-import-10-b.html
css2.1/t040109-c17-comments-00-b.html
css2.1/t040109-c17-comments-01-b.html
+css2.1/20110323/empty-inline-001.htm
css2.1/t040302-c61-phys-len-00-b.html
css2.1/t040302-c61-rel-len-00-b-ag.html
css2.1/t040303-c62-percent-00-b-ag.html
css2.1/t040304-c64-uri-00-a-g.html
+css2.1/20110323/eof-001.htm
css2.1/t040306-syntax-01-f.html
+css2.1/20110323/eof-002.htm
css2.1/t040307-syntax-01-b.html
+css2.1/20110323/eof-003.htm
css2.1/t050201-c12-grouping-00-b.html
+css2.1/20110323/eof-004.htm
+css2.1/20110323/eof-005.htm
+css2.1/20110323/eof-006.htm
+css2.1/20110323/eof-007.htm
css2.1/t051103-c21-activ-ln-00-e-i.html
css2.1/t051103-c21-focus-ln-00-e-i.html
css2.1/t051103-c21-hover-ln-00-e-i.html
@@ -672,20 +696,6 @@
css2.1/t060402-c31-important-00-b.html
css2.1/t060403-c21-pseu-cls-00-e-i.html
css2.1/t060403-c21-pseu-id-00-e-i.html
-css2.1/20110323/clip-001.html
-css2.1/20110323/dynamic-top-change-001.htm
-css2.1/20110323/dynamic-top-change-004.htm
-css2.1/t090501-c414-flt-00-d.html
-css2.1/t090501-c414-flt-02-d-g.html
-css2.1/20110323/empty-inline-001.htm
-css2.1/20110323/eof-001.htm
-css2.1/t100303-c412-blockw-00-d-ag.html
-css2.1/20110323/eof-002.htm
-css2.1/20110323/eof-003.htm
-css2.1/20110323/eof-004.htm
-css2.1/20110323/eof-005.htm
-css2.1/20110323/eof-006.htm
-css2.1/20110323/eof-007.htm
css2.1/20110323/float-non-replaced-height-001.htm
css2.1/20110323/float-non-replaced-width-001.htm
css2.1/20110323/float-non-replaced-width-002.htm
@@ -693,12 +703,9 @@
css2.1/20110323/float-non-replaced-width-004.htm
css2.1/20110323/float-non-replaced-width-005.htm
css2.1/20110323/float-non-replaced-width-006.htm
+css2.1/t090501-c414-flt-00-d.html
+css2.1/t090501-c414-flt-02-d-g.html
css2.1/20110323/float-non-replaced-width-010.htm
-css2.1/t100801-c548-ln-ht-01-b-ag.html
-css2.1/t100801-c548-ln-ht-02-b-ag.html
-css2.1/t100801-c548-ln-ht-03-d-ag.html
-css2.1/t100801-c548-ln-ht-04-d-ag.html
-css2.1/t120401-scope-00-b.html
css2.1/20110323/float-non-replaced-width-012.htm
css2.1/20110323/float-replaced-height-001.htm
css2.1/20110323/float-replaced-height-004.htm
@@ -711,11 +718,18 @@
css2.1/20110323/float-replaced-width-005.htm
css2.1/20110323/float-replaced-width-006.htm
css2.1/20110323/float-replaced-width-011.htm
+css2.1/20110323/floats-001.html
+css2.1/t100303-c412-blockw-00-d-ag.html
+css2.1/t100801-c544-valgn-04-d-agi.html
+css2.1/t100801-c548-ln-ht-01-b-ag.html
+css2.1/t100801-c548-ln-ht-02-b-ag.html
+css2.1/t100801-c548-ln-ht-03-d-ag.html
+css2.1/t100801-c548-ln-ht-04-d-ag.html
+css2.1/t120401-scope-00-b.html
css2.1/t120401-scope-04-d.html
css2.1/t120403-content-none-00-c.html
css2.1/t120403-display-none-00-c.html
css2.1/t120403-visibility-00-c.html
-css2.1/20110323/floats-001.html
css2.1/t140201-c532-bgcolor-01-b.html
css2.1/t140201-c533-bgimage-01-b-g.html
css2.1/t140201-c534-bgre-00-b-ag.html
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
