Title: [240903] trunk/Source/WTF
- Revision
- 240903
- Author
- [email protected]
- Date
- 2019-02-03 05:53:54 -0800 (Sun, 03 Feb 2019)
Log Message
Unreviewed, rolling out r240896.
https://bugs.webkit.org/show_bug.cgi?id=194202
"Fixes leaks, but is probably not the correct fix." (Requested
by ddkilzer on #webkit).
Reverted changeset:
"Leak of WTF::StringImpl under SymbolImpl::createNullSymbol()
(48 bytes) in com.apple.WebKit.WebContent running layout
tests"
https://bugs.webkit.org/show_bug.cgi?id=193291
https://trac.webkit.org/changeset/240896
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (240902 => 240903)
--- trunk/Source/WTF/ChangeLog 2019-02-03 09:05:21 UTC (rev 240902)
+++ trunk/Source/WTF/ChangeLog 2019-02-03 13:53:54 UTC (rev 240903)
@@ -1,3 +1,19 @@
+2019-02-03 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r240896.
+ https://bugs.webkit.org/show_bug.cgi?id=194202
+
+ "Fixes leaks, but is probably not the correct fix." (Requested
+ by ddkilzer on #webkit).
+
+ Reverted changeset:
+
+ "Leak of WTF::StringImpl under SymbolImpl::createNullSymbol()
+ (48 bytes) in com.apple.WebKit.WebContent running layout
+ tests"
+ https://bugs.webkit.org/show_bug.cgi?id=193291
+ https://trac.webkit.org/changeset/240896
+
2019-02-02 David Kilzer <[email protected]>
Leak of WTF::StringImpl under SymbolImpl::createNullSymbol() (48 bytes) in com.apple.WebKit.WebContent running layout tests
Modified: trunk/Source/WTF/wtf/text/SymbolImpl.h (240902 => 240903)
--- trunk/Source/WTF/wtf/text/SymbolImpl.h 2019-02-03 09:05:21 UTC (rev 240902)
+++ trunk/Source/WTF/wtf/text/SymbolImpl.h 2019-02-03 13:53:54 UTC (rev 240903)
@@ -116,13 +116,6 @@
ASSERT(StringImpl::tailOffset<StringImpl*>() == OBJECT_OFFSETOF(SymbolImpl, m_owner));
}
- ~SymbolImpl()
- {
- if (m_owner != StringImpl::empty())
- m_owner->deref();
- m_owner = nullptr;
- }
-
// The pointer to the owner string should be immediately following after the StringImpl layout,
// since we would like to align the layout of SymbolImpl to the one of BufferSubstring StringImpl.
StringImpl* m_owner;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
