Modified: trunk/Source/WebInspectorUI/ChangeLog (240951 => 240952)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-02-05 01:09:57 UTC (rev 240951)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-02-05 01:11:56 UTC (rev 240952)
@@ -1,3 +1,20 @@
+2019-02-04 Devin Rousso <[email protected]>
+
+ Web Inspector: Resources: missing resource data for document on reload
+ https://bugs.webkit.org/show_bug.cgi?id=194243
+ <rdar://problem/47559021>
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/ResourceDetailsSidebarPanel.js:
+ (WI.ResourceDetailsSidebarPanel.prototype.set resource):
+ (WI.ResourceDetailsSidebarPanel.prototype._applyResourceEventListeners):
+
+ * UserInterface/Base/Object.js:
+ (WI.Object.removeEventListener):
+ Drive-by: there's no need to iterate over the entire table to check if `thisObject` exists,
+ as that is handled for us by `ListMultimap`, which we later call anyways.
+
2019-02-04 Matt Baker <[email protected]>
Web Inspector: REGRESSION: Resources: WI.TreeOutline assertions when refreshing the page
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Object.js (240951 => 240952)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Object.js 2019-02-05 01:09:57 UTC (rev 240951)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Object.js 2019-02-05 01:11:56 UTC (rev 240952)
@@ -79,12 +79,7 @@
if (thisObject && !eventType) {
this._listeners.forEach(function(listenersTable) {
- let listenerPairs = listenersTable.toArray();
- for (let i = 0, length = listenerPairs.length; i < length; ++i) {
- let existingThisObject = listenerPairs[i][0];
- if (existingThisObject === thisObject)
- listenersTable.deleteAll(existingThisObject);
- }
+ listenersTable.deleteAll(thisObject);
});
return;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js (240951 => 240952)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js 2019-02-05 01:09:57 UTC (rev 240951)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js 2019-02-05 01:11:56 UTC (rev 240952)
@@ -82,16 +82,7 @@
return;
if (this._resource && this._needsToRemoveResourceEventListeners) {
- this._resource.removeEventListener(WI.Resource.Event.URLDidChange, this._refreshURL, this);
- this._resource.removeEventListener(WI.Resource.Event.MIMETypeDidChange, this._refreshMIMEType, this);
- this._resource.removeEventListener(WI.Resource.Event.TypeDidChange, this._refreshResourceType, this);
- this._resource.removeEventListener(WI.Resource.Event.LoadingDidFail, this._refreshErrorReason, this);
- this._resource.removeEventListener(WI.Resource.Event.RequestHeadersDidChange, this._refreshRequestHeaders, this);
- this._resource.removeEventListener(WI.Resource.Event.ResponseReceived, this._refreshRequestAndResponse, this);
- this._resource.removeEventListener(WI.Resource.Event.CacheStatusDidChange, this._refreshRequestAndResponse, this);
- this._resource.removeEventListener(WI.Resource.Event.SizeDidChange, this._refreshDecodedSize, this);
- this._resource.removeEventListener(WI.Resource.Event.TransferSizeDidChange, this._refreshTransferSize, this);
- this._resource.removeEventListener(WI.Resource.Event.InitiatedResourcesDidChange, this._refreshRelatedResourcesSection, this);
+ this._resource.removeEventListener(null, null, this);
this._needsToRemoveResourceEventListeners = false;
}
@@ -99,7 +90,7 @@
this._resource = resource;
if (this._resource) {
- if (this.parentSidebar)
+ if (this.didInitialLayout)
this._applyResourceEventListeners();
else
this._needsToApplyResourceEventListeners = true;
@@ -621,6 +612,7 @@
this._resource.addEventListener(WI.Resource.Event.RequestHeadersDidChange, this._refreshRequestHeaders, this);
this._resource.addEventListener(WI.Resource.Event.ResponseReceived, this._refreshRequestAndResponse, this);
this._resource.addEventListener(WI.Resource.Event.CacheStatusDidChange, this._refreshRequestAndResponse, this);
+ this._resource.addEventListener(WI.Resource.Event.MetricsDidChange, this._refreshRequestAndResponse, this);
this._resource.addEventListener(WI.Resource.Event.SizeDidChange, this._refreshDecodedSize, this);
this._resource.addEventListener(WI.Resource.Event.TransferSizeDidChange, this._refreshTransferSize, this);
this._resource.addEventListener(WI.Resource.Event.InitiatedResourcesDidChange, this._refreshRelatedResourcesSection, this);
