Title: [240958] trunk/Source/WebCore
- Revision
- 240958
- Author
- [email protected]
- Date
- 2019-02-04 17:34:39 -0800 (Mon, 04 Feb 2019)
Log Message
[curl] ASSERTION FAILED: !m_didNotifyResponse || m_multipartHandle
https://bugs.webkit.org/show_bug.cgi?id=190895
Reviewed by Ross Kirsling.
An assertion was failing in CurlRequest::invokeDidReceiveResponse
because DidReceiveResponse was already dispatched. This condition
was met if CurlRequestScheduler::completeTransfer is called while
waiting for the reply for the first DidReceiveResponse.
No new tests, covered by existing tests.
* platform/network/curl/CurlRequest.h:
(WebCore::CurlRequest::needToInvokeDidReceiveResponse const):
Return true if m_didNotifyResponse is false disregard to
m_didReturnFromNotify.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (240957 => 240958)
--- trunk/Source/WebCore/ChangeLog 2019-02-05 01:31:39 UTC (rev 240957)
+++ trunk/Source/WebCore/ChangeLog 2019-02-05 01:34:39 UTC (rev 240958)
@@ -1,3 +1,22 @@
+2019-02-04 Fujii Hironori <[email protected]>
+
+ [curl] ASSERTION FAILED: !m_didNotifyResponse || m_multipartHandle
+ https://bugs.webkit.org/show_bug.cgi?id=190895
+
+ Reviewed by Ross Kirsling.
+
+ An assertion was failing in CurlRequest::invokeDidReceiveResponse
+ because DidReceiveResponse was already dispatched. This condition
+ was met if CurlRequestScheduler::completeTransfer is called while
+ waiting for the reply for the first DidReceiveResponse.
+
+ No new tests, covered by existing tests.
+
+ * platform/network/curl/CurlRequest.h:
+ (WebCore::CurlRequest::needToInvokeDidReceiveResponse const):
+ Return true if m_didNotifyResponse is false disregard to
+ m_didReturnFromNotify.
+
2019-02-04 Said Abou-Hallawa <[email protected]>
[CG] Enable setAdditionalSupportedImageTypes for WK1
Modified: trunk/Source/WebCore/platform/network/curl/CurlRequest.h (240957 => 240958)
--- trunk/Source/WebCore/platform/network/curl/CurlRequest.h 2019-02-05 01:31:39 UTC (rev 240957)
+++ trunk/Source/WebCore/platform/network/curl/CurlRequest.h 2019-02-05 01:34:39 UTC (rev 240958)
@@ -141,7 +141,7 @@
void setupSendData(bool forPutMethod);
// Processing for DidReceiveResponse
- bool needToInvokeDidReceiveResponse() const { return m_didReceiveResponse && (!m_didNotifyResponse || !m_didReturnFromNotify); }
+ bool needToInvokeDidReceiveResponse() const { return m_didReceiveResponse && !m_didNotifyResponse; }
bool needToInvokeDidCancelTransfer() const { return m_didNotifyResponse && !m_didReturnFromNotify && m_actionAfterInvoke == Action::FinishTransfer; }
void invokeDidReceiveResponseForFile(URL&);
void invokeDidReceiveResponse(const CurlResponse&, Action);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
